| commit | 21716e2da121769b4d473c30360e88ef3061de15 | [log] [tgz] |
|---|---|---|
| author | David Zeuthen <zeuthen@chromium.org> | Wed Apr 23 15:42:05 2014 -0700 |
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | Thu Apr 24 21:58:35 2014 +0000 |
| tree | e4e2f785c552be44196477264a6c57476d1a0b86 | |
| parent | b22a84994e7aed0703c607bc0b97a4eb3a7ea942 [diff] |
PM: Move the getters/variables on provider base classes to abstract methods. Also make all DoInit() overrides in subclasses private, not protected and ensure that all the abstract Provider interface classes has virtual destructors. Additionally, remove inlining of virtual methods in derived classes since it won't matter much in our application. This is because we'll call these methods only indirectly e.g. through a vtable dispatch via a method call on the interface class. BUG=chromium:364763 TEST=Unit tests pass. Change-Id: I7f6a10d9c0b01c4f5c035125755ef132738e72aa Reviewed-on: https://chromium-review.googlesource.com/196656 Reviewed-by: David Zeuthen <zeuthen@chromium.org> Tested-by: David Zeuthen <zeuthen@chromium.org> Commit-Queue: David Zeuthen <zeuthen@chromium.org>