commit 1f93d031baa4c0c4f390fcf5784b5179d15f289d
author Alex Deymo <deymo@chromium.org> Tue Mar 10 18:58:32 2015 -0700
committer ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Thu Mar 12 05:17:19 2015 +0000
tree 40df388fbc11092a9af38c49f8ce6d8cc79bc47c
parent 08d493198de248281beb5c9e2f37904edccf60dc

update_engine: Make dd less verbose.

update_engine unit tests use the "dd" command for setting up some test
cases. By default, dd print the status of the operation on success.

This patch removes the status message reducing the unnecessary logs.

BUG=None
TEST=`FEATURES=test emerge-link update_engine`

Change-Id: I6dbb7029a8dce9acf1309da1844af558a2bdab56
Reviewed-on: https://chromium-review.googlesource.com/259190
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Commit-Queue: Alex Deymo <deymo@chromium.org>
Trybot-Ready: Alex Deymo <deymo@chromium.org>
Tested-by: Alex Deymo <deymo@chromium.org>

delta_performer_unittest.cc

diff --git a/delta_performer_unittest.cc b/delta_performer_unittest.cc
index 71c650c..6aa61a3 100644
--- a/delta_performer_unittest.cc
+++ b/delta_performer_unittest.cc
@@ -290,7 +290,7 @@
 
   // Extend the "partitions" holding the file system a bit.
   EXPECT_EQ(0, System(base::StringPrintf(
-      "dd if=/dev/zero of=%s seek=%d bs=1 count=1",
+      "dd if=/dev/zero of=%s seek=%d bs=1 count=1 status=none",
       state->a_img.c_str(),
       state->image_size + 1024 * 1024 - 1)));
   EXPECT_EQ(state->image_size + 1024 * 1024, utils::FileSize(state->a_img));
@@ -343,7 +343,7 @@
 
     EXPECT_EQ(0,
               System(base::StringPrintf("dd if=/dev/zero of=%s/move-semi-sparse"
-                                        " bs=1 seek=4096 count=1",
+                                        " bs=1 seek=4096 count=1 status=none",
                                         a_mnt.c_str()).c_str()));
 
     // Write 1 MiB of 0xff to try to catch the case where writing a bsdiff
@@ -362,7 +362,7 @@
   } else {
     test_utils::CreateExtImageAtPath(state->b_img, nullptr);
     EXPECT_EQ(0, System(base::StringPrintf(
-        "dd if=/dev/zero of=%s seek=%d bs=1 count=1",
+        "dd if=/dev/zero of=%s seek=%d bs=1 count=1 status=none",
         state->b_img.c_str(),
         state->image_size + 1024 * 1024 - 1)));
     EXPECT_EQ(state->image_size + 1024 * 1024, utils::FileSize(state->b_img));
@@ -400,12 +400,12 @@
 
     EXPECT_EQ(0, System(base::StringPrintf("dd if=/dev/zero "
                                            "of=%s/move-semi-sparse "
-                                           "bs=1 seek=4096 count=1",
+                                           "bs=1 seek=4096 count=1 status=none",
                                            b_mnt.c_str()).c_str()));
 
     EXPECT_EQ(0, System(base::StringPrintf("dd if=/dev/zero "
                                            "of=%s/partsparse bs=1 "
-                                           "seek=4096 count=1",
+                                           "seek=4096 count=1 status=none",
                                            b_mnt.c_str()).c_str()));
     EXPECT_EQ(0, System(base::StringPrintf("cp %s/srchardlink0 %s/tmp && "
                                            "mv %s/tmp %s/srchardlink1",