Gitiles
Code Review Sign In
gerrit.omnirom.org / android_system_update_engine / 42132993563a200785df323460a886aae1af27ed
commit42132993563a200785df323460a886aae1af27ed[log] [tgz]
authorKyeongkab.Nam <Kyeongkab.Nam@sony.com>Thu Oct 03 18:04:02 2019 +0900
committerTao Bao <tbao@google.com>Mon Oct 07 16:38:07 2019 +0000
tree1a1c1469a839127d0ab8676dd41dcc53906d73c1
parent6cf830b8913e741d7d3c7ed047b2cbdbb222034e [diff]
Use ParcelFileDescriptor over FileDescriptor

The java.io.FileDescriptor object has a poor definition of ownership,
which can result in obscure use-after-close bugs. Instead, APIs should
return or accept ParcelFileDescriptor instances.

Bug: 130209137
Test: manual
Change-Id: Iad17731f34109493fc62d0ba0941998ce3ecb98c
3 files changed
tree: 1a1c1469a839127d0ab8676dd41dcc53906d73c1
  1. binder_bindings/
  2. client_library/
  3. common/
  4. dbus_bindings/
  5. fuzz/
  6. init/
  7. payload_consumer/
  8. payload_generator/
  9. sample_images/
  10. scripts/
  11. update_engine/
  12. update_manager/
  13. update_payload_key/
  14. .clang-format
  15. .gitignore
  16. Android.bp
  17. binder_service_android.cc
  18. binder_service_android.h
  19. binder_service_brillo.cc
  20. binder_service_brillo.h
  21. boot_control_android.cc
  22. boot_control_android.h
  23. boot_control_android_unittest.cc
  24. boot_control_chromeos.cc
  25. boot_control_chromeos.h
  26. boot_control_chromeos_unittest.cc
  27. certificate_checker.cc
  28. certificate_checker.h
  29. certificate_checker_unittest.cc
  30. chrome_browser_proxy_resolver.cc
  31. chrome_browser_proxy_resolver.h
  32. COMMIT-QUEUE.ini
  33. common_service.cc
  34. common_service.h
  35. common_service_unittest.cc
  36. connection_manager.cc
  37. connection_manager.h
  38. connection_manager_android.cc
  39. connection_manager_android.h
  40. connection_manager_interface.h
  41. connection_manager_unittest.cc
  42. connection_utils.cc
  43. connection_utils.h
  44. CPPLINT.cfg
  45. daemon.cc
  46. daemon.h
  47. daemon_state_android.cc
  48. daemon_state_android.h
  49. daemon_state_interface.h
  50. dbus_connection.cc
  51. dbus_connection.h
  52. dbus_service.cc
  53. dbus_service.h
  54. dbus_test_utils.h
  55. dlcservice_chromeos.cc
  56. dlcservice_chromeos.h
  57. dynamic_partition_control_android.cc
  58. dynamic_partition_control_android.h
  59. dynamic_partition_control_android_unittest.cc
  60. dynamic_partition_control_interface.h
  61. dynamic_partition_test_utils.h
  62. dynamic_partition_utils.cc
  63. dynamic_partition_utils.h
  64. fake_file_writer.h
  65. fake_p2p_manager.h
  66. fake_p2p_manager_configuration.h
  67. fake_shill_proxy.cc
  68. fake_shill_proxy.h
  69. fake_system_state.cc
  70. fake_system_state.h
  71. generate_pc_file.sh
  72. hardware_android.cc
  73. hardware_android.h
  74. hardware_chromeos.cc
  75. hardware_chromeos.h
  76. hardware_chromeos_unittest.cc
  77. image_properties.h
  78. image_properties_android.cc
  79. image_properties_android_unittest.cc
  80. image_properties_chromeos.cc
  81. image_properties_chromeos_unittest.cc
  82. libcurl_http_fetcher.cc
  83. libcurl_http_fetcher.h
  84. libupdate_engine-client-test.pc.in
  85. libupdate_engine-client.pc.in
  86. local_coverage_rate
  87. main.cc
  88. metrics_constants.h
  89. metrics_reporter_android.cc
  90. metrics_reporter_android.h
  91. metrics_reporter_interface.h
  92. metrics_reporter_omaha.cc
  93. metrics_reporter_omaha.h
  94. metrics_reporter_omaha_unittest.cc
  95. metrics_reporter_stub.cc
  96. metrics_reporter_stub.h
  97. metrics_utils.cc
  98. metrics_utils.h
  99. metrics_utils_unittest.cc
  100. mock_boot_control_hal.h
  101. mock_certificate_checker.h
  102. mock_connection_manager.h
  103. mock_dynamic_partition_control.h
  104. mock_file_writer.h
  105. mock_metrics_reporter.h
  106. mock_omaha_request_params.h
  107. mock_p2p_manager.h
  108. mock_payload_state.h
  109. mock_power_manager.h
  110. mock_service_observer.h
  111. mock_update_attempter.h
  112. MODULE_LICENSE_APACHE2
  113. network_selector.h
  114. network_selector_android.cc
  115. network_selector_android.h
  116. network_selector_interface.h
  117. network_selector_stub.cc
  118. network_selector_stub.h
  119. NOTICE
  120. omaha_request_action.cc
  121. omaha_request_action.h
  122. omaha_request_action_fuzzer.cc
  123. omaha_request_action_unittest.cc
  124. omaha_request_params.cc
  125. omaha_request_params.h
  126. omaha_request_params_unittest.cc
  127. omaha_response.h
  128. omaha_response_handler_action.cc
  129. omaha_response_handler_action.h
  130. omaha_response_handler_action_unittest.cc
  131. omaha_utils.cc
  132. omaha_utils.h
  133. omaha_utils_unittest.cc
  134. OWNERS
  135. p2p_manager.cc
  136. p2p_manager.h
  137. p2p_manager_unittest.cc
  138. parcelable_update_engine_status.cc
  139. parcelable_update_engine_status.h
  140. parcelable_update_engine_status_unittest.cc
  141. payload_state.cc
  142. payload_state.h
  143. payload_state_interface.h
  144. payload_state_unittest.cc
  145. power_manager_android.cc
  146. power_manager_android.h
  147. power_manager_chromeos.cc
  148. power_manager_chromeos.h
  149. power_manager_interface.h
  150. PRESUBMIT.cfg
  151. PREUPLOAD.cfg
  152. pylintrc
  153. real_system_state.cc
  154. real_system_state.h
  155. run_unittests
  156. sample_omaha_v3_response.xml
  157. service_delegate_android_interface.h
  158. service_observer_interface.h
  159. shill_proxy.cc
  160. shill_proxy.h
  161. shill_proxy_interface.h
  162. sideload_main.cc
  163. system_state.h
  164. tar_bunzip2.gypi
  165. test_config.xml
  166. test_http_server.cc
  167. test_subprocess.cc
  168. testrunner.cc
  169. unittest_key.pem
  170. unittest_key2.pem
  171. unittest_key_RSA4096.pem
  172. update_attempter.cc
  173. update_attempter.h
  174. update_attempter_android.cc
  175. update_attempter_android.h
  176. update_attempter_android_unittest.cc
  177. update_attempter_unittest.cc
  178. update_boot_flags_action.cc
  179. update_boot_flags_action.h
  180. update_boot_flags_action_unittest.cc
  181. update_engine-client.gyp
  182. update_engine.conf
  183. update_engine.gyp
  184. update_engine.rc
  185. update_engine_client.cc
  186. update_engine_client_android.cc
  187. update_metadata.proto
  188. update_status_utils.cc
  189. update_status_utils.h
  190. UpdateEngine.conf