commit 1d99ae19320b94cb9fe684498325d6814fe99938
author Kelvin Zhang <zhangkelvin@google.com> Wed May 12 13:29:27 2021 -0400
committer Kelvin Zhang <zhangkelvin@google.com> Thu May 13 14:21:46 2021 -0400
tree 1b94cd80ad575be46fef4f042e32791cbd5d3319
parent 866034758956e0c47ab2e642c4ed8fdfa3e88a72

Fix some lint/style error

Test: th
Change-Id: I57a36f8f6254d3e57a4787f1a7d3cc3368bbd7a7

payload_consumer/filesystem_verifier_action.cc

diff --git a/payload_consumer/filesystem_verifier_action.cc b/payload_consumer/filesystem_verifier_action.cc
index bec5aca..22c8e0b 100644
--- a/payload_consumer/filesystem_verifier_action.cc
+++ b/payload_consumer/filesystem_verifier_action.cc
@@ -78,7 +78,7 @@
 
 namespace {
 const off_t kReadFileBufferSize = 128 * 1024;
-constexpr float VERITY_PROGRESS_PERCENT = 0.6;
+constexpr float kVerityProgressPercent = 0.6;
 }  // namespace
 
 void FilesystemVerifierAction::PerformAction() {
@@ -136,9 +136,9 @@
 }
 
 void FilesystemVerifierAction::UpdatePartitionProgress(double progress) {
-  // WE don't consider sizes of each partition. Every partition
+  // We don't consider sizes of each partition. Every partition
   // has the same length on progress bar.
-  // TODO(zhangkelvin) Take sizes of each partition into account
+  // TODO(b/186087589): Take sizes of each partition into account.
   UpdateProgress((progress + partition_index_) /
                  install_plan_.partitions.size());
 }
@@ -213,7 +213,7 @@
       return;
     }
     if (dynamic_control_->UpdateUsesSnapshotCompression()) {
-      // spin up snapuserd to read fs
+      // Spin up snapuserd to read fs.
       if (!InitializeFdVABC(false)) {
         LOG(ERROR) << "Failed to map all partitions";
         Cleanup(ErrorCode::kFilesystemVerifierError);
@@ -245,7 +245,7 @@
     return;
   }
   UpdatePartitionProgress((start_offset + bytes_read) * 1.0f / partition_size_ *
-                          VERITY_PROGRESS_PERCENT);
+                          kVerityProgressPercent);
   CHECK(pending_task_id_.PostTask(
       FROM_HERE,
       base::BindOnce(&FilesystemVerifierAction::WriteVerityAndHashPartition,
@@ -290,8 +290,8 @@
     return;
   }
   const auto progress = (start_offset + bytes_read) * 1.0f / partition_size_;
-  UpdatePartitionProgress(progress * (1 - VERITY_PROGRESS_PERCENT) +
-                          VERITY_PROGRESS_PERCENT);
+  UpdatePartitionProgress(progress * (1 - kVerityProgressPercent) +
+                          kVerityProgressPercent);
   CHECK(pending_task_id_.PostTask(
       FROM_HERE,
       base::BindOnce(&FilesystemVerifierAction::HashPartition,