Fix pylint warnings and use python3 in payload_info
Fix pylint warnings and silence false warnings.
Correct import so that --signatures options works again.
Set python interpreter to python3 as file is not compatible
with python 2.
Test: pylint --rcfile=../pylintrc payload_info.py
Test: ./payload_info.py --list_ops --stats --signatures payload.bin
Test: th
Change-Id: Icece502b5cd76157b489523d20b1fa3358ef2468
diff --git a/scripts/payload_info.py b/scripts/payload_info.py
index 8343d21..ddf8947 100755
--- a/scripts/payload_info.py
+++ b/scripts/payload_info.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
# -*- coding: utf-8 -*-
#
# Copyright (C) 2015 The Android Open Source Project
@@ -26,6 +26,7 @@
import textwrap
from six.moves import range
+import update_metadata_pb2
import update_payload
@@ -33,7 +34,7 @@
def DisplayValue(key, value):
"""Print out a key, value pair with values left-aligned."""
- if value != None:
+ if value is not None:
print('%-*s %s' % (28, key + ':', value))
else:
raise ValueError('Cannot display an empty value.')
@@ -50,7 +51,7 @@
''.join(chr(c) if 32 <= c < 127 else '.' for c in chunk))
-class PayloadCommand(object):
+class PayloadCommand:
"""Show basic information about an update payload.
This command parses an update payload and displays information from
@@ -70,6 +71,7 @@
def _DisplayManifest(self):
"""Show information from the payload manifest."""
manifest = self.payload.manifest
+ # pylint: disable=no-member
DisplayValue('Number of partitions', len(manifest.partitions))
for partition in manifest.partitions:
DisplayValue(' Number of "%s" ops' % partition.partition_name,
@@ -101,6 +103,7 @@
manifest = self.payload.manifest
if manifest.HasField('signatures_offset'):
+ # pylint: disable=no-member
signature_msg = 'blob_offset=%d' % manifest.signatures_offset
if manifest.signatures_size:
signature_msg += ' (%d bytes)' % manifest.signatures_size
@@ -114,8 +117,9 @@
@staticmethod
def _DisplaySignaturesBlob(signature_name, signatures_blob):
"""Show information about the signatures blob."""
- signatures = update_payload.update_metadata_pb2.Signatures()
+ signatures = update_metadata_pb2.Signatures()
signatures.ParseFromString(signatures_blob)
+ # pylint: disable=no-member
print('%s signatures: (%d entries)' %
(signature_name, len(signatures.signatures)))
for signature in signatures.signatures:
@@ -211,6 +215,7 @@
self._DisplayStats(self.payload.manifest)
if self.options.list_ops:
print()
+ # pylint: disable=no-member
for partition in self.payload.manifest.partitions:
self._DisplayOps('%s install operations' % partition.partition_name,
partition.operations)