PolicyManager: Add a Variable "Mode" property.
There are three kinds of Variables: Const, Poll and Async; that
reflect how the value on the variable changes. Const variables don't
change its value, Poll variables can change the value without notice
and Async variables can change the value but notify the observers
with those changes.
This patch adds the Mode property to the BaseVariable class. This
property can be used by the EvaluationContext to determine how to
treat a given variable.
BUG=chromium:341209
TEST=unit test added and passing.
Change-Id: Ifd4ebcfb84cdb9c6cca1ccbb34004cbac0ea2d2f
Reviewed-on: https://chromium-review.googlesource.com/187240
Reviewed-by: Alex Deymo <deymo@chromium.org>
Commit-Queue: Alex Deymo <deymo@chromium.org>
Tested-by: Alex Deymo <deymo@chromium.org>
diff --git a/policy_manager/variable_unittest.cc b/policy_manager/variable_unittest.cc
index 8c7bdc5..e346c0d 100644
--- a/policy_manager/variable_unittest.cc
+++ b/policy_manager/variable_unittest.cc
@@ -14,7 +14,8 @@
template <typename T>
class DefaultVariable : public Variable<T> {
public:
- DefaultVariable(const string& name) : Variable<T>(name) {}
+ DefaultVariable(const string& name, VariableMode mode)
+ : Variable<T>(name, mode) {}
virtual ~DefaultVariable() {}
protected:
@@ -28,8 +29,15 @@
};
TEST(PmBaseVariableTest, GetNameTest) {
- DefaultVariable<int> var("var");
+ DefaultVariable<int> var("var", kVariableModeConst);
EXPECT_EQ(var.GetName(), string("var"));
}
+TEST(PmBaseVariableTest, GetModeTest) {
+ DefaultVariable<int> var("var", kVariableModeConst);
+ EXPECT_EQ(var.GetMode(), kVariableModeConst);
+ DefaultVariable<int> other_var("other_var", kVariableModePoll);
+ EXPECT_EQ(other_var.GetMode(), kVariableModePoll);
+}
+
} // namespace chromeos_policy_manager