commit 056b0abc1273a6eebfd73060a1d0344ef02b8696
author J. Richard Barnette <jrbarnette@chromium.org> Tue Oct 29 15:24:56 2013 -0700
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Wed Oct 30 21:52:04 2013 +0000
tree ac9a854d749150507eb20f14bbda339083f76b41
parent 522d36ffca22b8c218cdc6a2d1dbab40f6d9b215

Move IsOfficialBuild() and IsNormalBootMode() into HardwareInterface.

This makes the implementation of the two methods part of the
HardwareInterface, so that unit tests won't end up with meaningless
(and unpredictable) calls to the real functions.

BUG=None
TEST=unit tests

Change-Id: Ia23932634124987c1d6ff0683acb15cf4819bc5e
Reviewed-on: https://chromium-review.googlesource.com/175024
Reviewed-by: Chris Sosa <sosa@chromium.org>
Commit-Queue: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>

omaha_request_action.cc

diff --git a/omaha_request_action.cc b/omaha_request_action.cc
index 016b5a8..5ce59bb 100644
--- a/omaha_request_action.cc
+++ b/omaha_request_action.cc
@@ -21,6 +21,7 @@
 
 #include "update_engine/action_pipe.h"
 #include "update_engine/constants.h"
+#include "update_engine/hardware_interface.h"
 #include "update_engine/omaha_hash_calculator.h"
 #include "update_engine/omaha_request_params.h"
 #include "update_engine/p2p_manager.h"
@@ -725,7 +726,7 @@
   if (IsEvent()) {
     CHECK(!HasOutputPipe()) << "No output pipe allowed for event requests.";
     if (event_->result == OmahaEvent::kResultError && successful &&
-        utils::IsOfficialBuild()) {
+        system_state_->hardware()->IsOfficialBuild()) {
       LOG(INFO) << "Signalling Crash Reporter.";
       utils::ScheduleCrashReporterUpload();
     }