Gitiles
Code Review Sign In
gerrit.omnirom.org / android_system_update_engine / 1f93d098d6d6c341ed7471352fda80c936471a17
commit1f93d098d6d6c341ed7471352fda80c936471a17[log] [tgz]
authorTianjie Xu <xunchang@google.com>Mon Oct 09 12:13:29 2017 -0700
committerTianjie Xu <xunchang@google.com>Mon Oct 09 12:41:46 2017 -0700
treed8144e9e2803eb7899c3aee3a5b4688fa6c0c6f8
parent1b66114d367d1b85b4397bb559e274dbd0ebcd31 [diff]
Split the ReportUpdateAttemptMetrics into two functions

Move out the report download metrics into a new function so that
ReportUpdateAttemptMetrics has a reasonable number of parameters.
Create mocks for these two functions also.

Test: unittest pass
Change-Id: Ib9fc33d282a448c7e2d19bb7e7c06619efc2a278
11 files changed
tree: d8144e9e2803eb7899c3aee3a5b4688fa6c0c6f8
  1. binder_bindings/
  2. client_library/
  3. common/
  4. dbus_bindings/
  5. init/
  6. payload_consumer/
  7. payload_generator/
  8. sample_images/
  9. scripts/
  10. update_manager/
  11. update_payload_key/
  12. .clang-format ⇨ ../../build/tools/brillo-clang-format
  13. .gitignore
  14. Android.mk
  15. binder_service_android.cc
  16. binder_service_android.h
  17. binder_service_brillo.cc
  18. binder_service_brillo.h
  19. boot_control_android.cc
  20. boot_control_android.h
  21. boot_control_chromeos.cc
  22. boot_control_chromeos.h
  23. boot_control_chromeos_unittest.cc
  24. boot_control_recovery.cc
  25. boot_control_recovery.h
  26. boot_control_recovery_stub.cc
  27. certificate_checker.cc
  28. certificate_checker.h
  29. certificate_checker_unittest.cc
  30. chrome_browser_proxy_resolver.cc
  31. chrome_browser_proxy_resolver.h
  32. chrome_browser_proxy_resolver_unittest.cc
  33. common_service.cc
  34. common_service.h
  35. common_service_unittest.cc
  36. connection_manager.cc
  37. connection_manager.h
  38. connection_manager_android.cc
  39. connection_manager_android.h
  40. connection_manager_interface.h
  41. connection_manager_unittest.cc
  42. connection_utils.cc
  43. connection_utils.h
  44. CPPLINT.cfg
  45. daemon.cc
  46. daemon.h
  47. daemon_state_android.cc
  48. daemon_state_android.h
  49. daemon_state_interface.h
  50. dbus_connection.cc
  51. dbus_connection.h
  52. dbus_service.cc
  53. dbus_service.h
  54. dbus_test_utils.h
  55. fake_file_writer.h
  56. fake_p2p_manager.h
  57. fake_p2p_manager_configuration.h
  58. fake_shill_proxy.cc
  59. fake_shill_proxy.h
  60. fake_system_state.cc
  61. fake_system_state.h
  62. generate_pc_file.sh
  63. hardware_android.cc
  64. hardware_android.h
  65. hardware_chromeos.cc
  66. hardware_chromeos.h
  67. hardware_chromeos_unittest.cc
  68. image_properties.h
  69. image_properties_android.cc
  70. image_properties_android_unittest.cc
  71. image_properties_chromeos.cc
  72. image_properties_chromeos_unittest.cc
  73. libcurl_http_fetcher.cc
  74. libcurl_http_fetcher.h
  75. libupdate_engine-client-test.pc.in
  76. libupdate_engine-client.pc.in
  77. local_coverage_rate
  78. main.cc
  79. metrics_constants.h
  80. metrics_reporter_android.cc
  81. metrics_reporter_android.h
  82. metrics_reporter_interface.h
  83. metrics_reporter_omaha.cc
  84. metrics_reporter_omaha.h
  85. metrics_reporter_omaha_unittest.cc
  86. metrics_utils.cc
  87. metrics_utils.h
  88. metrics_utils_unittest.cc
  89. mock_certificate_checker.h
  90. mock_connection_manager.h
  91. mock_file_writer.h
  92. mock_metrics_reporter.h
  93. mock_omaha_request_params.h
  94. mock_p2p_manager.h
  95. mock_payload_state.h
  96. mock_power_manager.h
  97. mock_proxy_resolver.h
  98. mock_service_observer.h
  99. mock_update_attempter.h
  100. MODULE_LICENSE_APACHE2
  101. network_selector.h
  102. network_selector_android.cc
  103. network_selector_android.h
  104. network_selector_interface.h
  105. network_selector_stub.cc
  106. network_selector_stub.h
  107. NOTICE
  108. omaha_request_action.cc
  109. omaha_request_action.h
  110. omaha_request_action_unittest.cc
  111. omaha_request_params.cc
  112. omaha_request_params.h
  113. omaha_request_params_unittest.cc
  114. omaha_response.h
  115. omaha_response_handler_action.cc
  116. omaha_response_handler_action.h
  117. omaha_response_handler_action_unittest.cc
  118. omaha_utils.cc
  119. omaha_utils.h
  120. omaha_utils_unittest.cc
  121. OWNERS
  122. p2p_manager.cc
  123. p2p_manager.h
  124. p2p_manager_unittest.cc
  125. parcelable_update_engine_status.cc
  126. parcelable_update_engine_status.h
  127. parcelable_update_engine_status_unittest.cc
  128. payload_state.cc
  129. payload_state.h
  130. payload_state_interface.h
  131. payload_state_unittest.cc
  132. power_manager_android.cc
  133. power_manager_android.h
  134. power_manager_chromeos.cc
  135. power_manager_chromeos.h
  136. power_manager_interface.h
  137. PRESUBMIT.cfg
  138. PREUPLOAD.cfg
  139. proxy_resolver.cc
  140. proxy_resolver.h
  141. proxy_resolver_unittest.cc
  142. pylintrc
  143. real_system_state.cc
  144. real_system_state.h
  145. run_unittests
  146. sample_omaha_v3_response.xml
  147. service_delegate_android_interface.h
  148. service_observer_interface.h
  149. shill_proxy.cc
  150. shill_proxy.h
  151. shill_proxy_interface.h
  152. sideload_main.cc
  153. system_state.h
  154. tar_bunzip2.gypi
  155. test_http_server.cc
  156. test_subprocess.cc
  157. testrunner.cc
  158. unittest_key.pem
  159. unittest_key2.pem
  160. update_attempter.cc
  161. update_attempter.h
  162. update_attempter_android.cc
  163. update_attempter_android.h
  164. update_attempter_unittest.cc
  165. update_engine-client.gyp
  166. update_engine.conf
  167. update_engine.gyp
  168. update_engine.rc
  169. update_engine_client.cc
  170. update_engine_client_android.cc
  171. update_metadata.proto
  172. update_status_utils.cc
  173. update_status_utils.h
  174. UpdateEngine.conf
  175. utils_android.cc
  176. utils_android.h
  177. WATCHLISTS