update_engine: Update libchrome APIs to r369476
The new libchrome has been ported from Chromium and some APIs have
changed. Make necessary changes at call sites.
Change-Id: I42e65bda7f1dbdf6f6e0ebf356d2cfea6b729193
diff --git a/payload_generator/cycle_breaker.cc b/payload_generator/cycle_breaker.cc
index 321732e..52a6f60 100644
--- a/payload_generator/cycle_breaker.cc
+++ b/payload_generator/cycle_breaker.cc
@@ -108,7 +108,7 @@
CHECK_GE(stack_.size(),
static_cast<vector<Vertex::Index>::size_type>(2));
Edge min_edge = make_pair(stack_[0], stack_[1]);
- uint64_t min_edge_weight = kuint64max;
+ uint64_t min_edge_weight = std::numeric_limits<uint64_t>::max();
size_t edges_considered = 0;
for (vector<Vertex::Index>::const_iterator it = stack_.begin();
it != (stack_.end() - 1); ++it) {
diff --git a/payload_generator/generate_delta_main.cc b/payload_generator/generate_delta_main.cc
index f462347..abf479b 100644
--- a/payload_generator/generate_delta_main.cc
+++ b/payload_generator/generate_delta_main.cc
@@ -56,9 +56,9 @@
void ParseSignatureSizes(const string& signature_sizes_flag,
vector<int>* signature_sizes) {
signature_sizes->clear();
- vector<string> split_strings;
-
- base::SplitString(signature_sizes_flag, ':', &split_strings);
+ vector<string> split_strings =
+ base::SplitString(signature_sizes_flag, ":", base::TRIM_WHITESPACE,
+ base::SPLIT_WANT_ALL);
for (const string& str : split_strings) {
int size = 0;
bool parsing_successful = base::StringToInt(str, &size);
@@ -128,8 +128,9 @@
void SignatureFileFlagToBlobs(const string& signature_file_flag,
vector<brillo::Blob>* signatures) {
- vector<string> signature_files;
- base::SplitString(signature_file_flag, ':', &signature_files);
+ vector<string> signature_files =
+ base::SplitString(signature_file_flag, ":", base::TRIM_WHITESPACE,
+ base::SPLIT_WANT_ALL);
for (const string& signature_file : signature_files) {
brillo::Blob signature;
CHECK(utils::ReadFile(signature_file, &signature));
@@ -378,7 +379,9 @@
PayloadGenerationConfig payload_config;
vector<string> partition_names, old_partitions, new_partitions;
- base::SplitString(FLAGS_partition_names, ':', &partition_names);
+ partition_names =
+ base::SplitString(FLAGS_partition_names, ":", base::TRIM_WHITESPACE,
+ base::SPLIT_WANT_ALL);
CHECK(!partition_names.empty());
if (FLAGS_major_version == kChromeOSMajorPayloadVersion ||
FLAGS_new_partitions.empty()) {
@@ -395,7 +398,9 @@
LOG_IF(FATAL, !FLAGS_new_image.empty() || !FLAGS_new_kernel.empty())
<< "--new_image and --new_kernel are deprecated, please use "
<< "--new_partitions for all partitions.";
- base::SplitString(FLAGS_new_partitions, ':', &new_partitions);
+ new_partitions =
+ base::SplitString(FLAGS_new_partitions, ":", base::TRIM_WHITESPACE,
+ base::SPLIT_WANT_ALL);
CHECK(partition_names.size() == new_partitions.size());
payload_config.is_delta = !FLAGS_old_partitions.empty();
@@ -421,7 +426,9 @@
if (payload_config.is_delta) {
if (!FLAGS_old_partitions.empty()) {
- base::SplitString(FLAGS_old_partitions, ':', &old_partitions);
+ old_partitions =
+ base::SplitString(FLAGS_old_partitions, ":", base::TRIM_WHITESPACE,
+ base::SPLIT_WANT_ALL);
CHECK(old_partitions.size() == new_partitions.size());
} else {
old_partitions = {FLAGS_old_image, FLAGS_old_kernel};
diff --git a/payload_generator/graph_types.h b/payload_generator/graph_types.h
index beee4eb..fee8575 100644
--- a/payload_generator/graph_types.h
+++ b/payload_generator/graph_types.h
@@ -83,7 +83,7 @@
typedef std::pair<Vertex::Index, Vertex::Index> Edge;
const uint64_t kTempBlockStart = 1ULL << 60;
-COMPILE_ASSERT(kTempBlockStart != 0, kTempBlockStart_invalid);
+static_assert(kTempBlockStart != 0, "kTempBlockStart invalid");
} // namespace chromeos_update_engine