commit 1b4e69a734c1dfa57e945799d47266da45281b0e
author William Roberts <william.c.roberts@linux.intel.com> Mon May 11 13:02:46 2015 -0700
committer William Roberts <william.c.roberts@linux.intel.com> Thu May 14 13:03:12 2015 -0700
tree 4375d435675d35ce0f1ec5cd44b8c1a64075d4ce
parent 520bb816b86fe36440767db6e2f05fb4e8a08f3e

make unix_socket_connect() for property service a warning

Encourage the use of set_prop macro by making existing
unix_socket_connect(domain, property, init) calls
warn at compile time. When encountering one of these macros,
m4 will emit a deprecated message as follows:

m4: external/sepolicy/adbd.te: 97: deprecated: unix_socket_connect(adbd, property, init) Please use set_prop(adbd, <property name>) instead.

Change-Id: I997fed75d2683933e08db8b9efeecea71523c7c3
Signed-off-by: William Roberts <william.c.roberts@linux.intel.com>

te_macros

diff --git a/te_macros b/te_macros
index 408d9d5..5248f18 100644
--- a/te_macros
+++ b/te_macros
@@ -129,6 +129,15 @@
 # use set_prop(sourcedomain, targetproperty)
 #
 define(`unix_socket_connect', `
+ifelse($2, `property', `
+    ifelse($3,`init', `
+       print(`deprecated: unix_socket_connect($1, $2, $3) Please use set_prop($1, <property name>) instead.')
+   ')
+')
+__unix_socket_connect__($1, $2, $3)
+')
+
+define(`__unix_socket_connect__', `
 allow $1 $2_socket:sock_file write;
 allow $1 $3:unix_stream_socket connectto;
 ')
@@ -139,7 +148,7 @@
 # targetproperty.
 #
 define(`set_prop', `
-unix_socket_connect($1, property, init)
+__unix_socket_connect__($1, property, init)
 allow $1 $2:property_service set;
 ')
 
@@ -244,11 +253,10 @@
 # trigger runtime reload.
 define(`selinux_manage_policy', `
 security_access_policy($1)
-unix_socket_connect($1, property, init)
 allow $1 security_file:dir create_dir_perms;
 allow $1 security_file:file create_file_perms;
 allow $1 security_file:lnk_file { create rename unlink };
-allow $1 security_prop:property_service set;
+set_prop($1, security_prop)
 ')
 
 #####################################
@@ -257,11 +265,10 @@
 # trigger runtime reload, change
 # mmac enforcing mode and access logcat.
 define(`mmac_manage_policy', `
-unix_socket_connect($1, property, init)
 allow $1 security_file:dir create_dir_perms;
 allow $1 security_file:file create_file_perms;
 allow $1 security_file:lnk_file { create rename unlink };
-allow $1 security_prop:property_service set;
+set_prop($1, security_prop)
 ')
 
 #####################################
@@ -374,3 +381,9 @@
   allow drmserver $1:file { read open };
   allow drmserver $1:process getattr;
 ')
+
+##########################################
+# print a message with a trailing newline
+# print(`args')
+define(`print', `errprint(`m4: '__file__: __line__`: $*
+')')