commit b3bfdb050eb55be61196c6aa662dcd0a048d76ef
author Chih-Hung Hsieh <chh@google.com> Wed Dec 12 14:43:33 2018 -0800
committer Chih-Hung Hsieh <chh@google.com> Wed Dec 12 14:43:45 2018 -0800
tree a52d5ab736a9b528f5a490841ac3173926c95777
parent a4b74660a2b31e7f1b8e5c9b85dcbc36932adca9

Fix performance-for-range-copy warnings

Bug: 30413223
Test: make with WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=-*,performance*
Change-Id: Ibd59f19978cd2d6048fa608723f7d68098a18216

keystore/keymaster_worker.cpp

diff --git a/keystore/keymaster_worker.cpp b/keystore/keymaster_worker.cpp
index c7d2671..fd07e86 100644
--- a/keystore/keymaster_worker.cpp
+++ b/keystore/keymaster_worker.cpp
@@ -346,7 +346,7 @@
         {
             hidl_vec<uint8_t> clientId;
             hidl_vec<uint8_t> appData;
-            for (auto param : opParams) {
+            for (const auto& param : opParams) {
                 if (param.tag == Tag::APPLICATION_ID) {
                     clientId = authorizationValue(TAG_APPLICATION_ID, param).value();
                 } else if (param.tag == Tag::APPLICATION_DATA) {