[dice] Optimize iteration handling in dice::execute_steps
To avoid unnecessary vector collect in the process.
Bug: 267575445
Test: atest diced_utils_test diced_sample_inputs_test \
diced_test diced_vendor_test
Change-Id: I5b78dad7394e6ca88e238ef5806dd574da083657
diff --git a/diced/src/hal_node.rs b/diced/src/hal_node.rs
index 69cf4ac..d2e8b0c 100644
--- a/diced/src/hal_node.rs
+++ b/diced/src/hal_node.rs
@@ -187,10 +187,8 @@
// `ResidentHal::new`
run_forked(move || {
let artifacts = artifacts.with_artifacts(|a| ResidentArtifacts::new_from(a))?;
- let input_values: Vec<utils::InputValues> =
- input_values.iter().map(|v| v.into()).collect();
let artifacts = artifacts
- .execute_steps(input_values.iter().map(|v| v as &dyn dice::InputValues))
+ .execute_steps(input_values)
.context("In ResidentHal::get_effective_artifacts:")?;
f(artifacts)
})
@@ -279,11 +277,8 @@
*artifacts = run_forked(|| {
let new_artifacts =
artifacts_clone.with_artifacts(|a| ResidentArtifacts::new_from(a))?;
- let input_values: Vec<utils::InputValues> =
- input_values.iter().map(|v| v.into()).collect();
-
let new_artifacts = new_artifacts
- .execute_steps(input_values.iter().map(|v| v as &dyn dice::InputValues))
+ .execute_steps(input_values)
.context("In ResidentHal::get_effective_artifacts:")?;
artifacts_clone.update(&new_artifacts)
})?;
@@ -414,11 +409,7 @@
make_input_values("component 2 code", "component 2", "component 2 authority")?,
make_input_values("component 3 code", "component 3", "component 3 authority")?,
];
-
- let input_values: Vec<utils::InputValues> = input_values.iter().map(|v| v.into()).collect();
-
- let new_artifacts =
- artifacts.execute_steps(input_values.iter().map(|v| v as &dyn dice::InputValues))?;
+ let new_artifacts = artifacts.execute_steps(input_values)?;
let result = utils::make_bcc_handover(
new_artifacts.cdi_attest(),