commit 673c6ced22c1d7345c039b7fb0e1e4b2ce127482
author David Zeuthen <zeuthen@google.com> Wed Jun 03 17:24:37 2020 -0400
committer David Zeuthen <zeuthen@google.com> Wed Jun 03 17:26:27 2020 -0400
tree ec5c990d3a7a4342bc38a1627df28a123d69b8cb
parent 0137d70c1af6c107a578ae508548f7663594f3de

credstore: Never pass an empty challenge.

Bug: 156911917
Bug: 158107945
Test: atest VtsHalIdentityTargetTest
Test: atest android.security.identity.cts

Change-Id: Ia274fcbaabb0c0ec7c884070eb30737dc236c064

identity/WritableCredential.cpp

diff --git a/identity/WritableCredential.cpp b/identity/WritableCredential.cpp
index cb2d6ff..a932dcf 100644
--- a/identity/WritableCredential.cpp
+++ b/identity/WritableCredential.cpp
@@ -149,7 +149,7 @@
 WritableCredential::personalize(const vector<AccessControlProfileParcel>& accessControlProfiles,
                                 const vector<EntryNamespaceParcel>& entryNamespaces,
                                 int64_t secureUserId, vector<uint8_t>* _aidl_return) {
-    Status ensureStatus = ensureAttestationCertificateExists({});
+    Status ensureStatus = ensureAttestationCertificateExists({0x00});  // Challenge cannot be empty.
     if (!ensureStatus.isOk()) {
         return ensureStatus;
     }