commit 28e6f0b066c7304952141d0a81ecfc5587a81ead
author Charisee <chiw@google.com> Thu Sep 15 01:07:46 2022 +0000
committer Charisee Chiw <chiw@google.com> Thu Sep 15 23:49:23 2022 +0000
tree b5c7b3475a8fa0657ab9c2efa23def925b2dc3b7
parent 3dcd4b8d7b48fb8030d58ec63ce48fd53fa440eb

Change request for Rust v1.64.0

note from clippy: https://rust-lang.github.io/rust-clippy/master/index.html#manual_retain

Please check change for correctness.

bug: 243420629
Test: test_compiler.py
Change-Id: If64daae01c3bf6d83b80f624c1f5603fae171a2d

keystore2/legacykeystore/lib.rs

diff --git a/keystore2/legacykeystore/lib.rs b/keystore2/legacykeystore/lib.rs
index 95f917a..ed5bd4f 100644
--- a/keystore2/legacykeystore/lib.rs
+++ b/keystore2/legacykeystore/lib.rs
@@ -393,7 +393,7 @@
         let uid = Self::get_effective_uid(uid).context("In list.")?;
         let mut result = self.list_legacy(uid).context("In list.")?;
         result.append(&mut db.list(uid).context("In list: Trying to get list of entries.")?);
-        result = result.into_iter().filter(|s| s.starts_with(prefix)).collect();
+        result.retain(|s| s.starts_with(prefix));
         result.sort_unstable();
         result.dedup();
         Ok(result)