commit 2358fe9d812f52a98c67b644d2059e63cdc4e6d3
author Paul Crowley <paulcrowley@google.com> Thu Apr 29 12:42:56 2021 -0700
committer Paul Crowley <paulcrowley@google.com> Fri Apr 30 10:59:42 2021 -0700
tree b242ea5daf0b599afc55c1cff81d63aa59aef102
parent a5cfbe7ed3c0d8279693290ce35d952e1de6e843

Add getKeyCharacteristics stub to km_compat

Add a stub implementation of getKeyCharacteristics which simply returns
UNIMPLEMENTED. A future change will hook this into the Keymaster
method getKeyCharacteristics.

(cherry picked from commit 48d9ff948f77461a4ead4ec99386d7c7cf2f9c7b)

Bug: 186685601
Test: Treehugger
Ignore-AOSP-First: Implementation exists in internal master only
Merged-In: I24496e6d67eeaeec610998c0139f36f216c621b0
Change-Id: I24496e6d67eeaeec610998c0139f36f216c621b0

keystore2/src/km_compat/km_compat.cpp

diff --git a/keystore2/src/km_compat/km_compat.cpp b/keystore2/src/km_compat/km_compat.cpp
index 4141b1c..bdc3f2a 100644
--- a/keystore2/src/km_compat/km_compat.cpp
+++ b/keystore2/src/km_compat/km_compat.cpp
@@ -687,6 +687,14 @@
     return convertErrorCode(km_error);
 }
 
+ScopedAStatus
+KeyMintDevice::getKeyCharacteristics(const std::vector<uint8_t>& /* storageKeyBlob */,
+                                     const std::vector<uint8_t>& /* appId */,
+                                     const std::vector<uint8_t>& /* appData */,
+                                     std::vector<KeyCharacteristics>* /* keyCharacteristics */) {
+    return convertErrorCode(KMV1::ErrorCode::UNIMPLEMENTED);
+}
+
 ScopedAStatus KeyMintOperation::updateAad(const std::vector<uint8_t>& input,
                                           const std::optional<HardwareAuthToken>& optAuthToken,
                                           const std::optional<TimeStampToken>& optTimeStampToken) {

keystore2/src/km_compat/km_compat.h

diff --git a/keystore2/src/km_compat/km_compat.h b/keystore2/src/km_compat/km_compat.h
index cd2b804..09c9157 100644
--- a/keystore2/src/km_compat/km_compat.h
+++ b/keystore2/src/km_compat/km_compat.h
@@ -118,6 +118,11 @@
     ScopedAStatus convertStorageKeyToEphemeral(const std::vector<uint8_t>& storageKeyBlob,
                                                std::vector<uint8_t>* ephemeralKeyBlob) override;
 
+    ScopedAStatus
+    getKeyCharacteristics(const std::vector<uint8_t>& storageKeyBlob,
+                          const std::vector<uint8_t>& appId, const std::vector<uint8_t>& appData,
+                          std::vector<KeyCharacteristics>* keyCharacteristics) override;
+
     // These are public to allow testing code to use them directly.
     // This class should not be used publicly anyway.
     std::variant<std::vector<Certificate>, KMV1_ErrorCode>