commit c8a68d9aaa348fc09fd7127a3574957e22aa6ad4
author Treehugger Robot <treehugger-gerrit@google.com> Wed Aug 02 16:46:42 2017 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Wed Aug 02 16:46:42 2017 +0000
tree 341e52570873c48ab07b866621c0e68f93e305b6
parent ae0e2fc891a44afbb09a94e39b5d4d131342e3e9
parent 98dcee8e690cbaa80f451e0c65eb22088165ee07

Merge "Change dependency library"

base/HidlInternal.cpp

diff --git a/base/HidlInternal.cpp b/base/HidlInternal.cpp
index 3bb27f8..843fcad 100644
--- a/base/HidlInternal.cpp
+++ b/base/HidlInternal.cpp
@@ -25,13 +25,16 @@
 #include <dirent.h>
 #include <dlfcn.h>
 #include <regex>
+#include <utils/misc.h>
+
+extern "C" __attribute__((weak)) void __sanitizer_cov_dump();
 #endif
 
 namespace android {
 namespace hardware {
 namespace details {
 
-void logAlwaysFatal(const char *message) {
+void logAlwaysFatal(const char* message) {
     LOG(FATAL) << message;
 }
 
@@ -42,9 +45,21 @@
         const std::string &interface)
         : mInstrumentationLibPackage(package), mInterfaceName(interface) {
     configureInstrumentation(false);
+#ifdef LIBHIDL_TARGET_DEBUGGABLE
+    if (__sanitizer_cov_dump != nullptr) {
+        ::android::add_sysprop_change_callback(
+            []() {
+                bool enableCoverage = property_get_bool("hal.coverage.enable", false);
+                if (enableCoverage) {
+                    __sanitizer_cov_dump();
+                }
+            },
+            0);
+    }
+#endif
 }
 
-HidlInstrumentor:: ~HidlInstrumentor() {}
+HidlInstrumentor::~HidlInstrumentor() {}
 
 void HidlInstrumentor::configureInstrumentation(bool log) {
     bool enable_instrumentation = property_get_bool(

base/include/hidl/HidlInternal.h

diff --git a/base/include/hidl/HidlInternal.h b/base/include/hidl/HidlInternal.h
index 9b9457f..d81dd9c 100644
--- a/base/include/hidl/HidlInternal.h
+++ b/base/include/hidl/HidlInternal.h
@@ -37,7 +37,7 @@
 // tag for proxy interfaces (e.x. BpHwFoo)
 struct bphw_tag {};
 
-// tag for server interfaces (e.x. BsFoo)
+// tag for passthrough interfaces (e.x. BsFoo)
 struct bs_tag {};
 
 //Templated classes can use the below method