Merge "Updating warning messages for getTransport."
diff --git a/base/HidlInternal.cpp b/base/HidlInternal.cpp
index 9c0efbb..4f88be5 100644
--- a/base/HidlInternal.cpp
+++ b/base/HidlInternal.cpp
@@ -129,6 +129,7 @@
}
#else
// No-op for user builds.
+ (void) instrumentationCallbacks;
return;
#endif
}
@@ -139,6 +140,8 @@
std::cmatch cm;
std::regex e("^" + mInstrumentationLibPackage + "(.*).profiler.so$");
if (std::regex_match(file->d_name, cm, e)) return true;
+#else
+ (void) file;
#endif
return false;
}
diff --git a/base/include/hidl/Status.h b/base/include/hidl/Status.h
index f3afbc6..2f26ffa 100644
--- a/base/include/hidl/Status.h
+++ b/base/include/hidl/Status.h
@@ -152,7 +152,8 @@
return_status() {}
return_status(Status s) : mStatus(s) {}
- return_status(const return_status &) = default;
+ return_status(const return_status &) = delete;
+ return_status &operator=(const return_status &) = delete;
return_status(return_status &&other) {
*this = std::move(other);
@@ -186,8 +187,6 @@
Return(T v) : details::return_status(), mVal{v} {}
Return(Status s) : details::return_status(s) {}
- Return(const Return &) = default;
-
// move-able.
// precondition: "this" has checked status
// postcondition: other is safe to destroy after moving to *this.
@@ -214,8 +213,6 @@
template<typename U> Return(U* v) : details::return_status(), mVal{v} {}
Return(Status s) : details::return_status(s) {}
- Return(const Return &) = default;
-
// move-able.
// precondition: "this" has checked status
// postcondition: other is safe to destroy after moving to *this.
@@ -236,8 +233,6 @@
Return() : details::return_status() {}
Return(Status s) : details::return_status(s) {}
- Return(const Return &) = default;
-
// move-able.
// precondition: "this" has checked status
// postcondition: other is safe to destroy after moving to *this.
diff --git a/transport/HidlBinderSupport.cpp b/transport/HidlBinderSupport.cpp
index de4519b..30c2323 100644
--- a/transport/HidlBinderSupport.cpp
+++ b/transport/HidlBinderSupport.cpp
@@ -185,5 +185,13 @@
return status;
}
+void configureBinderRpcThreadpool(size_t maxThreads, bool callerWillJoin) {
+ ProcessState::self()->setThreadPoolConfiguration(maxThreads, callerWillJoin /*callerJoinsPool*/);
+}
+
+void joinBinderRpcThreadpool() {
+ IPCThreadState::self()->joinThreadPool();
+}
+
} // namespace hardware
} // namespace android
diff --git a/transport/include/hidl/HidlBinderSupport.h b/transport/include/hidl/HidlBinderSupport.h
index 2fff6cb..e948221 100644
--- a/transport/include/hidl/HidlBinderSupport.h
+++ b/transport/include/hidl/HidlBinderSupport.h
@@ -356,13 +356,8 @@
}
}
-inline void configureBinderRpcThreadpool(size_t maxThreads, bool callerWillJoin) {
- ProcessState::self()->setThreadPoolConfiguration(maxThreads, callerWillJoin /*callerJoinsPool*/);
-}
-
-inline void joinBinderRpcThreadpool() {
- IPCThreadState::self()->joinThreadPool();
-}
+void configureBinderRpcThreadpool(size_t maxThreads, bool callerWillJoin);
+void joinBinderRpcThreadpool();
} // namespace hardware
} // namespace android
diff --git a/transport/include/hidl/Static.h b/transport/include/hidl/Static.h
index d62d675..04b1729 100644
--- a/transport/include/hidl/Static.h
+++ b/transport/include/hidl/Static.h
@@ -21,7 +21,8 @@
#include <android/hidl/manager/1.0/IServiceManager.h>
#include <hidl/ConcurrentMap.h>
#include <hwbinder/IBinder.h>
-#include <utils/threads.h>
+#include <utils/StrongPointer.h>
+#include <utils/Mutex.h>
namespace android {
namespace hardware {