| commit | af4e43cc5b2eacbfe600f9ab0e459f09c35c0c3f | [log] [tgz] |
|---|---|---|
| author | Yifan Hong <elsk@google.com> | Fri Mar 03 19:10:52 2017 -0800 |
| committer | Yifan Hong <elsk@google.com> | Fri Mar 03 19:48:36 2017 -0800 |
| tree | c484f7f824a56bd7a0d4650b1db94703bff53e5b | |
| parent | 6558c77eb11d68069d0c374c39c0f955294f14b8 [diff] |
return_status::checkStatus => assertOk checkStatus doesn't really set mCheckStatus to true, and hence is a misnomer. Change it to assertOk (correspond to isOk()). And hence the move assignment operator should not call checkStatus (because it is valid to move into a Return<T> object that !isOk() but has mCheckedStatus to true), because caller is fully aware of the error that will be overwritten. Test: libhidl_test Change-Id: I86a44967b68619d1467d2cc9caaa39124b156121