Build with -Wall and -Werror.
Test: pass
Change-Id: I0b14bfca491b67883bdff079b2e863db4691b635
diff --git a/Android.bp b/Android.bp
index d44a5e7..59edb20 100644
--- a/Android.bp
+++ b/Android.bp
@@ -18,6 +18,11 @@
"transport", // libhidltransport
]
+libhidl_flags = [
+ "-Wall",
+ "-Werror",
+]
+
cc_test {
name: "libhidl_test",
gtest: false,
@@ -37,5 +42,5 @@
cflags: [
"-O0",
"-g",
- ],
+ ] + libhidl_flags,
}
diff --git a/base/Android.bp b/base/Android.bp
index 635b098..321f499 100644
--- a/base/Android.bp
+++ b/base/Android.bp
@@ -14,6 +14,7 @@
cc_library_shared {
name: "libhidlbase",
+ cflags: libhidl_flags,
shared_libs: [
"libbase",
"libcutils",
diff --git a/libhidlmemory/Android.bp b/libhidlmemory/Android.bp
index 8f27065..2b47483 100644
--- a/libhidlmemory/Android.bp
+++ b/libhidlmemory/Android.bp
@@ -14,6 +14,7 @@
cc_library_shared {
name: "libhidlmemory",
+ cflags: libhidl_flags,
shared_libs: [
"libbase",
"liblog",
diff --git a/transport/Android.bp b/transport/Android.bp
index 0c32653..b1df04e 100644
--- a/transport/Android.bp
+++ b/transport/Android.bp
@@ -24,6 +24,7 @@
cc_library_shared {
name: "libhidltransport",
+ cflags: libhidl_flags,
shared_libs: [
"libbase",
"liblog",
diff --git a/transport/allocator/1.0/default/Android.bp b/transport/allocator/1.0/default/Android.bp
index 914fc8d..d15d7c2 100644
--- a/transport/allocator/1.0/default/Android.bp
+++ b/transport/allocator/1.0/default/Android.bp
@@ -15,6 +15,7 @@
cc_binary {
name: "android.hidl.allocator@1.0-service",
relative_install_path: "hw",
+ cflags: libhidl_flags,
srcs: [
"AshmemAllocator.cpp",
"service.cpp"
diff --git a/transport/memory/1.0/default/Android.bp b/transport/memory/1.0/default/Android.bp
index e3a05c3..3b1b7da 100644
--- a/transport/memory/1.0/default/Android.bp
+++ b/transport/memory/1.0/default/Android.bp
@@ -16,6 +16,7 @@
name: "android.hidl.memory@1.0-impl",
compile_multilib: "both",
relative_install_path: "hw",
+ cflags: libhidl_flags,
srcs: [
"AshmemMapper.cpp",
"AshmemMemory.cpp",
diff --git a/transport/memory/1.0/default/AshmemMemory.cpp b/transport/memory/1.0/default/AshmemMemory.cpp
index b954bad..912b724 100644
--- a/transport/memory/1.0/default/AshmemMemory.cpp
+++ b/transport/memory/1.0/default/AshmemMemory.cpp
@@ -41,7 +41,7 @@
return Void();
}
-Return<void> AshmemMemory::updateRange(uint64_t start, uint64_t length) {
+Return<void> AshmemMemory::updateRange(uint64_t /* start */, uint64_t /* length */) {
// NOOP (since non-remoted memory)
return Void();
}