commit 1cfaee704c2d20d6d8d7dedf77bd73f61ee905f7
author Steven Moreland <smoreland@google.com> Thu Dec 01 08:34:19 2016 -0800
committer Steven Moreland <smoreland@google.com> Thu Dec 08 00:21:58 2016 +0000
tree 0b974cc94beb77edf0519e6a36c274d95e1d17cc
parent b10ed9be0862fb822b470ba55aa499e585c5bf59

Remove explicit cast from Return<*>.

- also moving failure check to implicit cast operator.

(after talking to malchev@)

Bug: 31348667
Test: pass
Change-Id: I5a136a3596c2fa7c502ce9d53ab754b796d66fed

transport/include/hidl/HidlBinderSupport.h

diff --git a/transport/include/hidl/HidlBinderSupport.h b/transport/include/hidl/HidlBinderSupport.h
index fb209c4..1851870 100644
--- a/transport/include/hidl/HidlBinderSupport.h
+++ b/transport/include/hidl/HidlBinderSupport.h
@@ -372,7 +372,7 @@
                 [&success, &sm, &serviceName, &binderIface](const auto &chain) {         \
                     ::android::hardware::Return<bool> addRet =                           \
                             sm->add(chain, serviceName.c_str(), binderIface);            \
-                    success = addRet.isOk() && addRet.get();                             \
+                    success = addRet.isOk() && addRet;                                   \
                 });                                                                      \
         success = success && ret.getStatus().isOk();                                     \
         return success ? ::android::OK : ::android::UNKNOWN_ERROR;                       \
@@ -393,7 +393,7 @@
                 sm->registerForNotifications(PACKAGE "::I" #INTERFACE,                   \
                                              serviceName,                                \
                                              notification);                              \
-        return success.isOk() && success.get();                                          \
+        return success.isOk() && success;                                                \
     }