commit f5d22ef7cd31cc7120e9b724b040a06cd36ab870
author Steven Moreland <smoreland@google.com> Mon Apr 03 23:29:22 2023 +0000
committer Steven Moreland <smoreland@google.com> Mon Apr 17 20:18:00 2023 +0000
tree 74f6f9cdfe7e761d993d24c11e8cbf93774c4bb8
parent b2fdbef489921ef483babd9b43c5aaf7ee3ef515

init: log when 'user' is unspecified

NOTE: in master, but should be submitted in AOSP.
Waiting to hear from security folks. Also might
need cleanup.

Not currently done. Seems errorprone.

Bug: 276813155
Test: boot, check logs
Change-Id: I7cbc39b282889dd582f06a8eedc38ae637c8edec

init/service_utils.cpp

diff --git a/init/service_utils.cpp b/init/service_utils.cpp
index 7004d8d..0e19bcc 100644
--- a/init/service_utils.cpp
+++ b/init/service_utils.cpp
@@ -271,8 +271,8 @@
     if (setgroups(attr.supp_gids.size(), const_cast<gid_t*>(&attr.supp_gids[0])) != 0) {
         return ErrnoError() << "setgroups failed";
     }
-    if (attr.uid) {
-        if (setuid(attr.uid) != 0) {
+    if (attr.uid()) {
+        if (setuid(attr.uid()) != 0) {
             return ErrnoError() << "setuid failed";
         }
     }