commit d5b10fc9d6cf4ace3d185d60467c74cd28dd21a2
author Christopher Ferris <cferris@google.com> Mon Jan 13 17:20:14 2025 -0800
committer Christopher Ferris <cferris@google.com> Mon Jan 13 18:35:38 2025 -0800
tree 3f130fa0dce22416903256a5ce7e734893047017
parent 0cd212cb95ecf293122e39cdbb435e688bc306c9

Skip guest register getting on arm32.

Currently, there is no support for a guest architecture when running
in an arm 32 bit process. So always return false in that case instead
of spamming the log with useless messages.

Bug: 384944467

Test: debuggerd tests pass with no extraneous error messages.
Change-Id: I8152f1e76031e8b765c4c594b0bbc6800ab60c9e

debuggerd/crash_dump.cpp

diff --git a/debuggerd/crash_dump.cpp b/debuggerd/crash_dump.cpp
index 7d3830c..92d81b3 100644
--- a/debuggerd/crash_dump.cpp
+++ b/debuggerd/crash_dump.cpp
@@ -451,10 +451,8 @@
     return false;
   }
 #elif defined(__arm__)
-  if (ptrace(PTRACE_GET_THREAD_AREA, tid, nullptr, &base) == 0) {
-    PLOG(ERROR) << "failed to get thread area for thread " << tid;
-    return false;
-  }
+  // Arm doesn't support any guest architectures yet.
+  return false;
 #elif defined(__i386__)
   struct user_regs_struct regs;
   struct iovec pt_iov = {.iov_base = &regs, .iov_len = sizeof(regs)};