commit d162f14d6cd4b8f1e230164972e5d7d82e3508cf
author Tom Cherry <tomcherry@google.com> Thu Oct 24 17:35:26 2019 -0700
committer Tom Cherry <tomcherry@google.com> Fri Oct 25 15:00:16 2019 -0700
tree 6a2b39dd90364970c24f8e3e3339de54ea4a48fd
parent c8ef01344d7272f4bf24c1c31099e29b2676d214

logcat: remove the rest of liblogcat

There were big changes made to support liblogcat, which has long since
been removed.  This change removes the rest of those changes.

It moves the rest of the global state into a class, particularly for
the logcatd case.  The original code re-uses the same context, but
that doesn't seem right or safe.

Test: logcat works, logcat-unit-tests
Test: logpersist works, including last log cat and log rotation
Change-Id: Iee6a2a0319265e87be0bc8fec2b11e8fd2b65ed4

logcat/Android.bp

diff --git a/logcat/Android.bp b/logcat/Android.bp
index e6b0c7d..e472d08 100644
--- a/logcat/Android.bp
+++ b/logcat/Android.bp
@@ -21,6 +21,7 @@
         "-Wall",
         "-Wextra",
         "-Werror",
+        "-DANDROID_BASE_UNIQUE_FD_DISABLE_IMPLICIT_CONVERSION=1",
     ],
     shared_libs: [
         "libbase",