commit d086fe51092b6302cf2fc5a460e63393726468e5
author Steven Moreland <smoreland@google.com> Tue Jul 26 22:11:13 2022 +0000
committer Steven Moreland <smoreland@google.com> Tue Jul 26 22:11:13 2022 +0000
tree 975b67a384f3c4c726761c205a0ef85d2dabd6cc
parent c340a08b1b2d439f482144d03df1a781c26cb0e5

libutils: disallow extending lifetime on stack

Bug: 232557259
Test: libutils_test
Change-Id: Iacf45b9f295a48904606ced35994ba35566bfcc3

libutils/RefBase.cpp

diff --git a/libutils/RefBase.cpp b/libutils/RefBase.cpp
index 79c5743..12c2c29 100644
--- a/libutils/RefBase.cpp
+++ b/libutils/RefBase.cpp
@@ -791,6 +791,8 @@
 
 void RefBase::extendObjectLifetime(int32_t mode)
 {
+    check_not_on_stack(this);
+
     // Must be happens-before ordered with respect to construction or any
     // operation that could destroy the object.
     mRefs->mFlags.fetch_or(mode, std::memory_order_relaxed);