commit bb0a7642d63b95a0f7db23f38d7f1c957930ec08
author Kelvin Zhang <zhangkelvin@google.com> Wed Sep 01 14:21:47 2021 -0700
committer Daniel Rosenberg <drosen@google.com> Thu Sep 02 14:12:19 2021 -0700
tree b6c7bc268d39b9dd23fde1f5a475f8d989f3e1f1
parent 7b0ae4ba7dd62511b32f8044574b39c8d931623f

Fix a typo

this check should be performed on newly returned `op` instead of
`cow_op`

Test: th
Change-Id: Ia0812a1126d3e0bdfaff82859eb4b4a066a73bff

fs_mgr/libsnapshot/snapuserd/snapuserd_readahead.cpp

diff --git a/fs_mgr/libsnapshot/snapuserd/snapuserd_readahead.cpp b/fs_mgr/libsnapshot/snapuserd/snapuserd_readahead.cpp
index b868eed..ac3c222 100644
--- a/fs_mgr/libsnapshot/snapuserd/snapuserd_readahead.cpp
+++ b/fs_mgr/libsnapshot/snapuserd/snapuserd_readahead.cpp
@@ -194,10 +194,12 @@
                                        std::vector<uint64_t>& blocks) {
     int num_ops = *pending_ops;
     int nr_consecutive = 0;
+    CHECK_NE(source_offset, nullptr);
 
     if (!RAIterDone() && num_ops) {
         // Get the first block with offset
         const CowOperation* cow_op = GetRAOpIter();
+        CHECK_NE(cow_op, nullptr);
         *source_offset = cow_op->source;
         if (cow_op->type == kCowCopyOp) {
             *source_offset *= BLOCK_SZ;
@@ -216,8 +218,9 @@
          */
         while (!RAIterDone() && num_ops) {
             const CowOperation* op = GetRAOpIter();
+            CHECK_NE(op, nullptr);
             uint64_t next_offset = op->source;
-            if (cow_op->type == kCowCopyOp) {
+            if (op->type == kCowCopyOp) {
                 next_offset *= BLOCK_SZ;
             }
             if (next_offset != (*source_offset - nr_consecutive * BLOCK_SZ)) {