commit b650aef2a031fbb6cc2a7bef832fa60eb355f9a1
author Daniel Colascione <dancol@google.com> Thu Feb 08 15:06:43 2018 -0800
committer Daniel Colascione <dancol@google.com> Thu Feb 08 15:07:47 2018 -0800
tree 25b4166dff5d60404d41e3b5db67af25e27ce7b4
parent 2ccde89153321d2c98787d6320ac15602494a78d

Add explanation for clone use

Test: no code changes
Change-Id: I70c8af8261cda3163677557fd78ae0119b1f1be0

libmemunreachable/PtracerThread.cpp

diff --git a/libmemunreachable/PtracerThread.cpp b/libmemunreachable/PtracerThread.cpp
index aca2a82..61a1d24 100644
--- a/libmemunreachable/PtracerThread.cpp
+++ b/libmemunreachable/PtracerThread.cpp
@@ -98,6 +98,7 @@
     return (*reinterpret_cast<std::function<int()>*>(arg))();
   };
 
+  // See README.md for why we create the child process this way
   child_pid_ = clone(proxy, stack_->top(), CLONE_VM | CLONE_FS | CLONE_FILES /*|CLONE_UNTRACED*/,
                      reinterpret_cast<void*>(&func_));
   if (child_pid_ < 0) {