commit b6071f19c318fd19ed37d9fa4ba0cf77d7d32d13
author T.J. Mercier <tjmercier@google.com> Wed Aug 07 16:35:55 2024 +0000
committer T.J. Mercier <tjmercier@google.com> Thu Nov 14 22:56:11 2024 +0000
tree 2154074237d43f81a079a99121a3b86e83535569
parent 9e5f74d4e466b00777667b147ca8eac77ea26805

libprocessgroup: Convert CGROUPV2_HIERARCHY_NAME to std::string

Almost everywhere CGROUPV2_HIERARCHY_NAME is used a std::string is
required, so change its type to avoid temporaries.

Change-Id: I4466838c510f2eb8212fc71999cdaa47359ce9c3

libprocessgroup/include/processgroup/processgroup.h

diff --git a/libprocessgroup/include/processgroup/processgroup.h b/libprocessgroup/include/processgroup/processgroup.h
index 02f7c25..d27b568 100644
--- a/libprocessgroup/include/processgroup/processgroup.h
+++ b/libprocessgroup/include/processgroup/processgroup.h
@@ -26,7 +26,7 @@
 
 __BEGIN_DECLS
 
-static constexpr const char* CGROUPV2_HIERARCHY_NAME = "cgroup2";
+static constexpr std::string CGROUPV2_HIERARCHY_NAME = "cgroup2";
 
 bool CgroupsAvailable();
 bool CgroupGetControllerPath(const std::string& cgroup_name, std::string* path);

libprocessgroup/setup/cgroup_map_write.cpp

diff --git a/libprocessgroup/setup/cgroup_map_write.cpp b/libprocessgroup/setup/cgroup_map_write.cpp
index d05bf24..c4e1fb6 100644
--- a/libprocessgroup/setup/cgroup_map_write.cpp
+++ b/libprocessgroup/setup/cgroup_map_write.cpp
@@ -222,7 +222,7 @@
     const CgroupController* controller = descriptor.controller();
 
     if (controller->version() == 2) {
-        if (!strcmp(controller->name(), CGROUPV2_HIERARCHY_NAME)) {
+        if (controller->name() == CGROUPV2_HIERARCHY_NAME) {
             return MountV2CgroupController(descriptor);
         } else {
             return ActivateV2CgroupController(descriptor);