commit aee2ec8f1eda337479502cfce8b601b9bea347d9
author Bart Van Assche <bvanassche@google.com> Fri Dec 02 18:48:15 2022 -0800
committer Bart Van Assche <bvanassche@google.com> Mon Dec 05 09:40:06 2022 -0800
tree 66a7f42db62577dcec4acc1fb8277c423af84da8
parent 91ba2197ef75134c8784e7e8ebfaf3dafad17e26

init: Enable ANDROID_BASE_UNIQUE_FD_DISABLE_IMPLICIT_CONVERSION

From the unique_fd.h header file: "unique_fd's operator int is
dangerous, but we have way too much code that depends on it, so make
this opt-in at first."

From the Google C++ style guide: "Do not define implicit conversions."
See also go/cstyle#Implicit_Conversions.

Hence this CL that disables unique_fd::operator int().

Change-Id: I28d94755d5408f63e5819da8d1cbc285057f867f
Signed-off-by: Bart Van Assche <bvanassche@google.com>

init/Android.bp

diff --git a/init/Android.bp b/init/Android.bp
index 50c85e6..c7e7de8 100644
--- a/init/Android.bp
+++ b/init/Android.bp
@@ -112,6 +112,7 @@
         "-DALLOW_FIRST_STAGE_CONSOLE=0",
         "-DALLOW_LOCAL_PROP_OVERRIDE=0",
         "-DALLOW_PERMISSIVE_SELINUX=0",
+        "-DANDROID_BASE_UNIQUE_FD_DISABLE_IMPLICIT_CONVERSION",
         "-DDUMP_ON_UMOUNT_FAILURE=0",
         "-DINIT_FULL_SOURCES",
         "-DINSTALL_DEBUG_POLICY_TO_SYSTEM_EXT=0",