commit a7b4c5d25aebc2c7e6156473dae98238c029e630
author Peter Collingbourne <pcc@google.com> Mon Mar 30 18:38:21 2020 -0700
committer Peter Collingbourne <pcc@google.com> Tue Mar 31 10:29:38 2020 -0700
tree f1dca1c3fb6d44fb35ab02fe5970cd1986e57bd3
parent fd193bd2913aa0e9120ea65d8952ce6536c7dcf8

Fix off-by-one in ReadBuildIDFromMemory.

This was sometimes causing build ids to be truncated, probably because
of memory corruption in std::string. A similar off-by-one was fixed in
ReadBuildID in aosp/939619.

Bug: 129873279
Change-Id: I401fe7f991dbd135f5b4836381b48ea3c6a2243f

libunwindstack/ElfInterface.cpp

diff --git a/libunwindstack/ElfInterface.cpp b/libunwindstack/ElfInterface.cpp
index 341275d..821e042 100644
--- a/libunwindstack/ElfInterface.cpp
+++ b/libunwindstack/ElfInterface.cpp
@@ -662,7 +662,7 @@
         if (note_size - offset < hdr.n_descsz || hdr.n_descsz == 0) {
           return "";
         }
-        std::string build_id(hdr.n_descsz - 1, '\0');
+        std::string build_id(hdr.n_descsz, '\0');
         if (memory->ReadFully(note_offset + offset, &build_id[0], hdr.n_descsz)) {
           return build_id;
         }