commit a32ce535f9e99ca24de11d0fa14cdefe1d617e00
author Chih-Hung Hsieh <chh@google.com> Thu Jul 28 16:38:15 2016 -0700
committer Chih-Hung Hsieh <chh@google.com> Thu Jul 28 16:38:15 2016 -0700
tree 1540066ee5bf930281c08c4fd07ce311d1486b05
parent 1b218d6cb96727b180a65c7340a49136daaea72c

Fix clang-tidy performance warnings in syste/core.

* Use const reference type for parameters to avoid unnecessary copy.
* Suppress warning of not using faster overloaded string find function.

Bug: 30407689
Bug: 30411878
Change-Id: Ie79dbe21899867bc62031f8618bb1322b8071525
Test: build with WITH_TIDY=1

init/util.cpp

diff --git a/init/util.cpp b/init/util.cpp
index 80b2325..c1750d2 100644
--- a/init/util.cpp
+++ b/init/util.cpp
@@ -317,7 +317,7 @@
 }
 
 void import_kernel_cmdline(bool in_qemu,
-                           std::function<void(const std::string&, const std::string&, bool)> fn) {
+                           const std::function<void(const std::string&, const std::string&, bool)>& fn) {
     std::string cmdline;
     android::base::ReadFileToString("/proc/cmdline", &cmdline);