commit 935ee1f9718438763a075398897c8ee7c1905bf8
author Daniel Zheng <zhengdaniel@google.com> Thu Apr 13 11:03:34 2023 -0700
committer Daniel Zheng <zhengdaniel@google.com> Thu Apr 20 14:11:06 2023 -0700
tree 20e313f60b0548fec3704b71bb2472c128a57758
parent 13af2f46a8f689f0295580d47de8c189a32ca9b1

Added test for parsing bad input

Test: fastboot_test
Change-Id: I04fc24741987bc88a490b2084189dfd8f3714582

fastboot/task_test.cpp

diff --git a/fastboot/task_test.cpp b/fastboot/task_test.cpp
index 52d1fc3..145b4d7 100644
--- a/fastboot/task_test.cpp
+++ b/fastboot/task_test.cpp
@@ -53,6 +53,11 @@
     return tasks;
 }
 
+std::unique_ptr<Task> ParseCommand(FlashingPlan* fp, std::string command) {
+    std::vector<std::string> vec_command = android::base::Split(command, " ");
+    return ParseFastbootInfoLine(fp, vec_command);
+}
+
 TEST_F(ParseTest, CORRECT_FlASH_TASK_FORMED) {
     std::vector<std::string> commands = {"flash dtbo", "flash --slot-other system system_other.img",
                                          "flash system", "flash --apply-vbmeta vbmeta"};
@@ -97,4 +102,22 @@
     for (auto& version : bad_versions) {
         ASSERT_FALSE(CheckFastbootInfoRequirements(android::base::Split(version, " "))) << version;
     }
-}
\ No newline at end of file
+}
+
+TEST_F(ParseTest, BAD_FASTBOOT_INFO_INPUT) {
+    ASSERT_EQ(ParseCommand(fp.get(), "flash"), nullptr);
+    ASSERT_EQ(ParseCommand(fp.get(), "flash --slot-other --apply-vbmeta"), nullptr);
+    ASSERT_EQ(ParseCommand(fp.get(), "flash --apply-vbmeta"), nullptr);
+    ASSERT_EQ(ParseCommand(fp.get(), "if-wipe"), nullptr);
+    ASSERT_EQ(ParseCommand(fp.get(), "if-wipe flash"), nullptr);
+    ASSERT_EQ(ParseCommand(fp.get(), "wipe dtbo"), nullptr);
+    ASSERT_EQ(ParseCommand(fp.get(), "update-super dtbo"), nullptr);
+    ASSERT_EQ(ParseCommand(fp.get(), "flash system system.img system"), nullptr);
+    ASSERT_EQ(ParseCommand(fp.get(), "reboot bootloader fastboot"), nullptr);
+    ASSERT_EQ(ParseCommand(fp.get(),
+                           "flash --slot-other --apply-vbmeta system system_other.img system"),
+              nullptr);
+    ASSERT_EQ(ParseCommand(fp.get(), "erase"), nullptr);
+    ASSERT_EQ(ParseCommand(fp.get(), "erase dtbo dtbo"), nullptr);
+    ASSERT_EQ(ParseCommand(fp.get(), "wipe this"), nullptr);
+}