commit 8b5c8477f915e8680257657042e64181104b9bda
author Tomasz Wasilczyk <twasilczyk@google.com> Mon Aug 14 18:20:02 2023 +0000
committer Tomasz Wasilczyk <twasilczyk@google.com> Thu Sep 14 15:04:00 2023 +0000
tree 4ddc84114c0651e5419e2da72036f9f7acb64ad4
parent 51e3b9cbca982d4917954e04755252b98937523b

Lock down String8.isEmpty() usage

All users should migrate to .empty()

Bug: 295394788
Test: make checkbuild
Change-Id: I5ec7921b9cf70e6b0857e1087f141dce958d2587

libutils/include/utils/String8.h

diff --git a/libutils/include/utils/String8.h b/libutils/include/utils/String8.h
index ea25c6a..c798762 100644
--- a/libutils/include/utils/String8.h
+++ b/libutils/include/utils/String8.h
@@ -65,7 +65,6 @@
     inline  size_t              size() const;
     inline  size_t              bytes() const;
     inline  bool                empty() const;
-    inline  bool                isEmpty() const;
 
             size_t              length() const;
 
@@ -206,6 +205,14 @@
             char*               find_extension(void) const;
 
             const char* mString;
+
+// These symbols are for potential backward compatibility with prebuilts. To be removed.
+#ifdef ENABLE_STRING8_OBSOLETE_METHODS
+public:
+#else
+private:
+#endif
+    inline  bool                isEmpty() const;
 };
 
 // String8 can be trivially moved using memcpy() because moving does not