commit 74b8449f582a9fedba1d677f9be5b41a8d4ba304
author Greg Kaiser <gkaiser@google.com> Mon Oct 26 06:29:14 2020 -0700
committer Greg Kaiser <gkaiser@google.com> Mon Oct 26 06:37:32 2020 -0700
tree 90b9cfefce4f4fc26edfdd62954e8401134ace5b
parent 346e6792b45cafc8d3b8dcf993584b98743a4688

Fix lseek() check

Since 'pos' is unsigned, we need to tweak the check.

Test: TreeHugger
Change-Id: I97dcb50fb86196b09b11ba725593e6c83c5586d9

fs_mgr/libsnapshot/cow_reader.cpp

diff --git a/fs_mgr/libsnapshot/cow_reader.cpp b/fs_mgr/libsnapshot/cow_reader.cpp
index b1667e3..5fac0ac 100644
--- a/fs_mgr/libsnapshot/cow_reader.cpp
+++ b/fs_mgr/libsnapshot/cow_reader.cpp
@@ -135,7 +135,7 @@
         }
         auto& current_op = ops_buffer->data()[current_op_num];
         pos = lseek(fd_.get(), GetNextOpOffset(current_op), SEEK_CUR);
-        if (pos < 0) {
+        if (pos == uint64_t(-1)) {
             PLOG(ERROR) << "lseek next op failed";
             return false;
         }