commit 5f01d3af77d420c0bd0688e86ceb9c7772c1c76a
author Wei Wang <wvw@google.com> Thu May 23 12:13:29 2019 -0700
committer Wei Wang <wvw@google.com> Thu May 23 12:43:09 2019 -0700
tree 08921f798ec7950828b8068e29f8a86d8e092fc3
parent cbe0876f8b1d12dfd662bbf6c59eb1eba25ac2cb

init: add error handling in control message

Bug: 133432022
Test: boot
Test: setprop ctl.interface_restart android.hardware.power@1.0::IPower/default success
Test: setprop ctl.interface_restart android.hardware.power@1.0::IPower/abc fail
Change-Id: I66342b2723eb01022fb4e0d98f0b6ffc2752bcac

init/property_service.cpp

diff --git a/init/property_service.cpp b/init/property_service.cpp
index 14e83f2..ab5dd61 100644
--- a/init/property_service.cpp
+++ b/init/property_service.cpp
@@ -473,8 +473,9 @@
     }
 
     if (StartsWith(name, "ctl.")) {
-        HandleControlMessage(name.c_str() + 4, value, cr.pid);
-        return PROP_SUCCESS;
+        return HandleControlMessage(name.c_str() + 4, value, cr.pid)
+                       ? PROP_SUCCESS
+                       : PROP_ERROR_HANDLE_CONTROL_MESSAGE;
     }
 
     // sys.powerctl is a special property that is used to make the device reboot.  We want to log