commit 507209ba55ba431806f7a60ec28fad4fc866c903
author Steven Moreland <smoreland@google.com> Wed Dec 07 20:55:35 2022 +0000
committer Steven Moreland <smoreland@google.com> Tue Dec 13 22:43:58 2022 +0000
tree 10ca5f5821ea4c74d5fec8a49b4995d7897a4888
parent e0af2b83f3f14dfbdf26736145904a647c8066cc

ignore error -> log

Current code ignores an error, which is a code
rot risk.

Bug: 261700511
Change-Id: I04ca7046dc42d761ecaaf56f6100c96cc8298ec5
Test: N/A

init/service.cpp

diff --git a/init/service.cpp b/init/service.cpp
index 2ce81a0..4e2226b 100644
--- a/init/service.cpp
+++ b/init/service.cpp
@@ -868,6 +868,8 @@
 
     if ((how != SVC_DISABLED) && (how != SVC_RESET) && (how != SVC_RESTART)) {
         // An illegal flag: default to SVC_DISABLED.
+        LOG(ERROR) << "service '" << name_ << "' requested unknown flag " << how
+                   << ", defaulting to disabling it.";
         how = SVC_DISABLED;
     }