commit 43987c948bf0b698fa24abc7377227efaa47cf4e
author Daniel Zheng <zhengdaniel@google.com> Tue Mar 07 18:20:53 2023 +0000
committer Daniel Zheng <zhengdaniel@google.com> Wed Mar 08 23:07:51 2023 +0000
tree 7aadfd9281cd8780e5a99ae9f93cb6e79ed3634d
parent aa70f4c74859f1dc47b8ebd800e4a0485421e83b

Fixed parameter styling and minor error in tasks

Test: tested compilation
Change-Id: Ieb949243da1284dec3bad2caa895a59465858adc

fastboot/task.cpp

diff --git a/fastboot/task.cpp b/fastboot/task.cpp
index e55cda5..6233c90 100644
--- a/fastboot/task.cpp
+++ b/fastboot/task.cpp
@@ -21,8 +21,8 @@
 
 using namespace std::string_literals;
 
-FlashTask::FlashTask(const std::string& _slot, const std::string& _pname)
-    : pname_(_pname), fname_(find_item(_pname)), slot_(_slot) {
+FlashTask::FlashTask(const std::string& slot, const std::string& pname)
+    : pname_(pname), fname_(find_item(pname)), slot_(slot) {
     if (fname_.empty()) die("cannot determine image filename for '%s'", pname_.c_str());
 }
 FlashTask::FlashTask(const std::string& _slot, const std::string& _pname, const std::string& _fname)
@@ -44,9 +44,9 @@
     do_for_partitions(pname_, slot_, flash, true);
 }
 
-RebootTask::RebootTask(FlashingPlan* _fp) : fp_(_fp){};
-RebootTask::RebootTask(FlashingPlan* _fp, const std::string& _reboot_target)
-    : reboot_target_(_reboot_target), fp_(_fp){};
+RebootTask::RebootTask(FlashingPlan* fp) : fp_(fp){};
+RebootTask::RebootTask(FlashingPlan* fp, const std::string& reboot_target)
+    : reboot_target_(reboot_target), fp_(fp){};
 
 void RebootTask::Run() {
     if ((reboot_target_ == "userspace" || reboot_target_ == "fastboot")) {