commit 4092a77774b0cefbedd8ed87145145903b053dba
author Rajesh Nyamagoud <nyamagoud@google.com> Mon Oct 24 19:25:35 2022 +0000
committer Rajesh Nyamagoud <nyamagoud@google.com> Mon Oct 24 19:25:35 2022 +0000
tree 0e62362317e50ad046cc91043d6f88c0c92656c5
parent 882c1681df8b0fb163e1901bb2076645046e9147

Replaced `-1` with `EXIT_FAILURE` and validated confirmationui service
status after registering it with `CHECK_EQ` macro.

Bug: b/205760172
Test: atest VtsHalConfirmationUITargetTest
Change-Id: I00f5a09ca525e3abb63a5d1f404fb6f3daed9442

trusty/confirmationui/service.cpp

diff --git a/trusty/confirmationui/service.cpp b/trusty/confirmationui/service.cpp
index b286c0a..44fa3a6 100644
--- a/trusty/confirmationui/service.cpp
+++ b/trusty/confirmationui/service.cpp
@@ -31,12 +31,8 @@
     const auto instance = std::string(IConfirmationUI::descriptor) + "/default";
     binder_status_t status =
         AServiceManager_addService(confirmationui->asBinder().get(), instance.c_str());
-
-    if (status != STATUS_OK) {
-        LOG(FATAL) << "Could not register service for " << instance.c_str() << "(" << status << ")";
-        return -1;
-    }
+    CHECK_EQ(status, STATUS_OK) << "Could not register " << instance;
 
     ABinderProcess_joinThreadPool();
-    return -1;
+    return EXIT_FAILURE;
 }