commit 36dadca9f0f0c007efb1d8b9d0c9d32cb9abe637
author Josh Gao <jmgao@google.com> Tue May 16 15:02:45 2017 -0700
committer Josh Gao <jmgao@google.com> Thu May 18 13:40:13 2017 -0700
tree db7f53a337df8a8830d5a4bdff159a2542a752a8
parent 16c5a133ab2b80af2b56f86e42de04a4399c60fc

adb: boolify check_header and check_data.

Test: grep
Change-Id: I8d0c60e500bba855a1afc0877253262246c07fef

adb/transport.cpp

diff --git a/adb/transport.cpp b/adb/transport.cpp
index 13cfaa1..24e90cf 100644
--- a/adb/transport.cpp
+++ b/adb/transport.cpp
@@ -1050,27 +1050,24 @@
         [usb](atransport* t) { return t->usb == usb && t->GetConnectionState() == kCsNoPerm; });
 }
 
-int check_header(apacket* p, atransport* t) {
+bool check_header(apacket* p, atransport* t) {
     if (p->msg.magic != (p->msg.command ^ 0xffffffff)) {
         VLOG(RWX) << "check_header(): invalid magic command = " << std::hex << p->msg.command
                   << ", magic = " << p->msg.magic;
-        return -1;
+        return false;
     }
 
     if (p->msg.data_length > t->get_max_payload()) {
         VLOG(RWX) << "check_header(): " << p->msg.data_length
                   << " atransport::max_payload = " << t->get_max_payload();
-        return -1;
+        return false;
     }
 
-    return 0;
+    return true;
 }
 
-int check_data(apacket* p) {
-    if (calculate_apacket_checksum(p) != p->msg.data_check) {
-        return -1;
-    }
-    return 0;
+bool check_data(apacket* p) {
+    return calculate_apacket_checksum(p) == p->msg.data_check;
 }
 
 #if ADB_HOST