commit 2cbbe9f7a35efdc94e8e34ef92eb6f70a85887fe
author Tom Cherry <tomcherry@google.com> Thu May 04 18:17:33 2017 -0700
committer Tom Cherry <tomcherry@google.com> Fri May 05 14:37:12 2017 -0700
tree 215ecac00aa47fbac652e5e7bc99761176884b84
parent 517e1f17cfec2143d4d10a64b1496a550acf3ea2

init: do not log directly from read_file() and write_file()

Their callers may be able to add more context, so use an error string
to record the error.

Bug: 38038887
Test: boot bullhead
Test: Init unit tests
Change-Id: I46690d1c66e00a4b15cadc6fd0d6b50e990388c3

init/init.cpp

diff --git a/init/init.cpp b/init/init.cpp
index 52f6b0c..b5f97e5 100644
--- a/init/init.cpp
+++ b/init/init.cpp
@@ -853,7 +853,9 @@
             }
         }
 
-        if (!write_file("/sys/fs/selinux/checkreqprot", "0")) {
+        std::string err;
+        if (!WriteFile("/sys/fs/selinux/checkreqprot", "0", &err)) {
+            LOG(ERROR) << err;
             security_failure();
         }