Snap for 12580585 from af558ac5eba8f12fa27011abc958208a1274d646 to 25Q1-release
Change-Id: Ia3f33479b4d1752c0cea31047cff44a9f4847266
diff --git a/fs_mgr/fs_mgr.cpp b/fs_mgr/fs_mgr.cpp
index c956102..9f52f44 100644
--- a/fs_mgr/fs_mgr.cpp
+++ b/fs_mgr/fs_mgr.cpp
@@ -2215,11 +2215,11 @@
#if ALLOW_ADBD_DISABLE_VERITY == 0
// Allowlist the mount point if user build.
- static const std::vector<const std::string> kAllowedPaths = {
+ static const std::vector<std::string> kAllowedPaths = {
"/odm", "/odm_dlkm", "/oem", "/product",
"/system_dlkm", "/system_ext", "/vendor", "/vendor_dlkm",
};
- static const std::vector<const std::string> kAllowedPrefixes = {
+ static const std::vector<std::string> kAllowedPrefixes = {
"/mnt/product/",
"/mnt/vendor/",
};
diff --git a/mkbootfs/Android.bp b/mkbootfs/Android.bp
index cd2a624..e0191f0 100644
--- a/mkbootfs/Android.bp
+++ b/mkbootfs/Android.bp
@@ -6,7 +6,7 @@
cc_binary_host {
name: "mkbootfs",
- srcs: ["mkbootfs.c"],
+ srcs: ["mkbootfs.cpp"],
cflags: ["-Werror"],
static_libs: [
"libbase",
diff --git a/mkbootfs/mkbootfs.c b/mkbootfs/mkbootfs.cpp
similarity index 96%
rename from mkbootfs/mkbootfs.c
rename to mkbootfs/mkbootfs.cpp
index 84a0a4e..65cf497 100644
--- a/mkbootfs/mkbootfs.c
+++ b/mkbootfs/mkbootfs.cpp
@@ -75,7 +75,7 @@
}
}
-static void _eject(struct stat *s, char *out, int olen, char *data, unsigned datasize)
+static void _eject(struct stat *s, const char *out, int olen, char *data, unsigned datasize)
{
// Nothing is special about this value, just picked something in the
// approximate range that was being used already, and avoiding small
@@ -151,9 +151,10 @@
DIR* d = opendir(in);
if (d == NULL) err(1, "cannot open directory '%s'", in);
+ // TODO: switch to std::vector
int size = 32;
int entries = 0;
- char** names = malloc(size * sizeof(char*));
+ char** names = (char**) malloc(size * sizeof(char*));
if (names == NULL) {
errx(1, "failed to allocate dir names array (size %d)", size);
}
@@ -167,7 +168,7 @@
if (entries >= size) {
size *= 2;
- names = realloc(names, size * sizeof(char*));
+ names = (char**) realloc(names, size * sizeof(char*));
if (names == NULL) {
errx(1, "failed to reallocate dir names array (size %d)", size);
}
@@ -445,15 +446,12 @@
int num_dirs = argc - optind;
argv += optind;
- while(num_dirs-- > 0){
+ while (num_dirs-- > 0){
char *x = strchr(*argv, '=');
- if(x != 0) {
- *x++ = 0;
- } else {
- x = "";
+ if (x != nullptr) {
+ *x++ = '\0';
}
-
- archive(*argv, x);
+ archive(*argv, x ?: "");
argv++;
}
diff --git a/rootdir/init.rc b/rootdir/init.rc
index 12d9c43..5bb64cc 100644
--- a/rootdir/init.rc
+++ b/rootdir/init.rc
@@ -70,6 +70,9 @@
start ueventd
+ # Mount tracefs (with GID=AID_READTRACEFS)
+ mount tracefs tracefs /sys/kernel/tracing gid=3012
+
# Run apexd-bootstrap so that APEXes that provide critical libraries
# become available. Note that this is executed as exec_start to ensure that
# the libraries are available to the processes started after this statement.
@@ -80,9 +83,6 @@
mkdir /dev/boringssl 0755 root root
mkdir /dev/boringssl/selftest 0755 root root
- # Mount tracefs (with GID=AID_READTRACEFS)
- mount tracefs tracefs /sys/kernel/tracing gid=3012
-
# create sys dirctory
mkdir /dev/sys 0755 system system
mkdir /dev/sys/fs 0755 system system