commit 1f5fb430471beb1a6d458a6a31d7990a6158c199
author Andreas Gampe <agampe@google.com> Fri Sep 23 16:37:12 2016 -0700
committer Andreas Gampe <agampe@google.com> Sat Sep 24 10:18:38 2016 -0700
tree cf250badae8dfa8da2b06f1d272a4970ec9b72a1
parent 19a7696488b2f6b16b265973de0aff5d1156a21a

Base: Remove LOG_S variants.

Partially reverts commit 436f5a031f3dfa195919be36873300a221376b53.

Remove the variants taking a fully qualified LogSeverity. Instead
use a lambda with "using" statements to translate both qualified
and unqualified names into valid expressions.

Compile-time regression was measured as 0.1s for a thousand LOG
statements on a z840.

Update tests.

Bug: 31338270
Test: m
Test: mmma system/core/base && $ANDROID_HOST_OUT/nativetest64/libbase_test/libbase_test64
Change-Id: I36fdf30a9d535b19543307b85d1b3c19a97f20dd

base/logging.cpp

diff --git a/base/logging.cpp b/base/logging.cpp
index 2ca2246..eaed9ab 100644
--- a/base/logging.cpp
+++ b/base/logging.cpp
@@ -391,7 +391,7 @@
 
 LogMessage::~LogMessage() {
   // Check severity again. This is duplicate work wrt/ LOG macros, but not LOG_STREAM.
-  if (!WOULD_LOG_SEVERITY(data_->GetSeverity())) {
+  if (!WOULD_LOG(data_->GetSeverity())) {
     return;
   }