commit 1d25c20ada4da81b28ea0ab4689246500fbfd8c8
author Treehugger Robot <treehugger-gerrit@google.com> Wed Mar 15 21:32:07 2023 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Wed Mar 15 21:32:07 2023 +0000
tree 7b47f26cba04f339ed99a713a0c59c91c7a72d8c
parent 89d8fdf3ede330cde9a99639d6fcd52b6a318a12
parent 51e58aced4dabdac64510b20216e1eec0dff4fab

Merge "libprocessgroup: Add argument checks in KillProcessGroup()"

libprocessgroup/processgroup.cpp

diff --git a/libprocessgroup/processgroup.cpp b/libprocessgroup/processgroup.cpp
index 38f19ff..f7af08b 100644
--- a/libprocessgroup/processgroup.cpp
+++ b/libprocessgroup/processgroup.cpp
@@ -446,6 +446,14 @@
 
 static int KillProcessGroup(uid_t uid, int initialPid, int signal, int retries,
                             int* max_processes) {
+    if (uid < 0) {
+        LOG(ERROR) << __func__ << ": invalid UID " << uid;
+        return -1;
+    }
+    if (initialPid <= 0) {
+        LOG(ERROR) << __func__ << ": invalid PID " << initialPid;
+        return -1;
+    }
     std::string hierarchy_root_path;
     if (CgroupsAvailable()) {
         CgroupGetControllerPath(CGROUPV2_CONTROLLER_NAME, &hierarchy_root_path);