commit 6c7871b8dfc1ac4bfec84f1a483aee16f5acc91d
author Maciej Żenczykowski <maze@google.com> Thu Apr 23 12:46:00 2020 -0700
committer Maciej Żenczykowski <maze@google.com> Fri Apr 24 04:18:35 2020 +0000
tree 1c6c312b3ff9c2c1c5676568c90caee6e9b39776
parent 428843de55db4c91c64437e29cb0ec1c347b33b7

libbpf_android/Loader.cpp - fixes performance-inefficient-string-concatenation warning

Fixes:
  system/bpf/libbpf_android/Loader.cpp:562:73: warning: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation]
          string progPinLoc = string(BPF_FS_PATH) + "prog_" + fname + "_" + name;
                                                                          ^

Test: builds
Bug: 153035880
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: If56405273b4904e632a4b3a465b79eecae4c1446

libbpf_android/Loader.cpp

diff --git a/libbpf_android/Loader.cpp b/libbpf_android/Loader.cpp
index 7431fa2..f808dc6 100644
--- a/libbpf_android/Loader.cpp
+++ b/libbpf_android/Loader.cpp
@@ -559,7 +559,10 @@
         bool reuse = false;
         // Format of pin location is
         // /sys/fs/bpf/prog_<filename>_<mapname>
-        string progPinLoc = string(BPF_FS_PATH) + "prog_" + fname + "_" + name;
+        string progPinLoc = BPF_FS_PATH "prog_";
+        progPinLoc += fname;
+        progPinLoc += '_';
+        progPinLoc += name;
         if (access(progPinLoc.c_str(), F_OK) == 0) {
             fd = bpf_obj_get(progPinLoc.c_str());
             ALOGD("New bpf prog load reusing prog %s, ret: %d\n", progPinLoc.c_str(), fd);