Merge "otasp refactor"
diff --git a/AndroidManifest.xml b/AndroidManifest.xml
index 60a50e1..f1d293f 100644
--- a/AndroidManifest.xml
+++ b/AndroidManifest.xml
@@ -133,6 +133,7 @@
<uses-permission android:name="android.permission.DUMP" />
<uses-permission android:name="android.permission.REGISTER_CALL_PROVIDER" />
<uses-permission android:name="android.permission.REGISTER_SIM_SUBSCRIPTION" />
+ <uses-permission android:name="android.permission.BIND_IMS_SERVICE" />
<uses-permission android:name="android.permission.BIND_CARRIER_SERVICES" />
<!-- BIND_CARRIER_MESSAGING_SERVICE has been deprecated in favor of BIND_CARRIER_SERVICES. -->
<uses-permission android:name="android.permission.BIND_CARRIER_MESSAGING_SERVICE" />
@@ -326,18 +327,6 @@
</intent-filter>
</activity>
- <!-- Trampoline activity that handles the SIM_ACTIVATION_REQUEST intent. -->
- <activity android:name="com.android.services.telephony.activation.SimActivationActivity"
- android:permission="android.permission.PERFORM_SIM_ACTIVATION"
- android:label="@string/phoneIconLabel"
- android:theme="@android:style/Theme.NoDisplay"
- android:excludeFromRecents="true">
- <intent-filter>
- <action android:name="android.intent.action.SIM_ACTIVATION_REQUEST" />
- <category android:name="android.intent.category.DEFAULT" />
- </intent-filter>
- </activity>
-
<!-- "Mobile network settings" screen, used on both
non-voice-capable tablets and regular phone devices. -->
<activity android:name="MobileNetworkSettings"
diff --git a/res/values-mcc208-mnc09-fr/strings.xml b/res/values-mcc208-mnc09-fr/strings.xml
new file mode 100644
index 0000000..ac5ef59
--- /dev/null
+++ b/res/values-mcc208-mnc09-fr/strings.xml
@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="utf-8"?>
+
+<resources xmlns:android="http://schemas.android.com/apk/res/android" xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2">
+ <string name="enhanced_4g_lte_mode_summary">Utiliser la fonction Voix 4G (HD) lorsqu\'elle est disponible</string>
+ <string name="enhanced_4g_lte_mode_title">Activer Voix 4G (HD)</string>
+</resources>
diff --git a/res/values-mcc208-mnc10-fr/strings.xml b/res/values-mcc208-mnc10-fr/strings.xml
new file mode 100644
index 0000000..ac5ef59
--- /dev/null
+++ b/res/values-mcc208-mnc10-fr/strings.xml
@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="utf-8"?>
+
+<resources xmlns:android="http://schemas.android.com/apk/res/android" xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2">
+ <string name="enhanced_4g_lte_mode_summary">Utiliser la fonction Voix 4G (HD) lorsqu\'elle est disponible</string>
+ <string name="enhanced_4g_lte_mode_title">Activer Voix 4G (HD)</string>
+</resources>
diff --git a/res/values/strings.xml b/res/values/strings.xml
index 72a7fc7..f5db225 100644
--- a/res/values/strings.xml
+++ b/res/values/strings.xml
@@ -805,6 +805,8 @@
<string name="menu_edit">Edit contact</string>
<!-- FDN list screen: menu item label -->
<string name="menu_delete">Delete contact</string>
+ <!-- FDN list screen: menu item label -->
+ <string name="menu_dial">Dial contact</string>
<!-- FDN related strings -->
<!-- Label for PIN2 entry screen -->
@@ -997,8 +999,6 @@
<string name="incall_error_call_failed">Call failed.</string>
<!-- In-call screen: call failure message displayed in an error dialog -->
<string name="incall_error_cannot_add_call">Call cannot be added at this time.</string>
- <!-- In-call screen: status message displayed in a dialog when starting an MMI -->
- <string name="incall_status_dialed_mmi">Starting MMI sequence\u2026</string>
<!-- In-call screen: message displayed in an error dialog -->
<string name="incall_error_supp_service_unknown">Service not supported</string>
<!-- In-call screen: message displayed in an error dialog -->
diff --git a/src/com/android/phone/CarrierConfigLoader.java b/src/com/android/phone/CarrierConfigLoader.java
index 5a40322..47bb064 100644
--- a/src/com/android/phone/CarrierConfigLoader.java
+++ b/src/com/android/phone/CarrierConfigLoader.java
@@ -58,6 +58,7 @@
import com.android.internal.telephony.PhoneFactory;
import com.android.internal.telephony.TelephonyIntents;
import com.android.internal.util.FastXmlSerializer;
+import com.android.internal.util.IndentingPrintWriter;
import org.xmlpull.v1.XmlPullParser;
import org.xmlpull.v1.XmlPullParserException;
@@ -71,6 +72,9 @@
import java.io.FilenameFilter;
import java.io.IOException;
import java.io.PrintWriter;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
import java.util.List;
/**
@@ -712,9 +716,41 @@
}
pw.println("CarrierConfigLoader: " + this);
for (int i = 0; i < TelephonyManager.getDefault().getPhoneCount(); i++) {
- pw.println(" Phone Id=" + i);
- pw.println(" mConfigFromDefaultApp=" + mConfigFromDefaultApp[i]);
- pw.println(" mConfigFromCarrierApp=" + mConfigFromCarrierApp[i]);
+ pw.println("Phone Id = " + i);
+ // display default values in CarrierConfigManager
+ printConfig(CarrierConfigManager.getDefaultConfig(), pw,
+ "Default Values from CarrierConfigManager");
+ pw.println("");
+ // display ConfigFromDefaultApp
+ printConfig(mConfigFromDefaultApp[i], pw, "mConfigFromDefaultApp");
+ pw.println("");
+ // display ConfigFromCarrierApp
+ printConfig(mConfigFromCarrierApp[i], pw, "mConfigFromCarrierApp");
+ }
+ }
+
+ private void printConfig(PersistableBundle configApp, PrintWriter pw, String name) {
+ IndentingPrintWriter indentPW = new IndentingPrintWriter(pw, " ");
+ if (configApp == null) {
+ indentPW.increaseIndent();
+ indentPW.println(name + " : null ");
+ return;
+ }
+ indentPW.increaseIndent();
+ indentPW.println(name + " : ");
+ List<String> sortedKeys = new ArrayList<String>(configApp.keySet());
+ Collections.sort(sortedKeys);
+ indentPW.increaseIndent();
+ indentPW.increaseIndent();
+ for (String key : sortedKeys) {
+ if (configApp.get(key) != null && configApp.get(key) instanceof Object[]) {
+ indentPW.println(key + " = " +
+ Arrays.toString((Object[]) configApp.get(key)));
+ } else if (configApp.get(key) != null && configApp.get(key) instanceof int[]) {
+ indentPW.println(key + " = " + Arrays.toString((int[]) configApp.get(key)));
+ } else {
+ indentPW.println(key + " = " + configApp.get(key));
+ }
}
}
diff --git a/src/com/android/phone/MMIDialogActivity.java b/src/com/android/phone/MMIDialogActivity.java
index 10ec6a3..5ac6b85 100644
--- a/src/com/android/phone/MMIDialogActivity.java
+++ b/src/com/android/phone/MMIDialogActivity.java
@@ -63,9 +63,6 @@
}
};
mCM.registerForMmiComplete(mHandler, PhoneGlobals.MMI_COMPLETE, null);
- if (mCM.getState() == PhoneConstants.State.OFFHOOK) {
- Toast.makeText(this, R.string.incall_status_dialed_mmi, Toast.LENGTH_SHORT).show();
- }
showMMIDialog();
}
diff --git a/src/com/android/phone/PhoneGlobals.java b/src/com/android/phone/PhoneGlobals.java
index f45fb94..cec5a76 100644
--- a/src/com/android/phone/PhoneGlobals.java
+++ b/src/com/android/phone/PhoneGlobals.java
@@ -57,7 +57,6 @@
import com.android.internal.telephony.TelephonyIntents;
import com.android.phone.common.CallLogAsync;
import com.android.phone.settings.SettingsConstants;
-import com.android.services.telephony.activation.SimActivationManager;
import com.android.services.telephony.sip.SipUtil;
/**
@@ -129,7 +128,6 @@
CallerInfoCache callerInfoCache;
NotificationMgr notificationMgr;
public PhoneInterfaceManager phoneMgr;
- public SimActivationManager simActivationManager;
CarrierConfigLoader configLoader;
private CallGatewayManager callGatewayManager;
@@ -373,8 +371,6 @@
cdmaOtaScreenState = new OtaUtils.CdmaOtaScreenState();
cdmaOtaInCallScreenUiState = new OtaUtils.CdmaOtaInCallScreenUiState();
- simActivationManager = new SimActivationManager();
-
// XXX pre-load the SimProvider so that it's ready
resolver.getType(Uri.parse("content://icc/adn"));
diff --git a/src/com/android/phone/PhoneInterfaceManager.java b/src/com/android/phone/PhoneInterfaceManager.java
index 38e40d7..b1ad364 100644
--- a/src/com/android/phone/PhoneInterfaceManager.java
+++ b/src/com/android/phone/PhoneInterfaceManager.java
@@ -62,6 +62,8 @@
import android.util.Pair;
import android.util.Slog;
import com.android.ims.ImsManager;
+import com.android.ims.internal.IImsServiceController;
+import com.android.ims.internal.IImsServiceFeatureListener;
import com.android.internal.telephony.CallManager;
import com.android.internal.telephony.CellNetworkScanResult;
import com.android.internal.telephony.CommandException;
@@ -2353,6 +2355,19 @@
return mPhone.getPcscfAddress(apnType);
}
+ /**
+ * Returns the {@link IImsServiceController} that corresponds to the given slot Id and IMS
+ * feature or {@link null} if the service is not available. If an ImsServiceController is
+ * available, the {@link IImsServiceFeatureListener} callback is registered as a listener for
+ * feature updates.
+ */
+ public IImsServiceController getImsServiceControllerAndListen(int slotId, int feature,
+ IImsServiceFeatureListener callback) {
+ enforceModifyPermission();
+ return PhoneFactory.getImsResolver().getImsServiceControllerAndListen(slotId, feature,
+ callback);
+ }
+
public void setImsRegistrationState(boolean registered) {
enforceModifyPermission();
mPhone.setImsRegistrationState(registered);
diff --git a/src/com/android/phone/settings/fdn/FdnList.java b/src/com/android/phone/settings/fdn/FdnList.java
index 0174a82..61a8299 100644
--- a/src/com/android/phone/settings/fdn/FdnList.java
+++ b/src/com/android/phone/settings/fdn/FdnList.java
@@ -17,16 +17,26 @@
package com.android.phone.settings.fdn;
import android.app.ActionBar;
+import android.content.Context;
import android.content.Intent;
import android.content.res.Resources;
import android.net.Uri;
import android.os.Bundle;
+import android.os.PersistableBundle;
+import android.telecom.PhoneAccount;
+import android.telephony.CarrierConfigManager;
+import android.telephony.SubscriptionManager;
+import android.text.TextUtils;
+import android.view.Gravity;
import android.view.Menu;
import android.view.MenuItem;
import android.view.View;
import android.widget.ListView;
+import android.widget.PopupMenu;
+import android.widget.PopupMenu.OnMenuItemClickListener;
import com.android.phone.ADNList;
+import com.android.phone.PhoneGlobals;
import com.android.phone.R;
import com.android.phone.SubscriptionInfoHelper;
@@ -35,9 +45,44 @@
* that allows a user to specify a limited set of phone numbers that the SIM can dial.
*/
public class FdnList extends ADNList {
+ private class SelectionPopupMenu extends PopupMenu {
+ private OnMenuItemClickListener mMenuItemListener = new OnMenuItemClickListener() {
+
+ @Override
+ public boolean onMenuItemClick(MenuItem item) {
+ if (item.getItemId() == MENU_EDIT) {
+ editSelected(position);
+ } else if (item.getItemId() == MENU_DELETE) {
+ deleteSelected(position);
+ } else if (item.getItemId() == MENU_DIAL) {
+ dialSelected(position);
+ }
+ return true;
+ }
+ };
+
+ private final int position;
+
+ public SelectionPopupMenu(Context context, View anchor, int position) {
+ super(context, anchor, Gravity.RIGHT);
+ this.position = position;
+ }
+
+ public void showPopUp() {
+ getMenu().add(0, MENU_EDIT, 0, getString(R.string.menu_edit));
+ getMenu().add(0, MENU_DELETE, 0, getString(R.string.menu_delete));
+ if (mFdnDialDirectlySupported) {
+ getMenu().add(0, MENU_DIAL, 0, getString(R.string.menu_dial));
+ }
+ setOnMenuItemClickListener(mMenuItemListener);
+ show();
+ }
+ }
+
private static final int MENU_ADD = 1;
private static final int MENU_EDIT = 2;
private static final int MENU_DELETE = 3;
+ private static final int MENU_DIAL = 4;
private static final String INTENT_EXTRA_NAME = "name";
private static final String INTENT_EXTRA_NUMBER = "number";
@@ -47,6 +92,9 @@
private SubscriptionInfoHelper mSubscriptionInfoHelper;
+ private boolean mFdnDialDirectlySupported = false;
+ private SelectionPopupMenu mPopup;
+
@Override
public void onCreate(Bundle icicle) {
super.onCreate(icicle);
@@ -63,6 +111,20 @@
}
@Override
+ protected void onResume() {
+ super.onResume();
+ mFdnDialDirectlySupported = getFdnDialDirectlySupported();
+ }
+
+ @Override
+ protected void onStop() {
+ super.onStop();
+ if (mPopup != null) {
+ mPopup.dismiss();
+ }
+ }
+
+ @Override
protected Uri resolveIntent() {
Intent intent = getIntent();
intent.setData(getContentUri(mSubscriptionInfoHelper));
@@ -82,6 +144,7 @@
.setIcon(android.R.drawable.ic_menu_edit);
menu.add(0, MENU_DELETE, 0, r.getString(R.string.menu_delete))
.setIcon(android.R.drawable.ic_menu_delete);
+ menu.add(0, MENU_DIAL, 0, r.getString(R.string.menu_dial));
return true;
}
@@ -93,6 +156,7 @@
menu.findItem(MENU_ADD).setVisible(true);
menu.findItem(MENU_EDIT).setVisible(hasSelection);
menu.findItem(MENU_DELETE).setVisible(hasSelection);
+ menu.findItem(MENU_DIAL).setVisible(hasSelection && mFdnDialDirectlySupported);
return true;
}
@@ -119,6 +183,10 @@
case MENU_DELETE:
deleteSelected();
return true;
+
+ case MENU_DIAL:
+ dialSelected();
+ return true;
}
return super.onOptionsItemSelected(item);
@@ -126,8 +194,8 @@
@Override
public void onListItemClick(ListView l, View v, int position, long id) {
- // TODO: is this what we really want?
- editSelected(position);
+ mPopup = new SelectionPopupMenu(this, v, position);
+ mPopup.showPopUp();
}
private void addContact() {
@@ -162,7 +230,11 @@
}
private void deleteSelected() {
- if (mCursor.moveToPosition(getSelectedItemPosition())) {
+ deleteSelected(getSelectedItemPosition());
+ }
+
+ private void deleteSelected(int position) {
+ if (mCursor.moveToPosition(position)) {
String name = mCursor.getString(NAME_COLUMN);
String number = mCursor.getString(NUMBER_COLUMN);
@@ -173,6 +245,21 @@
}
}
+ private void dialSelected() {
+ dialSelected(getSelectedItemPosition());
+ }
+
+ private void dialSelected(int position) {
+ if (mCursor.moveToPosition(position)) {
+ String number = mCursor.getString(NUMBER_COLUMN);
+ if (!TextUtils.isEmpty(number)) {
+ Uri uri = Uri.fromParts(PhoneAccount.SCHEME_TEL, number, null);
+ final Intent intent = new Intent(Intent.ACTION_CALL_PRIVILEGED, uri);
+ startActivity(intent);
+ }
+ }
+ }
+
/**
* Returns the uri for updating the ICC FDN entry, taking into account the subscription id.
*/
@@ -182,4 +269,18 @@
: FDN_CONTENT_URI;
}
+ /*
+ * Get the config of whether dialing FDN number from FDN list directly is supported
+ * from carrier config manager.
+ *
+ * @return boolean value of the config
+ */
+ private boolean getFdnDialDirectlySupported() {
+ int subId = mSubscriptionInfoHelper.hasSubId()
+ ? mSubscriptionInfoHelper.getSubId()
+ : SubscriptionManager.getDefaultSubscriptionId();
+ PersistableBundle carrierConfig =
+ PhoneGlobals.getInstance().getCarrierConfigForSubId(subId);
+ return carrierConfig.getBoolean(CarrierConfigManager.KEY_SUPPORT_DIRECT_FDN_DIALING_BOOL);
+ }
}
diff --git a/src/com/android/services/telephony/TelephonyConnection.java b/src/com/android/services/telephony/TelephonyConnection.java
index 061a41e..ef2b414 100644
--- a/src/com/android/services/telephony/TelephonyConnection.java
+++ b/src/com/android/services/telephony/TelephonyConnection.java
@@ -885,7 +885,7 @@
String[] filteredCnapNames = null;
if (carrierConfig != null) {
filteredCnapNames = carrierConfig.getStringArray(
- CarrierConfigManager.FILTERED_CNAP_NAMES_STRING_ARRAY);
+ CarrierConfigManager.KEY_FILTERED_CNAP_NAMES_STRING_ARRAY);
}
if (filteredCnapNames != null) {
long cnapNameMatches = Arrays.asList(filteredCnapNames)
diff --git a/src/com/android/services/telephony/activation/Activator.java b/src/com/android/services/telephony/activation/Activator.java
deleted file mode 100644
index 7dee5b3..0000000
--- a/src/com/android/services/telephony/activation/Activator.java
+++ /dev/null
@@ -1,24 +0,0 @@
-/*
- * Copyright (C) 2015 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package com.android.services.telephony.activation;
-
-/**
- * SIM Activation implementation generic interface.
- */
-public interface Activator {
- void onActivate();
-}
diff --git a/src/com/android/services/telephony/activation/OtaspActivator.java b/src/com/android/services/telephony/activation/OtaspActivator.java
deleted file mode 100644
index 11ba726..0000000
--- a/src/com/android/services/telephony/activation/OtaspActivator.java
+++ /dev/null
@@ -1,29 +0,0 @@
-/*
- * Copyright (C) 2015 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package com.android.services.telephony.activation;
-
-/**
- * Over-The-Air SIM Provisioning (OTASP) activation implementation.
- *
- * Handles OTASP activation requests and returns status updates as activation progresses.
- */
-public class OtaspActivator implements Activator {
- @Override
- public void onActivate() {
- // TODO: handle otasp activation
- }
-}
diff --git a/src/com/android/services/telephony/activation/SimActivationActivity.java b/src/com/android/services/telephony/activation/SimActivationActivity.java
deleted file mode 100644
index ae11a3f..0000000
--- a/src/com/android/services/telephony/activation/SimActivationActivity.java
+++ /dev/null
@@ -1,73 +0,0 @@
-/*
- * Copyright (C) 2015 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package com.android.services.telephony.activation;
-
-import android.app.Activity;
-import android.app.PendingIntent;
-import android.app.PendingIntent.CanceledException;
-import android.content.Intent;
-import android.os.Bundle;
-import android.telephony.TelephonyManager;
-
-import com.android.phone.PhoneGlobals;
-import com.android.services.telephony.Log;
-
-/**
- * Invisible activity that handles the android.intent.action.SIM_ACTIVATION_REQUEST intent.
- * This activity is protected by the android.permission.PERFORM_SIM_ACTIVATION permission.
- */
-public class SimActivationActivity extends Activity {
- @Override
- protected void onCreate(Bundle icicle) {
- super.onCreate(icicle);
- Log.i(this, "onCreate");
-
- Intent intent = getIntent();
- if (Intent.ACTION_SIM_ACTIVATION_REQUEST.equals(intent.getAction())) {
- Log.i(this, "Activation requested " + intent);
-
- runActivation(intent);
- }
- finish();
- }
-
- private void runActivation(Intent intent) {
- final PendingIntent response =
- intent.getParcelableExtra(Intent.EXTRA_SIM_ACTIVATION_RESPONSE);
-
- Log.i(this, "Running activation w/ response " + response);
-
- PhoneGlobals app = PhoneGlobals.getInstance();
- app.simActivationManager.runActivation(SimActivationManager.Triggers.EXPLICIT_REQUEST,
- new SimActivationManager.Response() {
- @Override
- public void onResponse(int status) {
- if (response != null) {
- try {
- response.send();
- } catch (CanceledException e) {
- Log.w(this, "Could not respond to SIM Activation.");
- }
- }
- }
- });
-
- // TODO: Set this status to the return value of runActivation
- // Return the response as an activity result and the pending intent.
- setResult(TelephonyManager.SIM_ACTIVATION_RESULT_IN_PROGRESS);
- }
-}
diff --git a/src/com/android/services/telephony/activation/SimActivationManager.java b/src/com/android/services/telephony/activation/SimActivationManager.java
deleted file mode 100644
index ce9e508..0000000
--- a/src/com/android/services/telephony/activation/SimActivationManager.java
+++ /dev/null
@@ -1,67 +0,0 @@
-/*
- * Copyright (C) 2015 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package com.android.services.telephony.activation;
-
-import android.app.PendingIntent;
-import android.telephony.TelephonyManager;
-
-/**
- * Handles SIM activation requests and runs the appropriate activation process until it completes
- * or fails. When done, sends back a response if needed.
- */
-public class SimActivationManager {
- public static final class Triggers {
- public static final int SYSTEM_START = 1;
- public static final int EXPLICIT_REQUEST = 2;
- }
-
- public interface Response {
- /**
- * @param status See {@link android.telephony.TelephonyManager} for SIM_ACTIVATION_RESULT_*
- * constants.
- */
- void onResponse(int status);
- }
-
- public void runActivation(int trigger, Response response) {
- Activator activator = selectActivator(trigger);
-
- activator.onActivate();
-
- // TODO: Specify some way to determine if activation is even necessary.
-
- // TODO: specify some way to return the result.
-
- if (response != null) {
- response.onResponse(TelephonyManager.SIM_ACTIVATION_RESULT_COMPLETE);
- }
- }
-
- private Activator selectActivator(int trigger) {
- // TODO: Select among all activator types
-
- // For now, pick a do-nothing activator
- return new Activator() {
-
- /** ${inheritDoc} */
- @Override
- public void onActivate() {
- // do something
- }
- };
- }
-}
diff --git a/tests/Android.mk b/tests/Android.mk
index 59cba42..66df1a8 100644
--- a/tests/Android.mk
+++ b/tests/Android.mk
@@ -25,12 +25,13 @@
LOCAL_MODULE_TAGS := tests
-LOCAL_JAVA_LIBRARIES := telephony-common android-support-test
+LOCAL_JAVA_LIBRARIES := telephony-common
LOCAL_INSTRUMENTATION_FOR := TeleService
LOCAL_STATIC_JAVA_LIBRARIES := \
android-support-test \
- mockito-target
+ mockito-target \
+ legacy-android-test
include $(BUILD_PACKAGE)
diff --git a/tests/AndroidManifest.xml b/tests/AndroidManifest.xml
index cae4c1b..7962738 100644
--- a/tests/AndroidManifest.xml
+++ b/tests/AndroidManifest.xml
@@ -19,7 +19,6 @@
<uses-permission android:name="android.permission.CALL_PHONE" />
<uses-permission android:name="android.permission.PERFORM_CDMA_PROVISIONING" />
- <uses-permission android:name="android.permission.PERFORM_SIM_ACTIVATION" />
<application android:label="@string/app_name">
<uses-library android:name="android.test.runner" />
diff --git a/tests/src/com/android/services/telephony/activation/ResponseReceiver.java b/tests/src/com/android/services/telephony/activation/ResponseReceiver.java
deleted file mode 100644
index 33e7f00..0000000
--- a/tests/src/com/android/services/telephony/activation/ResponseReceiver.java
+++ /dev/null
@@ -1,65 +0,0 @@
-/*
- * Copyright (C) 2015 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package com.android.services.telephony.activation;
-
-import android.content.BroadcastReceiver;
-import android.content.Context;
-import android.content.Intent;
-import android.content.IntentFilter;
-
-import com.android.services.telephony.Log;
-
-public class ResponseReceiver extends BroadcastReceiver {
- volatile public static boolean responseReceived = false;
- public static final String ACTION_ACTIVATION_RESPONSE =
- "com.android.services.telephony.ACTIVATION_RESPONSE";
-
- private final Object mLock;
- private Context mContext;
-
- ResponseReceiver(Object lock) {
- mLock = lock;
- }
-
- /** ${inheritDoc} */
- @Override
- public void onReceive(Context context, Intent intent) {
- if (!ACTION_ACTIVATION_RESPONSE.equals(intent.getAction())) {
- Log.e(this, null, "Unexpected intent: " + intent.getAction());
- return;
- }
-
- responseReceived = true;
- Log.i(this, "received intent");
-
- if (mLock != null) {
- synchronized(mLock) {
- Log.i(this, "notifying");
- mLock.notify();
- }
- }
- }
-
- void register(Context context) {
- context.registerReceiver(this, new IntentFilter(ACTION_ACTIVATION_RESPONSE));
- mContext = context;
- }
-
- void unregister() {
- mContext.unregisterReceiver(this);
- }
-}
diff --git a/tests/src/com/android/services/telephony/activation/SimActivationTest.java b/tests/src/com/android/services/telephony/activation/SimActivationTest.java
deleted file mode 100644
index f6060dc..0000000
--- a/tests/src/com/android/services/telephony/activation/SimActivationTest.java
+++ /dev/null
@@ -1,73 +0,0 @@
-/*
- * Copyright (C) 2015 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package com.android.services.telephony.activation;
-
-import android.app.PendingIntent;
-import android.content.Context;
-import android.content.Intent;
-import android.test.AndroidTestCase;
-import android.test.suitebuilder.annotation.SmallTest;
-
-import com.android.services.telephony.Log;
-
-public class SimActivationTest extends AndroidTestCase {
-
- private static Object mActivationLock = new Object();
- private ResponseReceiver mResponseReceiver;
-
- @Override
- protected void setUp() throws Exception {
- super.setUp();
-
- mResponseReceiver = new ResponseReceiver(mActivationLock);
- mResponseReceiver.register(context());
- }
-
- /** ${inheritDoc} */
- @Override
- protected void tearDown() throws Exception {
- mResponseReceiver.unregister();
- super.tearDown();
- }
-
- @SmallTest
- public void testSimActivationResponse() throws Exception {
- Log.i(this, "Running activation test");
-
- Intent responseIntent = new Intent(ResponseReceiver.ACTION_ACTIVATION_RESPONSE);
- responseIntent.setPackage(context().getPackageName());
- PendingIntent pendingResponse = PendingIntent.getBroadcast(
- context(), 0, responseIntent, 0);
-
- Intent intent = new Intent(Intent.ACTION_SIM_ACTIVATION_REQUEST);
- intent.putExtra(Intent.EXTRA_SIM_ACTIVATION_RESPONSE, pendingResponse);
- intent.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
-
- Log.i(this, "sent intent");
- context().startActivity(intent);
- synchronized (mActivationLock) {
- Log.i(this, "waiting ");
- mActivationLock.wait(5000);
- Log.i(this, "unwaiting");
- }
- assertTrue(ResponseReceiver.responseReceived);
- }
-
- private Context context() {
- return getContext();
- }
-}