commit 80855d56b0e0ca102371a56285c9f259f2e5f426
author Santos Cordon <santoscordon@google.com> Tue Feb 10 04:33:36 2015 -0800
committer Etan Cohen <etancohen@google.com> Mon Mar 02 10:28:58 2015 -0800
tree dab215b0844b61fda4834f3e9c42687d5affaa56
parent 21e78ace4e0366ad2bc7f39406b7fa8dff2bd407

Change Telephony PhoneAccount to use ICC ID

Stop using subscription ID and instead use the ICC ID.

Change-Id: I7f73caa5788ea3822b23b98e49a58bc3d2c2f324

src/com/android/phone/PhoneUtils.java

diff --git a/src/com/android/phone/PhoneUtils.java b/src/com/android/phone/PhoneUtils.java
index 7da2e1f..615f777 100644
--- a/src/com/android/phone/PhoneUtils.java
+++ b/src/com/android/phone/PhoneUtils.java
@@ -61,6 +61,7 @@
 import com.android.internal.telephony.TelephonyCapabilities;
 import com.android.internal.telephony.TelephonyProperties;
 import com.android.internal.telephony.sip.SipPhone;
+import com.android.internal.telephony.uicc.UiccCard;
 import com.android.phone.CallGatewayManager.RawGatewayInfo;
 import com.android.services.telephony.TelephonyConnectionService;
 
@@ -2457,7 +2458,7 @@
         ComponentName pstnConnectionServiceName = getPstnConnectionServiceName();
         // TODO: Should use some sort of special hidden flag to decorate this account as
         // an emergency-only account
-        String id = isEmergency ? "E" : prefix + String.valueOf(phone.getSubId());
+        String id = isEmergency ? "E" : prefix + String.valueOf(phone.getIccSerialNumber());
         return new PhoneAccountHandle(pstnConnectionServiceName, id);
     }
 
@@ -2471,9 +2472,9 @@
 
     public static int getSubIdForPhoneAccountHandle(PhoneAccountHandle handle) {
         if (handle != null && handle.getComponentName().equals(getPstnConnectionServiceName())) {
-            String id = handle.getId();
-            if (TextUtils.isDigitsOnly(id)) {
-                return Integer.parseInt(id);
+            Phone phone = getPhoneFromIccId(handle.getId());
+            if (phone != null) {
+                return phone.getSubId();
             }
         }
         return SubscriptionManager.INVALID_SUBSCRIPTION_ID;
@@ -2483,6 +2484,19 @@
         return new ComponentName(PhoneGlobals.getInstance(), TelephonyConnectionService.class);
     }
 
+    private static Phone getPhoneFromIccId(String iccId) {
+        if (!TextUtils.isEmpty(iccId)) {
+            for (Phone phone : PhoneFactory.getPhones()) {
+                String phoneIccId = phone.getIccSerialNumber();
+                if (iccId.equals(phoneIccId)) {
+                    return phone;
+                }
+            }
+        }
+
+        return null;
+    }
+
     /**
      * Register ICC status for all phones.
      */