commit 07b3d67ee2ae45392b9f0e50118aeef8fd5af602
author Malcolm Chen <refuhoo@google.com> Tue Mar 17 16:58:04 2020 -0700
committer Xiangyu/Malcolm Chen <refuhoo@google.com> Thu Mar 19 19:05:11 2020 +0000
tree 47f3f7972531b0d30ac3bdf6e91dd95765777f52
parent 1265c36467711eb579db2a0a66a8cb5cf8225fae

Solve flakiness of RadioOnStateListenerTest

Adding null checks.
In teardown, clean messages first before waiting for
unfinished msg processing.

Bug: 151671239
Bug: 151921447
Test: unittest
Change-Id: I9c93100c200be215c42c9c65ef534a0fb6b9a158
Merged-In: I9c93100c200be215c42c9c65ef534a0fb6b9a158

src/com/android/services/telephony/RadioOnStateListener.java

diff --git a/src/com/android/services/telephony/RadioOnStateListener.java b/src/com/android/services/telephony/RadioOnStateListener.java
index 43269b4..53f97f0 100644
--- a/src/com/android/services/telephony/RadioOnStateListener.java
+++ b/src/com/android/services/telephony/RadioOnStateListener.java
@@ -159,6 +159,7 @@
      * call with {@link Callback#isOkToCall}
      */
     private void onServiceStateChanged(ServiceState state) {
+        if (mPhone == null) return;
         Log.d(this, "onServiceStateChanged(), new state = %s, Phone = %s", state,
                 mPhone.getPhoneId());
 
@@ -182,6 +183,7 @@
     }
 
     private void onRadioOn() {
+        if (mPhone == null) return;
         ServiceState state =  mPhone.getServiceState();
         Log.d(this, "onRadioOn, state = %s, Phone = %s", state,
                 mPhone.getPhoneId());
@@ -203,6 +205,7 @@
      * Handles the retry timer expiring.
      */
     private void onRetryTimeout() {
+        if (mPhone == null) return;
         int serviceState = mPhone.getServiceState().getState();
         Log.d(this, "onRetryTimeout():  phone state = %s, service state = %d, retries = %d.",
                 mPhone.getState(), serviceState, mNumRetriesSoFar);

tests/src/com/android/services/telephony/RadioOnStateListenerTest.java

diff --git a/tests/src/com/android/services/telephony/RadioOnStateListenerTest.java b/tests/src/com/android/services/telephony/RadioOnStateListenerTest.java
index afdfab5..073aa2c 100644
--- a/tests/src/com/android/services/telephony/RadioOnStateListenerTest.java
+++ b/tests/src/com/android/services/telephony/RadioOnStateListenerTest.java
@@ -69,9 +69,9 @@
     @Override
     @After
     public void tearDown() throws Exception {
+        mListener.getHandler().removeCallbacksAndMessages(null);
         // Wait for the queue to clear...
         waitForHandlerAction(mListener.getHandler(), TIMEOUT_MS /*ms timeout*/);
-        mListener.getHandler().removeCallbacksAndMessages(null);
         mListener = null;
         super.tearDown();
     }