commit 8a0643b572571e3acbeb029c426ee8af851b4464
author Grace Jia <xiaotonj@google.com> Mon Aug 17 18:44:19 2020 +0000
committer Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> Mon Aug 17 18:44:19 2020 +0000
tree 830aff0990e3f4186bcf0a532469a4ea328252dd
parent 5c09ceb9896fdce64f56e00fa5a1ca674fa36dee
parent a6a9176d196effbe8a9d77e1a15b7692b8d75104

Fix security vulnerability of TelecomManager#getPhoneAccountsForPackage am: f3f2d7c2dc am: 21bc22a06e am: 0b9f87a4e3 am: 094c156982 am: 1aadaf8e1a am: a6a9176d19

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/services/Telecomm/+/12141784

Change-Id: Ifcb2327a43a526cb80148e6906a28ae09979522b

src/com/android/server/telecom/TelecomServiceImpl.java

diff --git a/src/com/android/server/telecom/TelecomServiceImpl.java b/src/com/android/server/telecom/TelecomServiceImpl.java
index 62e0f3f..9ccae9a 100644
--- a/src/com/android/server/telecom/TelecomServiceImpl.java
+++ b/src/com/android/server/telecom/TelecomServiceImpl.java
@@ -279,6 +279,23 @@
 
         @Override
         public List<PhoneAccountHandle> getPhoneAccountsForPackage(String packageName) {
+            //TODO: Deprecate this in S
+            try {
+                enforceCallingPackage(packageName);
+            } catch (SecurityException se1) {
+                EventLog.writeEvent(0x534e4554, "153995334", Binder.getCallingUid(),
+                        "getPhoneAccountsForPackage: invalid calling package");
+                throw se1;
+            }
+
+            try {
+                enforcePermission(READ_PRIVILEGED_PHONE_STATE);
+            } catch (SecurityException se2) {
+                EventLog.writeEvent(0x534e4554, "153995334", Binder.getCallingUid(),
+                        "getPhoneAccountsForPackage: no permission");
+                throw se2;
+            }
+
             synchronized (mLock) {
                 final UserHandle callingUserHandle = Binder.getCallingUserHandle();
                 long token = Binder.clearCallingIdentity();