commit 6a054ec3732408646910e4a74259df91f9dec0f5
author Grant Menke <grantmenke@google.com> Tue Sep 05 15:48:33 2023 -0700
committer Grant Menke <grantmenke@google.com> Tue Sep 05 15:48:33 2023 -0700
tree 5a137452195e53810600e84921cb3f4d9a2577a9
parent 15e7438cd212e2ec46c6afc83064dd25c254e84c

Remove emergency call disconnected before added anomaly.

This change removes an anomaly report invocation for emergency calls that are disconnected before they are started being tracked by CallsManager. When there is a connecting MO emergeny call Telecom intentionally disconnects any new MO emergency calls. This is WAI but was causing this anomaly report to fire since those newly placed MO emergency calls were being disconnected before they were being tracked by CallsManager. This change removes this invocation altogether since it is causing these false positives and hasnt caught any useful anomalies since being implemented 6 months ago.

Bug: 296991417
Test: manual
Change-Id: I324ee98f65f0bb8b3d8bc3b270bfdccf10b8daba

src/com/android/server/telecom/CallsManager.java

diff --git a/src/com/android/server/telecom/CallsManager.java b/src/com/android/server/telecom/CallsManager.java
index 2544576..4372711 100644
--- a/src/com/android/server/telecom/CallsManager.java
+++ b/src/com/android/server/telecom/CallsManager.java
@@ -288,11 +288,6 @@
     public static final String EXCEPTION_RETRIEVING_PHONE_ACCOUNTS_EMERGENCY_ERROR_MSG =
             "Exception thrown while retrieving list of potential phone accounts when placing an "
                     + "emergency call.";
-    public static final UUID EMERGENCY_CALL_DISCONNECTED_BEFORE_BEING_ADDED_ERROR_UUID =
-            UUID.fromString("f9a916c8-8d61-4550-9ad3-11c2e84f6364");
-    public static final String EMERGENCY_CALL_DISCONNECTED_BEFORE_BEING_ADDED_ERROR_MSG =
-            "An emergency call was disconnected after the connection was created but before the "
-                    + "call was successfully added to CallsManager.";
     public static final UUID EMERGENCY_CALL_ABORTED_NO_PHONE_ACCOUNTS_ERROR_UUID =
             UUID.fromString("2e994acb-1997-4345-8bf3-bad04303de26");
     public static final String EMERGENCY_CALL_ABORTED_NO_PHONE_ACCOUNTS_ERROR_MSG =
@@ -3762,11 +3757,6 @@
         // Notify listeners that the call was disconnected before being added to CallsManager.
         // Listeners will not receive onAdded or onRemoved callbacks.
         if (!mCalls.contains(call)) {
-            if (call.isEmergencyCall()) {
-                mAnomalyReporter.reportAnomaly(
-                        EMERGENCY_CALL_DISCONNECTED_BEFORE_BEING_ADDED_ERROR_UUID,
-                        EMERGENCY_CALL_DISCONNECTED_BEFORE_BEING_ADDED_ERROR_MSG);
-            }
             mListeners.forEach(l -> l.onCreateConnectionFailed(call));
         }