blob: 4b03bac8c6ead9459be12d4c5ca4435d55774ff8 [file] [log] [blame]
Andrew Walbrand6dce6f2021-03-05 16:39:08 +00001// Copyright 2021, The Android Open Source Project
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15//! Functions for running instances of `crosvm`.
16
Seungjae Yoo3271f172024-06-11 10:14:07 +090017use crate::aidl::{remove_temporary_files, Cid, GLOBAL_SERVICE, VirtualMachineCallbacks};
Seungjae Yoob2db3d22023-04-06 18:05:43 +090018use crate::atom::{get_num_cpus, write_vm_exited_stats_sync};
Jaewan Kim61f86142023-03-28 15:12:52 +090019use crate::debug_config::DebugConfig;
Seungjae Yoo6d265d92022-11-15 10:51:33 +090020use anyhow::{anyhow, bail, Context, Error, Result};
Seungjae Yoo3271f172024-06-11 10:14:07 +090021use binder::ParcelFileDescriptor;
Andrew Walbran02b8ec02021-06-22 13:07:02 +000022use command_fds::CommandFdExt;
Jiyong Parke6ed0f92022-06-22 00:13:00 +090023use lazy_static::lazy_static;
Seungjae Yoo6d265d92022-11-15 10:51:33 +090024use libc::{sysconf, _SC_CLK_TCK};
Andrew Walbran3a5a9212021-05-04 17:09:08 +000025use log::{debug, error, info};
Jiyong Parkdcf17412022-02-08 15:07:23 +090026use semver::{Version, VersionReq};
Jiyong Park08eee7b2022-11-11 15:01:26 +090027use nix::{fcntl::OFlag, unistd::pipe2, unistd::Uid, unistd::User};
Jiyong Park2d736562022-10-24 22:40:12 +090028use regex::{Captures, Regex};
Keir Fraserf25cb922022-11-23 14:26:00 +000029use rustutils::system_properties;
Andrew Walbrandae07162021-03-12 17:05:20 +000030use shared_child::SharedChild;
Jiyong Parke6ed0f92022-06-22 00:13:00 +090031use std::borrow::Cow;
Seungjae Yoo6d265d92022-11-15 10:51:33 +090032use std::cmp::max;
Jiyong Park08eee7b2022-11-11 15:01:26 +090033use std::fmt;
David Brazdil4b4c5102022-12-19 22:56:20 +000034use std::fs::{read_to_string, File};
Andrew Walbranb27681f2022-02-23 15:11:52 +000035use std::io::{self, Read};
Andrew Walbranf8d94112021-09-07 11:45:36 +000036use std::mem;
Nikita Ioffe5776f082023-02-10 21:38:26 +000037use std::num::{NonZeroU16, NonZeroU32};
Seungjae Yoo3271f172024-06-11 10:14:07 +090038use std::os::unix::io::{AsRawFd, OwnedFd, RawFd};
Seungjae Yoo93430e82022-12-05 16:37:42 +090039use std::os::unix::process::ExitStatusExt;
Jiyong Park1612b902022-08-22 14:47:39 +090040use std::path::{Path, PathBuf};
Andrew Walbranc92d35f2022-01-12 12:45:19 +000041use std::process::{Command, ExitStatus};
Jiyong Parke6ed0f92022-06-22 00:13:00 +090042use std::sync::{Arc, Condvar, Mutex};
Seungjae Yoo2e7beea2022-08-24 16:09:12 +090043use std::time::{Duration, SystemTime};
David Brazdilf18e1162022-12-18 18:27:23 +000044use std::thread::{self, JoinHandle};
David Brazdil49f96f52022-12-16 21:29:13 +000045use android_system_virtualizationcommon::aidl::android::system::virtualizationcommon::DeathReason::DeathReason;
Jaewan Kim84b91212023-02-28 00:11:57 +090046use android_system_virtualizationservice::aidl::android::system::virtualizationservice::{
47 MemoryTrimLevel::MemoryTrimLevel,
Jeongik Cha1df1c032024-04-03 16:03:12 +090048 VirtualMachineAppConfig::DebugLevel::DebugLevel,
49 DisplayConfig::DisplayConfig as DisplayConfigParcelable,
Jaewan Kim84b91212023-02-28 00:11:57 +090050};
David Brazdil528e0472022-10-10 15:06:02 +010051use android_system_virtualizationservice_internal::aidl::android::system::virtualizationservice_internal::IGlobalVmContext::IGlobalVmContext;
Jakob Vukalovicd42aa2c2023-11-09 16:04:00 +000052use android_system_virtualizationservice_internal::aidl::android::system::virtualizationservice_internal::IBoundDevice::IBoundDevice;
Alan Stokes0e82b502022-08-08 14:44:48 +010053use binder::Strong;
Inseob Kimc7d28c72021-10-25 14:28:10 +000054use android_system_virtualmachineservice::aidl::android::system::virtualmachineservice::IVirtualMachineService::IVirtualMachineService;
Jiyong Park1612b902022-08-22 14:47:39 +090055use tombstoned_client::{TombstonedConnection, DebuggerdDumpType};
David Brazdil73988ea2022-11-11 15:10:32 +000056use rpcbinder::RpcServer;
Andrew Walbrand6dce6f2021-03-05 16:39:08 +000057
Keir Fraser13a956a2022-07-14 14:20:46 +000058/// external/crosvm
Elie Kheirallah2d12ff32023-03-20 18:12:07 +000059use base::AsRawDescriptor;
Keir Fraser13a956a2022-07-14 14:20:46 +000060use base::UnixSeqpacketListener;
Keir Frasercdd4b112022-11-24 14:02:25 +000061use vm_control::{BalloonControlCommand, VmRequest, VmResponse};
Keir Fraser13a956a2022-07-14 14:20:46 +000062
Andrew Walbrand6dce6f2021-03-05 16:39:08 +000063const CROSVM_PATH: &str = "/apex/com.android.virt/bin/crosvm";
64
Jiyong Parkdcf17412022-02-08 15:07:23 +090065/// Version of the platform that crosvm currently implements. The format follows SemVer. This
66/// should be updated when there is a platform change in the crosvm side. Having this value here is
67/// fine because virtualizationservice and crosvm are supposed to be updated together in the virt
68/// APEX.
69const CROSVM_PLATFORM_VERSION: &str = "1.0.0";
70
Andrew Walbrand15c5632022-02-03 13:38:31 +000071/// The exit status which crosvm returns when it has an error starting a VM.
Alan Stokes7c459e82022-12-06 12:21:49 +000072const CROSVM_START_ERROR_STATUS: i32 = 1;
Andrew Walbranc92d35f2022-01-12 12:45:19 +000073/// The exit status which crosvm returns when a VM requests a reboot.
74const CROSVM_REBOOT_STATUS: i32 = 32;
Andrew Walbrand15c5632022-02-03 13:38:31 +000075/// The exit status which crosvm returns when it crashes due to an error.
76const CROSVM_CRASH_STATUS: i32 = 33;
Sebastian Ene23167d82022-10-07 14:09:53 +000077/// The exit status which crosvm returns when vcpu is stalled.
78const CROSVM_WATCHDOG_REBOOT_STATUS: i32 = 36;
Jiyong Park3115cdb2023-02-24 18:04:44 +090079/// The size of memory (in MiB) reserved for ramdump
80const RAMDUMP_RESERVED_MIB: u32 = 17;
Andrew Walbranc92d35f2022-01-12 12:45:19 +000081
Seungjae Yoo6d265d92022-11-15 10:51:33 +090082const MILLIS_PER_SEC: i64 = 1000;
83
Jaewan Kim46422812022-11-25 10:59:39 +090084const SYSPROP_CUSTOM_PVMFW_PATH: &str = "hypervisor.pvmfw.path";
85
Yi-Yo Chiang8dd32552024-05-22 19:38:16 +080086/// Serial device for VM console input.
87/// Hypervisor (virtio-console)
88const CONSOLE_HVC0: &str = "hvc0";
89/// Serial (emulated uart)
90const CONSOLE_TTYS0: &str = "ttyS0";
91
Jiyong Parke6ed0f92022-06-22 00:13:00 +090092lazy_static! {
93 /// If the VM doesn't move to the Started state within this amount time, a hang-up error is
94 /// triggered.
Alan Stokesc3f2ac22022-06-23 12:19:46 +010095 static ref BOOT_HANGUP_TIMEOUT: Duration = if nested_virt::is_nested_virtualization().unwrap() {
Jiyong Parke6ed0f92022-06-22 00:13:00 +090096 // Nested virtualization is slow, so we need a longer timeout.
Inseob Kime557cec2023-01-26 22:49:58 +090097 Duration::from_secs(300)
Jiyong Parke6ed0f92022-06-22 00:13:00 +090098 } else {
Inseob Kime557cec2023-01-26 22:49:58 +090099 Duration::from_secs(30)
Jiyong Parke6ed0f92022-06-22 00:13:00 +0900100 };
101}
102
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000103/// Configuration for a VM to run with crosvm.
104#[derive(Debug)]
Andrew Walbrand3a84182021-09-07 14:48:52 +0000105pub struct CrosvmConfig {
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000106 pub cid: Cid,
Seungjae Yoo62085c02022-08-12 04:44:52 +0000107 pub name: String,
Andrew Walbrand3a84182021-09-07 14:48:52 +0000108 pub bootloader: Option<File>,
109 pub kernel: Option<File>,
110 pub initrd: Option<File>,
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000111 pub disks: Vec<DiskFile>,
112 pub params: Option<String>,
Andrew Walbranf8650422021-06-09 15:54:09 +0000113 pub protected: bool,
Jaewan Kim61f86142023-03-28 15:12:52 +0900114 pub debug_config: DebugConfig,
Andrew Walbranb15cd6e2021-07-05 16:38:07 +0000115 pub memory_mib: Option<NonZeroU32>,
Jiyong Park032615f2022-01-10 13:55:34 +0900116 pub cpus: Option<NonZeroU32>,
David Brazdil7d1e5ec2023-02-06 17:56:29 +0000117 pub host_cpu_topology: bool,
Jiyong Parke6fb1672023-06-26 16:45:55 +0900118 pub console_out_fd: Option<File>,
119 pub console_in_fd: Option<File>,
Andrew Walbrand3a84182021-09-07 14:48:52 +0000120 pub log_fd: Option<File>,
Jiyong Parke558ab12022-07-07 20:18:55 +0900121 pub ramdump: Option<File>,
Andrew Walbrand3a84182021-09-07 14:48:52 +0000122 pub indirect_files: Vec<File>,
Jiyong Parkdcf17412022-02-08 15:07:23 +0900123 pub platform_version: VersionReq,
Jiyong Parke6ed0f92022-06-22 00:13:00 +0900124 pub detect_hangup: bool,
Nikita Ioffe5776f082023-02-10 21:38:26 +0000125 pub gdb_port: Option<NonZeroU16>,
Inseob Kim7307a892023-09-14 13:37:58 +0900126 pub vfio_devices: Vec<VfioDevice>,
David Brazdil2dfefd12023-11-17 14:07:36 +0000127 pub dtbo: Option<File>,
Shikha Panwar55e10ec2024-02-13 12:53:49 +0000128 pub device_tree_overlay: Option<File>,
Jeongik Cha1df1c032024-04-03 16:03:12 +0900129 pub display_config: Option<DisplayConfig>,
Jeongik Chac181be72024-03-27 00:18:30 +0900130 pub input_device_options: Vec<InputDeviceOption>,
Vincent Donnefort538a2c62024-03-20 16:01:10 +0000131 pub hugepages: bool,
Seungjae Yoo986d7a42024-05-28 14:06:58 +0900132 pub tap: Option<File>,
Mu-Le Lee134180a2024-04-16 15:13:07 +0800133 pub virtio_snd_backend: Option<String>,
Yi-Yo Chiang8dd32552024-05-22 19:38:16 +0800134 pub console_input_device: Option<String>,
Jeongik Cha1df1c032024-04-03 16:03:12 +0900135}
136
137#[derive(Debug)]
138pub struct DisplayConfig {
139 pub width: NonZeroU32,
140 pub height: NonZeroU32,
141 pub horizontal_dpi: NonZeroU32,
142 pub vertical_dpi: NonZeroU32,
143 pub refresh_rate: NonZeroU32,
144}
145
146impl DisplayConfig {
147 pub fn new(raw_config: &DisplayConfigParcelable) -> Result<DisplayConfig> {
148 let width = try_into_non_zero_u32(raw_config.width)?;
149 let height = try_into_non_zero_u32(raw_config.height)?;
150 let horizontal_dpi = try_into_non_zero_u32(raw_config.horizontalDpi)?;
151 let vertical_dpi = try_into_non_zero_u32(raw_config.verticalDpi)?;
152 let refresh_rate = try_into_non_zero_u32(raw_config.refreshRate)?;
153 Ok(DisplayConfig { width, height, horizontal_dpi, vertical_dpi, refresh_rate })
154 }
155}
156
157fn try_into_non_zero_u32(value: i32) -> Result<NonZeroU32> {
158 let u32_value = value.try_into()?;
159 NonZeroU32::new(u32_value).ok_or(anyhow!("value should be greater than 0"))
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000160}
161
162/// A disk image to pass to crosvm for a VM.
163#[derive(Debug)]
164pub struct DiskFile {
165 pub image: File,
166 pub writable: bool,
167}
168
Jeongik Chac181be72024-03-27 00:18:30 +0900169/// virtio-input device configuration from `external/crosvm/src/crosvm/config.rs`
170#[derive(Debug)]
171#[allow(dead_code)]
172pub enum InputDeviceOption {
173 EvDev(File),
174 SingleTouch { file: File, width: u32, height: u32, name: Option<String> },
Jeongik Cha985b6402024-04-15 18:13:00 +0900175 Keyboard(File),
Jeongik Cha343894e2024-05-17 20:39:31 +0900176 Mouse(File),
Jeongik Chac181be72024-03-27 00:18:30 +0900177}
178
Jakob Vukalovicd42aa2c2023-11-09 16:04:00 +0000179type VfioDevice = Strong<dyn IBoundDevice>;
Inseob Kim7307a892023-09-14 13:37:58 +0900180
Andrew Walbran6b650662021-09-07 13:13:23 +0000181/// The lifecycle state which the payload in the VM has reported itself to be in.
182///
183/// Note that the order of enum variants is significant; only forward transitions are allowed by
184/// [`VmInstance::update_payload_state`].
185#[derive(Copy, Clone, Debug, Eq, Ord, PartialEq, PartialOrd)]
186pub enum PayloadState {
187 Starting,
188 Started,
189 Ready,
190 Finished,
Jiyong Parka4eebde2022-07-12 18:01:12 +0900191 Hangup, // Hasn't reached to Ready before timeout expires
Andrew Walbran6b650662021-09-07 13:13:23 +0000192}
193
Andrew Walbranf8d94112021-09-07 11:45:36 +0000194/// The current state of the VM itself.
195#[derive(Debug)]
196pub enum VmState {
197 /// The VM has not yet tried to start.
198 NotStarted {
199 ///The configuration needed to start the VM, if it has not yet been started.
Inseob Kim7307a892023-09-14 13:37:58 +0900200 config: Box<CrosvmConfig>,
Andrew Walbranf8d94112021-09-07 11:45:36 +0000201 },
202 /// The VM has been started.
203 Running {
204 /// The crosvm child process.
205 child: Arc<SharedChild>,
David Brazdilf18e1162022-12-18 18:27:23 +0000206 /// The thread waiting for crosvm to finish.
207 monitor_vm_exit_thread: Option<JoinHandle<()>>,
Andrew Walbranf8d94112021-09-07 11:45:36 +0000208 },
209 /// The VM died or was killed.
210 Dead,
211 /// The VM failed to start.
212 Failed,
213}
214
Seungjae Yoo6d265d92022-11-15 10:51:33 +0900215/// RSS values of VM and CrosVM process itself.
216#[derive(Copy, Clone, Debug, Default)]
217pub struct Rss {
218 pub vm: i64,
219 pub crosvm: i64,
220}
221
222/// Metrics regarding the VM.
223#[derive(Debug, Default)]
224pub struct VmMetric {
225 /// Recorded timestamp when the VM is started.
226 pub start_timestamp: Option<SystemTime>,
Pierre-Clément Tosi44aba642023-09-15 11:44:34 +0100227 /// Update most recent guest_time periodically from /proc/[crosvm pid]/stat while VM is
228 /// running.
Seungjae Yoo6d265d92022-11-15 10:51:33 +0900229 pub cpu_guest_time: Option<i64>,
230 /// Update maximum RSS values periodically from /proc/[crosvm pid]/smaps while VM is running.
231 pub rss: Option<Rss>,
232}
233
Andrew Walbranf8d94112021-09-07 11:45:36 +0000234impl VmState {
235 /// Tries to start the VM, if it is in the `NotStarted` state.
236 ///
237 /// Returns an error if the VM is in the wrong state, or fails to start.
238 fn start(&mut self, instance: Arc<VmInstance>) -> Result<(), Error> {
239 let state = mem::replace(self, VmState::Failed);
240 if let VmState::NotStarted { config } = state {
Inseob Kim7307a892023-09-14 13:37:58 +0900241 let config = *config;
Jiyong Parke6ed0f92022-06-22 00:13:00 +0900242 let detect_hangup = config.detect_hangup;
Andrew Walbranb27681f2022-02-23 15:11:52 +0000243 let (failure_pipe_read, failure_pipe_write) = create_pipe()?;
Inseob Kim6ef80972023-07-20 17:23:36 +0900244 let vfio_devices = config.vfio_devices.clone();
Seungjae Yoo3271f172024-06-11 10:14:07 +0900245 let tap =
246 if let Some(tap_file) = &config.tap { Some(tap_file.try_clone()?) } else { None };
Andrew Walbranb27681f2022-02-23 15:11:52 +0000247
Andrew Walbranf8d94112021-09-07 11:45:36 +0000248 // If this fails and returns an error, `self` will be left in the `Failed` state.
Keir Fraser13a956a2022-07-14 14:20:46 +0000249 let child =
Keir Frasercdd4b112022-11-24 14:02:25 +0000250 Arc::new(run_vm(config, &instance.crosvm_control_socket_path, failure_pipe_write)?);
Andrew Walbranf8d94112021-09-07 11:45:36 +0000251
Seungjae Yoo6d265d92022-11-15 10:51:33 +0900252 let instance_monitor_status = instance.clone();
253 let child_monitor_status = child.clone();
254 thread::spawn(move || {
255 instance_monitor_status.clone().monitor_vm_status(child_monitor_status);
256 });
257
Andrew Walbranf8d94112021-09-07 11:45:36 +0000258 let child_clone = child.clone();
Jiyong Parka4eebde2022-07-12 18:01:12 +0900259 let instance_clone = instance.clone();
David Brazdilf18e1162022-12-18 18:27:23 +0000260 let monitor_vm_exit_thread = Some(thread::spawn(move || {
Seungjae Yoo3271f172024-06-11 10:14:07 +0900261 instance_clone.monitor_vm_exit(child_clone, failure_pipe_read, vfio_devices, tap);
David Brazdilf18e1162022-12-18 18:27:23 +0000262 }));
Andrew Walbranf8d94112021-09-07 11:45:36 +0000263
Jiyong Parka4eebde2022-07-12 18:01:12 +0900264 if detect_hangup {
265 let child_clone = child.clone();
266 thread::spawn(move || {
267 instance.monitor_payload_hangup(child_clone);
268 });
269 }
270
Andrew Walbranf8d94112021-09-07 11:45:36 +0000271 // If it started correctly, update the state.
David Brazdilf18e1162022-12-18 18:27:23 +0000272 *self = VmState::Running { child, monitor_vm_exit_thread };
Andrew Walbranf8d94112021-09-07 11:45:36 +0000273 Ok(())
274 } else {
275 *self = state;
276 bail!("VM already started or failed")
277 }
278 }
279}
280
David Brazdil8cf8f482022-11-23 14:21:26 +0000281/// Internal struct that holds the handles to globally unique resources of a VM.
282#[derive(Debug)]
283pub struct VmContext {
284 #[allow(dead_code)] // Keeps the global context alive
285 global_context: Strong<dyn IGlobalVmContext>,
286 #[allow(dead_code)] // Keeps the server alive
287 vm_server: RpcServer,
288}
289
290impl VmContext {
291 /// Construct new VmContext.
292 pub fn new(global_context: Strong<dyn IGlobalVmContext>, vm_server: RpcServer) -> VmContext {
293 VmContext { global_context, vm_server }
294 }
295}
296
Andrew Walbranf8d94112021-09-07 11:45:36 +0000297/// Information about a particular instance of a VM which may be running.
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000298#[derive(Debug)]
299pub struct VmInstance {
Andrew Walbranf8d94112021-09-07 11:45:36 +0000300 /// The current state of the VM.
301 pub vm_state: Mutex<VmState>,
David Brazdil8cf8f482022-11-23 14:21:26 +0000302 /// Global resources allocated for this VM.
303 #[allow(dead_code)] // Keeps the context alive
304 vm_context: VmContext,
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000305 /// The CID assigned to the VM for vsock communication.
306 pub cid: Cid,
Keir Frasercdd4b112022-11-24 14:02:25 +0000307 /// Path to crosvm control socket
308 crosvm_control_socket_path: PathBuf,
Seungjae Yoo62085c02022-08-12 04:44:52 +0000309 /// The name of the VM.
310 pub name: String,
Andrew Walbranf8650422021-06-09 15:54:09 +0000311 /// Whether the VM is a protected VM.
312 pub protected: bool,
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000313 /// Directory of temporary files used by the VM while it is running.
314 pub temporary_directory: PathBuf,
Andrew Walbranf6a1eb92021-04-01 11:16:02 +0000315 /// The UID of the process which requested the VM.
316 pub requester_uid: u32,
Andrew Walbranf6a1eb92021-04-01 11:16:02 +0000317 /// The PID of the process which requested the VM. Note that this process may no longer exist
318 /// and the PID may have been reused for a different process, so this should not be trusted.
Andrew Walbran02034492021-04-13 15:05:07 +0000319 pub requester_debug_pid: i32,
Andrew Walbrandae07162021-03-12 17:05:20 +0000320 /// Callbacks to clients of the VM.
321 pub callbacks: VirtualMachineCallbacks,
Inseob Kimc7d28c72021-10-25 14:28:10 +0000322 /// VirtualMachineService binder object for the VM.
323 pub vm_service: Mutex<Option<Strong<dyn IVirtualMachineService>>>,
Seungjae Yoo6d265d92022-11-15 10:51:33 +0900324 /// Recorded metrics of VM such as timestamp or cpu / memory usage.
325 pub vm_metric: Mutex<VmMetric>,
Andrew Walbran6b650662021-09-07 13:13:23 +0000326 /// The latest lifecycle state which the payload reported itself to be in.
327 payload_state: Mutex<PayloadState>,
Jiyong Parka4eebde2022-07-12 18:01:12 +0900328 /// Represents the condition that payload_state was updated
329 payload_state_updated: Condvar,
Jiyong Park08eee7b2022-11-11 15:01:26 +0900330 /// The human readable name of requester_uid
331 requester_uid_name: String,
332}
333
334impl fmt::Display for VmInstance {
335 fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
336 let adj = if self.protected { "Protected" } else { "Non-protected" };
337 write!(
338 f,
339 "{} virtual machine \"{}\" (owner: {}, cid: {})",
340 adj, self.name, self.requester_uid_name, self.cid
341 )
342 }
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000343}
344
345impl VmInstance {
Andrew Walbranf8d94112021-09-07 11:45:36 +0000346 /// Validates the given config and creates a new `VmInstance` but doesn't start running it.
347 pub fn new(
Andrew Walbrand3a84182021-09-07 14:48:52 +0000348 config: CrosvmConfig,
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000349 temporary_directory: PathBuf,
Andrew Walbranf6a1eb92021-04-01 11:16:02 +0000350 requester_uid: u32,
Andrew Walbran02034492021-04-13 15:05:07 +0000351 requester_debug_pid: i32,
David Brazdil8cf8f482022-11-23 14:21:26 +0000352 vm_context: VmContext,
Andrew Walbranf8d94112021-09-07 11:45:36 +0000353 ) -> Result<VmInstance, Error> {
354 validate_config(&config)?;
Andrew Walbrand3a84182021-09-07 14:48:52 +0000355 let cid = config.cid;
Seungjae Yoo62085c02022-08-12 04:44:52 +0000356 let name = config.name.clone();
Andrew Walbrand3a84182021-09-07 14:48:52 +0000357 let protected = config.protected;
Jiyong Park08eee7b2022-11-11 15:01:26 +0900358 let requester_uid_name = User::from_uid(Uid::from_raw(requester_uid))
359 .ok()
360 .flatten()
361 .map_or_else(|| format!("{}", requester_uid), |u| u.name);
362 let instance = VmInstance {
Inseob Kim7307a892023-09-14 13:37:58 +0900363 vm_state: Mutex::new(VmState::NotStarted { config: Box::new(config) }),
David Brazdil528e0472022-10-10 15:06:02 +0100364 vm_context,
Andrew Walbrand3a84182021-09-07 14:48:52 +0000365 cid,
Keir Frasercdd4b112022-11-24 14:02:25 +0000366 crosvm_control_socket_path: temporary_directory.join("crosvm.sock"),
Seungjae Yoo62085c02022-08-12 04:44:52 +0000367 name,
Andrew Walbrand3a84182021-09-07 14:48:52 +0000368 protected,
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000369 temporary_directory,
Andrew Walbran02034492021-04-13 15:05:07 +0000370 requester_uid,
Andrew Walbran02034492021-04-13 15:05:07 +0000371 requester_debug_pid,
Andrew Walbranf8d94112021-09-07 11:45:36 +0000372 callbacks: Default::default(),
Inseob Kimc7d28c72021-10-25 14:28:10 +0000373 vm_service: Mutex::new(None),
Seungjae Yoo6d265d92022-11-15 10:51:33 +0900374 vm_metric: Mutex::new(Default::default()),
Andrew Walbranf8d94112021-09-07 11:45:36 +0000375 payload_state: Mutex::new(PayloadState::Starting),
Jiyong Parka4eebde2022-07-12 18:01:12 +0900376 payload_state_updated: Condvar::new(),
Jiyong Park08eee7b2022-11-11 15:01:26 +0900377 requester_uid_name,
378 };
379 info!("{} created", &instance);
380 Ok(instance)
Andrew Walbrandae07162021-03-12 17:05:20 +0000381 }
382
Andrew Walbranf8d94112021-09-07 11:45:36 +0000383 /// Starts an instance of `crosvm` to manage the VM. The `crosvm` instance will be killed when
384 /// the `VmInstance` is dropped.
385 pub fn start(self: &Arc<Self>) -> Result<(), Error> {
Seungjae Yoo6d265d92022-11-15 10:51:33 +0900386 let mut vm_metric = self.vm_metric.lock().unwrap();
387 vm_metric.start_timestamp = Some(SystemTime::now());
Jiyong Park08eee7b2022-11-11 15:01:26 +0900388 let ret = self.vm_state.lock().unwrap().start(self.clone());
389 if ret.is_ok() {
390 info!("{} started", &self);
391 }
392 ret.with_context(|| format!("{} failed to start", &self))
Andrew Walbranf8d94112021-09-07 11:45:36 +0000393 }
394
Jiyong Parka4eebde2022-07-12 18:01:12 +0900395 /// Monitors the exit of the VM (i.e. termination of the `child` process). When that happens,
396 /// handles the event by updating the state, noityfing the event to clients by calling
397 /// callbacks, and removing temporary files for the VM.
Inseob Kim6ef80972023-07-20 17:23:36 +0900398 fn monitor_vm_exit(
399 &self,
400 child: Arc<SharedChild>,
401 mut failure_pipe_read: File,
Inseob Kim7307a892023-09-14 13:37:58 +0900402 vfio_devices: Vec<VfioDevice>,
Seungjae Yoo3271f172024-06-11 10:14:07 +0900403 tap: Option<File>,
Inseob Kim6ef80972023-07-20 17:23:36 +0900404 ) {
Andrew Walbranc92d35f2022-01-12 12:45:19 +0000405 let result = child.wait();
406 match &result {
Jooyung Hanbfe086f2021-10-28 10:15:45 +0900407 Err(e) => error!("Error waiting for crosvm({}) instance to die: {}", child.id(), e),
Sebastian Ene23167d82022-10-07 14:09:53 +0000408 Ok(status) => {
409 info!("crosvm({}) exited with status {}", child.id(), status);
410 if let Some(exit_status_code) = status.code() {
411 if exit_status_code == CROSVM_WATCHDOG_REBOOT_STATUS {
412 info!("detected vcpu stall on crosvm");
413 }
414 }
415 }
Andrew Walbrandae07162021-03-12 17:05:20 +0000416 }
Andrew Walbranf8d94112021-09-07 11:45:36 +0000417
418 let mut vm_state = self.vm_state.lock().unwrap();
419 *vm_state = VmState::Dead;
420 // Ensure that the mutex is released before calling the callbacks.
421 drop(vm_state);
Jiyong Park08eee7b2022-11-11 15:01:26 +0900422 info!("{} exited", &self);
Andrew Walbranf8d94112021-09-07 11:45:36 +0000423
Jiyong Parka4eebde2022-07-12 18:01:12 +0900424 // Read the pipe to see if any failure reason is written
425 let mut failure_reason = String::new();
426 match failure_pipe_read.read_to_string(&mut failure_reason) {
427 Err(e) => error!("Error reading VM failure reason from pipe: {}", e),
428 Ok(len) if len > 0 => info!("VM returned failure reason '{}'", &failure_reason),
429 _ => (),
Jiyong Parke6ed0f92022-06-22 00:13:00 +0900430 };
Andrew Walbranb27681f2022-02-23 15:11:52 +0000431
Jiyong Parka4eebde2022-07-12 18:01:12 +0900432 // In case of hangup, the pipe doesn't give us any information because the hangup can't be
433 // detected on the VM side (otherwise, it isn't a hangup), but in the
434 // monitor_payload_hangup function below which updates the payload state to Hangup.
435 let failure_reason =
436 if failure_reason.is_empty() && self.payload_state() == PayloadState::Hangup {
437 Cow::from("HANGUP")
438 } else {
439 Cow::from(failure_reason)
440 };
441
Jiyong Parke558ab12022-07-07 20:18:55 +0900442 self.handle_ramdump().unwrap_or_else(|e| error!("Error handling ramdump: {}", e));
Seungjae Yoob4c07ba2022-08-12 04:44:52 +0000443
444 let death_reason = death_reason(&result, &failure_reason);
Seungjae Yoo93430e82022-12-05 16:37:42 +0900445 let exit_signal = exit_signal(&result);
446
Seungjae Yoob4c07ba2022-08-12 04:44:52 +0000447 self.callbacks.callback_on_died(self.cid, death_reason);
Seungjae Yoo2e7beea2022-08-24 16:09:12 +0900448
Seungjae Yoo6d265d92022-11-15 10:51:33 +0900449 let vm_metric = self.vm_metric.lock().unwrap();
Seungjae Yoob2db3d22023-04-06 18:05:43 +0900450 write_vm_exited_stats_sync(
Seungjae Yoo93430e82022-12-05 16:37:42 +0900451 self.requester_uid as i32,
452 &self.name,
453 death_reason,
454 exit_signal,
Chris Wailes75269622022-12-05 23:01:44 -0800455 &vm_metric,
Seungjae Yoo93430e82022-12-05 16:37:42 +0900456 );
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000457
David Brazdil4b4c5102022-12-19 22:56:20 +0000458 // Delete temporary files. The folder itself is removed by VirtualizationServiceInternal.
459 remove_temporary_files(&self.temporary_directory).unwrap_or_else(|e| {
460 error!("Error removing temporary files from {:?}: {}", self.temporary_directory, e);
461 });
Inseob Kim6ef80972023-07-20 17:23:36 +0900462
Seungjae Yoo3271f172024-06-11 10:14:07 +0900463 if let Some(tap_file) = tap {
464 GLOBAL_SERVICE
465 .deleteTapInterface(&ParcelFileDescriptor::new(OwnedFd::from(tap_file)))
466 .unwrap_or_else(|e| {
467 error!("Error deleting TAP interface: {e:?}");
468 });
469 }
470
Jakob Vukalovicd42aa2c2023-11-09 16:04:00 +0000471 drop(vfio_devices); // Cleanup devices.
Andrew Walbrandae07162021-03-12 17:05:20 +0000472 }
473
Jiyong Parka4eebde2022-07-12 18:01:12 +0900474 /// Waits until payload is started, or timeout expires. When timeout occurs, kill
475 /// the VM to prevent indefinite hangup and update the payload_state accordingly.
476 fn monitor_payload_hangup(&self, child: Arc<SharedChild>) {
477 debug!("Starting to monitor hangup for Microdroid({})", child.id());
Jiyong Parkcf975612024-04-07 13:27:10 +0900478 let (state, result) = self
Jiyong Parka4eebde2022-07-12 18:01:12 +0900479 .payload_state_updated
480 .wait_timeout_while(self.payload_state.lock().unwrap(), *BOOT_HANGUP_TIMEOUT, |s| {
481 *s < PayloadState::Started
482 })
483 .unwrap();
Jiyong Parkcf975612024-04-07 13:27:10 +0900484 drop(state); // we are not interested in state
Jiyong Parka4eebde2022-07-12 18:01:12 +0900485 let child_still_running = child.try_wait().ok() == Some(None);
486 if result.timed_out() && child_still_running {
487 error!(
488 "Microdroid({}) failed to start payload within {} secs timeout. Shutting down.",
489 child.id(),
490 BOOT_HANGUP_TIMEOUT.as_secs()
491 );
492 self.update_payload_state(PayloadState::Hangup).unwrap();
493 if let Err(e) = self.kill() {
494 error!("Error stopping timed-out VM with CID {}: {:?}", child.id(), e);
495 }
496 }
497 }
498
Seungjae Yoo6d265d92022-11-15 10:51:33 +0900499 fn monitor_vm_status(&self, child: Arc<SharedChild>) {
500 let pid = child.id();
501
502 loop {
503 {
504 // Check VM state
505 let vm_state = &*self.vm_state.lock().unwrap();
506 if let VmState::Dead = vm_state {
507 break;
508 }
509
510 let mut vm_metric = self.vm_metric.lock().unwrap();
511
512 // Get CPU Information
Jiyong Park85ea5382024-02-19 15:04:23 +0900513 match get_guest_time(pid) {
514 Ok(guest_time) => vm_metric.cpu_guest_time = Some(guest_time),
515 Err(e) => error!("Failed to get guest CPU time: {e:?}"),
Seungjae Yoo6d265d92022-11-15 10:51:33 +0900516 }
517
518 // Get Memory Information
Jiyong Park85ea5382024-02-19 15:04:23 +0900519 match get_rss(pid) {
520 Ok(rss) => {
521 vm_metric.rss = match &vm_metric.rss {
522 Some(x) => Some(Rss::extract_max(x, &rss)),
523 None => Some(rss),
524 }
Seungjae Yoo6d265d92022-11-15 10:51:33 +0900525 }
Jiyong Park85ea5382024-02-19 15:04:23 +0900526 Err(e) => error!("Failed to get guest RSS: {}", e),
Seungjae Yoo6d265d92022-11-15 10:51:33 +0900527 }
528 }
529
530 thread::sleep(Duration::from_secs(1));
531 }
532 }
533
Andrew Walbran6b650662021-09-07 13:13:23 +0000534 /// Returns the last reported state of the VM payload.
535 pub fn payload_state(&self) -> PayloadState {
536 *self.payload_state.lock().unwrap()
537 }
538
539 /// Updates the payload state to the given value, if it is a valid state transition.
540 pub fn update_payload_state(&self, new_state: PayloadState) -> Result<(), Error> {
541 let mut state_locked = self.payload_state.lock().unwrap();
542 // Only allow forward transitions, e.g. from starting to started or finished, not back in
543 // the other direction.
544 if new_state > *state_locked {
545 *state_locked = new_state;
Jiyong Parka4eebde2022-07-12 18:01:12 +0900546 self.payload_state_updated.notify_all();
Andrew Walbran6b650662021-09-07 13:13:23 +0000547 Ok(())
548 } else {
549 bail!("Invalid payload state transition from {:?} to {:?}", *state_locked, new_state)
550 }
551 }
552
Andrew Walbranf8d94112021-09-07 11:45:36 +0000553 /// Kills the crosvm instance, if it is running.
Inseob Kima446f802022-07-11 19:46:37 +0900554 pub fn kill(&self) -> Result<(), Error> {
David Brazdilf18e1162022-12-18 18:27:23 +0000555 let monitor_vm_exit_thread = {
556 let vm_state = &mut *self.vm_state.lock().unwrap();
557 if let VmState::Running { child, monitor_vm_exit_thread } = vm_state {
558 let id = child.id();
559 debug!("Killing crosvm({})", id);
560 // TODO: Talk to crosvm to shutdown cleanly.
561 child.kill().with_context(|| format!("Error killing crosvm({id}) instance"))?;
562 monitor_vm_exit_thread.take()
Inseob Kima446f802022-07-11 19:46:37 +0900563 } else {
David Brazdilf18e1162022-12-18 18:27:23 +0000564 bail!("VM is not running")
Andrew Walbranf8d94112021-09-07 11:45:36 +0000565 }
David Brazdilf18e1162022-12-18 18:27:23 +0000566 };
567
568 // Wait for monitor_vm_exit() to finish. Must release vm_state lock
569 // first, as monitor_vm_exit() takes it as well.
570 monitor_vm_exit_thread.map(JoinHandle::join);
571
David Brazdil5af55832023-03-08 13:08:56 +0000572 // Now that the VM has been killed, shut down the VirtualMachineService
573 // server to eagerly free up the server threads.
574 self.vm_context.vm_server.shutdown()?;
575
David Brazdilf18e1162022-12-18 18:27:23 +0000576 Ok(())
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000577 }
Jiyong Parke558ab12022-07-07 20:18:55 +0900578
Keir Frasercdd4b112022-11-24 14:02:25 +0000579 /// Responds to memory-trimming notifications by inflating the virtio
580 /// balloon to reclaim guest memory.
581 pub fn trim_memory(&self, level: MemoryTrimLevel) -> Result<(), Error> {
582 let request = VmRequest::BalloonCommand(BalloonControlCommand::Stats {});
583 match vm_control::client::handle_request(&request, &self.crosvm_control_socket_path) {
584 Ok(VmResponse::BalloonStats { stats, balloon_actual: _ }) => {
585 if let Some(total_memory) = stats.total_memory {
586 // Reclaim up to 50% of total memory assuming worst case
587 // most memory is anonymous and must be swapped to zram
588 // with an approximate 2:1 compression ratio.
589 let pct = match level {
590 MemoryTrimLevel::TRIM_MEMORY_RUNNING_CRITICAL => 50,
591 MemoryTrimLevel::TRIM_MEMORY_RUNNING_LOW => 30,
592 MemoryTrimLevel::TRIM_MEMORY_RUNNING_MODERATE => 10,
593 _ => bail!("Invalid memory trim level {:?}", level),
594 };
Devin Moore30be4482023-08-21 22:44:26 +0000595 let command = BalloonControlCommand::Adjust {
596 num_bytes: total_memory * pct / 100,
597 wait_for_success: false,
598 };
Keir Frasercdd4b112022-11-24 14:02:25 +0000599 if let Err(e) = vm_control::client::handle_request(
600 &VmRequest::BalloonCommand(command),
601 &self.crosvm_control_socket_path,
602 ) {
603 bail!("Error sending balloon adjustment: {:?}", e);
604 }
605 }
606 }
607 Ok(VmResponse::Err(e)) => {
Alice Wangeff58392023-07-04 13:32:09 +0000608 // ENOTSUP is returned when the balloon protocol is not initialized. This
Keir Frasercdd4b112022-11-24 14:02:25 +0000609 // can occur for numerous reasons: Guest is still booting, guest doesn't
610 // support ballooning, host doesn't support ballooning. We don't log or
611 // raise an error in this case: trim is just a hint and we can ignore it.
612 if e.errno() != libc::ENOTSUP {
613 bail!("Errno return when requesting balloon stats: {}", e.errno())
614 }
615 }
616 e => bail!("Error requesting balloon stats: {:?}", e),
617 }
618 Ok(())
619 }
620
Alan Stokes3e98d292022-12-14 15:18:22 +0000621 /// Checks if ramdump has been created. If so, send it to tombstoned.
Jiyong Parke558ab12022-07-07 20:18:55 +0900622 fn handle_ramdump(&self) -> Result<(), Error> {
623 let ramdump_path = self.temporary_directory.join("ramdump");
Jiyong Park933d2b22023-02-28 11:41:19 +0900624 if !ramdump_path.as_path().try_exists()? {
625 return Ok(());
626 }
Jiyong Parke558ab12022-07-07 20:18:55 +0900627 if std::fs::metadata(&ramdump_path)?.len() > 0 {
Jiyong Park1612b902022-08-22 14:47:39 +0900628 Self::send_ramdump_to_tombstoned(&ramdump_path)?;
Jiyong Parke558ab12022-07-07 20:18:55 +0900629 }
630 Ok(())
631 }
Jiyong Park1612b902022-08-22 14:47:39 +0900632
633 fn send_ramdump_to_tombstoned(ramdump_path: &Path) -> Result<(), Error> {
634 let mut input = File::open(ramdump_path)
Alan Stokes3e98d292022-12-14 15:18:22 +0000635 .context(format!("Failed to open ramdump {:?} for reading", ramdump_path))?;
Jiyong Park1612b902022-08-22 14:47:39 +0900636
637 let pid = std::process::id() as i32;
638 let conn = TombstonedConnection::connect(pid, DebuggerdDumpType::Tombstone)
639 .context("Failed to connect to tombstoned")?;
640 let mut output = conn
641 .text_output
642 .as_ref()
643 .ok_or_else(|| anyhow!("Could not get file to write the tombstones on"))?;
644
645 std::io::copy(&mut input, &mut output).context("Failed to send ramdump to tombstoned")?;
646 info!("Ramdump {:?} sent to tombstoned", ramdump_path);
647
648 conn.notify_completion()?;
649 Ok(())
650 }
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000651}
652
Seungjae Yoo6d265d92022-11-15 10:51:33 +0900653impl Rss {
654 fn extract_max(x: &Rss, y: &Rss) -> Rss {
655 Rss { vm: max(x.vm, y.vm), crosvm: max(x.crosvm, y.crosvm) }
656 }
657}
658
David Daiaaecf652024-02-22 14:41:39 -0800659// Get Cpus_allowed mask
660fn check_if_all_cpus_allowed() -> Result<bool> {
661 let file = read_to_string("/proc/self/status")?;
662 let lines: Vec<_> = file.split('\n').collect();
663
664 for line in lines {
665 if line.contains("Cpus_allowed_list") {
666 let prop: Vec<_> = line.split_whitespace().collect();
667 if prop.len() != 2 {
668 return Ok(false);
669 }
670 let cpu_list: Vec<_> = prop[1].split('-').collect();
671 //Only contiguous Cpu list allowed
672 if cpu_list.len() != 2 {
673 return Ok(false);
674 }
675 if let Some(cpus) = get_num_cpus() {
676 let max_cpu = cpu_list[1].parse::<usize>()?;
677 if max_cpu == cpus - 1 {
678 return Ok(true);
679 } else {
680 return Ok(false);
681 }
682 }
683 }
684 }
685 Ok(false)
686}
687
Seungjae Yoo6d265d92022-11-15 10:51:33 +0900688// Get guest time from /proc/[crosvm pid]/stat
689fn get_guest_time(pid: u32) -> Result<i64> {
690 let file = read_to_string(format!("/proc/{}/stat", pid))?;
691 let data_list: Vec<_> = file.split_whitespace().collect();
692
693 // Information about guest_time is at 43th place of the file split with the whitespace.
694 // Example of /proc/[pid]/stat :
695 // 6603 (kworker/104:1H-kblockd) I 2 0 0 0 -1 69238880 0 0 0 0 0 88 0 0 0 -20 1 0 1845 0 0
696 // 18446744073709551615 0 0 0 0 0 0 0 2147483647 0 0 0 0 17 104 0 0 0 0 0 0 0 0 0 0 0 0 0
697 if data_list.len() < 43 {
698 bail!("Failed to parse command result for getting guest time : {}", file);
699 }
700
701 let guest_time_ticks = data_list[42].parse::<i64>()?;
Andrew Walbranb58d1b42023-07-07 13:54:49 +0100702 // SAFETY: It just returns an integer about CPU tick information.
Charisee96113f32023-01-26 09:00:42 +0000703 let ticks_per_sec = unsafe { sysconf(_SC_CLK_TCK) };
Seungjae Yoo6d265d92022-11-15 10:51:33 +0900704 Ok(guest_time_ticks * MILLIS_PER_SEC / ticks_per_sec)
705}
706
707// Get rss from /proc/[crosvm pid]/smaps
708fn get_rss(pid: u32) -> Result<Rss> {
709 let file = read_to_string(format!("/proc/{}/smaps", pid))?;
710 let lines: Vec<_> = file.split('\n').collect();
711
712 let mut rss_vm_total = 0i64;
713 let mut rss_crosvm_total = 0i64;
714 let mut is_vm = false;
715 for line in lines {
716 if line.contains("crosvm_guest") {
717 is_vm = true;
718 } else if line.contains("Rss:") {
719 let data_list: Vec<_> = line.split_whitespace().collect();
720 if data_list.len() < 2 {
721 bail!("Failed to parse command result for getting rss :\n{}", line);
722 }
723 let rss = data_list[1].parse::<i64>()?;
724
725 if is_vm {
726 rss_vm_total += rss;
727 is_vm = false;
728 }
729 rss_crosvm_total += rss;
730 }
731 }
732
733 Ok(Rss { vm: rss_vm_total, crosvm: rss_crosvm_total })
734}
735
Alan Stokes3ba10fd2022-10-06 15:46:51 +0100736fn death_reason(result: &Result<ExitStatus, io::Error>, mut failure_reason: &str) -> DeathReason {
Pierre-Clément Tosic0611e72023-09-15 11:41:07 +0100737 if let Some((reason, info)) = failure_reason.split_once('|') {
Alan Stokes3ba10fd2022-10-06 15:46:51 +0100738 // Separator indicates extra context information is present after the failure name.
Pierre-Clément Tosic0611e72023-09-15 11:41:07 +0100739 error!("Failure info: {info}");
740 failure_reason = reason;
Alan Stokes3ba10fd2022-10-06 15:46:51 +0100741 }
Andrew Walbranc92d35f2022-01-12 12:45:19 +0000742 if let Ok(status) = result {
Andrew Walbranb27681f2022-02-23 15:11:52 +0000743 match failure_reason {
744 "PVM_FIRMWARE_PUBLIC_KEY_MISMATCH" => {
745 return DeathReason::PVM_FIRMWARE_PUBLIC_KEY_MISMATCH
746 }
747 "PVM_FIRMWARE_INSTANCE_IMAGE_CHANGED" => {
748 return DeathReason::PVM_FIRMWARE_INSTANCE_IMAGE_CHANGED
749 }
Inseob Kim272f5722022-06-13 17:14:51 +0900750 "MICRODROID_FAILED_TO_CONNECT_TO_VIRTUALIZATION_SERVICE" => {
751 return DeathReason::MICRODROID_FAILED_TO_CONNECT_TO_VIRTUALIZATION_SERVICE
752 }
753 "MICRODROID_PAYLOAD_HAS_CHANGED" => return DeathReason::MICRODROID_PAYLOAD_HAS_CHANGED,
754 "MICRODROID_PAYLOAD_VERIFICATION_FAILED" => {
755 return DeathReason::MICRODROID_PAYLOAD_VERIFICATION_FAILED
756 }
757 "MICRODROID_INVALID_PAYLOAD_CONFIG" => {
758 return DeathReason::MICRODROID_INVALID_PAYLOAD_CONFIG
759 }
760 "MICRODROID_UNKNOWN_RUNTIME_ERROR" => {
761 return DeathReason::MICRODROID_UNKNOWN_RUNTIME_ERROR
762 }
Jiyong Parke6ed0f92022-06-22 00:13:00 +0900763 "HANGUP" => return DeathReason::HANGUP,
Andrew Walbranb27681f2022-02-23 15:11:52 +0000764 _ => {}
765 }
Andrew Walbranc92d35f2022-01-12 12:45:19 +0000766 match status.code() {
767 None => DeathReason::KILLED,
768 Some(0) => DeathReason::SHUTDOWN,
Alan Stokes7c459e82022-12-06 12:21:49 +0000769 Some(CROSVM_START_ERROR_STATUS) => DeathReason::START_FAILED,
Andrew Walbranc92d35f2022-01-12 12:45:19 +0000770 Some(CROSVM_REBOOT_STATUS) => DeathReason::REBOOT,
Andrew Walbrand15c5632022-02-03 13:38:31 +0000771 Some(CROSVM_CRASH_STATUS) => DeathReason::CRASH,
Sebastian Ene23167d82022-10-07 14:09:53 +0000772 Some(CROSVM_WATCHDOG_REBOOT_STATUS) => DeathReason::WATCHDOG_REBOOT,
Andrew Walbranc92d35f2022-01-12 12:45:19 +0000773 Some(_) => DeathReason::UNKNOWN,
774 }
775 } else {
776 DeathReason::INFRASTRUCTURE_ERROR
777 }
778}
779
Seungjae Yoo93430e82022-12-05 16:37:42 +0900780fn exit_signal(result: &Result<ExitStatus, io::Error>) -> Option<i32> {
781 match result {
782 Ok(status) => status.signal(),
783 Err(_) => None,
784 }
785}
786
Inseob Kim6ef80972023-07-20 17:23:36 +0900787const SYSFS_PLATFORM_DEVICES_PATH: &str = "/sys/devices/platform/";
788const VFIO_PLATFORM_DRIVER_PATH: &str = "/sys/bus/platform/drivers/vfio-platform";
789
Inseob Kim7307a892023-09-14 13:37:58 +0900790fn vfio_argument_for_platform_device(device: &VfioDevice) -> Result<String, Error> {
Inseob Kim6ef80972023-07-20 17:23:36 +0900791 // Check platform device exists
Jakob Vukalovicd42aa2c2023-11-09 16:04:00 +0000792 let path = Path::new(&device.getSysfsPath()?).canonicalize()?;
Inseob Kim6ef80972023-07-20 17:23:36 +0900793 if !path.starts_with(SYSFS_PLATFORM_DEVICES_PATH) {
794 bail!("{path:?} is not a platform device");
795 }
796
797 // Check platform device is bound to VFIO driver
798 let dev_driver_path = path.join("driver").canonicalize()?;
799 if dev_driver_path != Path::new(VFIO_PLATFORM_DRIVER_PATH) {
800 bail!("{path:?} is not bound to VFIO-platform driver");
801 }
802
803 if let Some(p) = path.to_str() {
Jakob Vukalovicd42aa2c2023-11-09 16:04:00 +0000804 Ok(format!("--vfio={p},iommu=pkvm-iommu,dt-symbol={0}", device.getDtboLabel()?))
Inseob Kim6ef80972023-07-20 17:23:36 +0900805 } else {
806 bail!("invalid path {path:?}");
807 }
808}
809
David Brazdil2dfefd12023-11-17 14:07:36 +0000810fn append_platform_devices(
811 command: &mut Command,
812 preserved_fds: &mut Vec<RawFd>,
813 config: &CrosvmConfig,
814) -> Result<(), Error> {
815 if config.vfio_devices.is_empty() {
816 return Ok(());
817 }
818
819 let Some(dtbo) = &config.dtbo else {
820 bail!("VFIO devices assigned but no DTBO available");
821 };
822 command.arg(format!("--device-tree-overlay={},filter", add_preserved_fd(preserved_fds, dtbo)));
823
Inseob Kim6ef80972023-07-20 17:23:36 +0900824 for device in &config.vfio_devices {
825 command.arg(vfio_argument_for_platform_device(device)?);
826 }
Inseob Kim6ef80972023-07-20 17:23:36 +0900827 Ok(())
828}
829
Andrew Walbrand3a84182021-09-07 14:48:52 +0000830/// Starts an instance of `crosvm` to manage a new VM.
Keir Fraser13a956a2022-07-14 14:20:46 +0000831fn run_vm(
832 config: CrosvmConfig,
Keir Frasercdd4b112022-11-24 14:02:25 +0000833 crosvm_control_socket_path: &Path,
Keir Fraser13a956a2022-07-14 14:20:46 +0000834 failure_pipe_write: File,
835) -> Result<SharedChild, Error> {
Andrew Walbrand3a84182021-09-07 14:48:52 +0000836 validate_config(&config)?;
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000837
838 let mut command = Command::new(CROSVM_PATH);
839 // TODO(qwandor): Remove --disable-sandbox.
Andrew Walbranc92d35f2022-01-12 12:45:19 +0000840 command
841 .arg("--extended-status")
Jiyong Park6c60fea2022-10-24 16:10:01 +0900842 // Configure the logger for the crosvm process to silence logs from the disk crate which
843 // don't provide much information to us (but do spamming us).
844 .arg("--log-level")
Frederick Mayle138f53c2023-01-24 18:55:26 -0800845 .arg("info,disk=warn")
Andrew Walbranc92d35f2022-01-12 12:45:19 +0000846 .arg("run")
847 .arg("--disable-sandbox")
848 .arg("--cid")
849 .arg(config.cid.to_string());
Andrew Walbran3a5a9212021-05-04 17:09:08 +0000850
Keir Fraserf25cb922022-11-23 14:26:00 +0000851 if system_properties::read_bool("hypervisor.memory_reclaim.supported", false)? {
852 command.arg("--balloon-page-reporting");
853 } else {
854 command.arg("--no-balloon");
855 }
856
Andrew Walbranf8650422021-06-09 15:54:09 +0000857 if config.protected {
Jaewan Kim46422812022-11-25 10:59:39 +0900858 match system_properties::read(SYSPROP_CUSTOM_PVMFW_PATH)? {
859 Some(pvmfw_path) if !pvmfw_path.is_empty() => {
860 command.arg("--protected-vm-with-firmware").arg(pvmfw_path)
861 }
862 _ => command.arg("--protected-vm"),
863 };
Andrew Walbran0b5789f2022-02-04 13:57:57 +0000864
865 // 3 virtio-console devices + vsock = 4.
866 let virtio_pci_device_count = 4 + config.disks.len();
867 // crosvm virtio queue has 256 entries, so 2 MiB per device (2 pages per entry) should be
868 // enough.
Jiyong Park3115cdb2023-02-24 18:04:44 +0900869 let swiotlb_size_mib = 2 * virtio_pci_device_count as u32;
Andrew Walbran0b5789f2022-02-04 13:57:57 +0000870 command.arg("--swiotlb").arg(swiotlb_size_mib.to_string());
Frederick Mayle58baa302023-02-14 19:06:37 -0800871
872 // Workaround to keep crash_dump from trying to read protected guest memory.
873 // Context in b/238324526.
874 command.arg("--unmap-guest-memory-on-fork");
Jiyong Park3115cdb2023-02-24 18:04:44 +0900875
Jiyong Parked180932023-02-24 19:55:41 +0900876 if config.ramdump.is_some() {
Jaewan Kim3124ef02023-03-23 19:25:20 +0900877 // Protected VM needs to reserve memory for ramdump here. Note that we reserve more
Jiyong Parked180932023-02-24 19:55:41 +0900878 // memory for the restricted dma pool.
879 let ramdump_reserve = RAMDUMP_RESERVED_MIB + swiotlb_size_mib;
880 command.arg("--params").arg(format!("crashkernel={ramdump_reserve}M"));
881 }
Jaewan Kimd4dae652023-03-28 13:45:43 +0900882 } else if config.ramdump.is_some() {
883 command.arg("--params").arg(format!("crashkernel={RAMDUMP_RESERVED_MIB}M"));
884 }
Jaewan Kim61f86142023-03-28 15:12:52 +0900885 if config.debug_config.debug_level == DebugLevel::NONE
886 && config.debug_config.should_prepare_console_output()
887 {
Jaewan Kimd4dae652023-03-28 13:45:43 +0900888 // bootconfig.normal will be used, but we need log.
889 command.arg("--params").arg("printk.devkmsg=on");
890 command.arg("--params").arg("console=hvc0");
Andrew Walbranf8650422021-06-09 15:54:09 +0000891 }
892
Andrew Walbranb15cd6e2021-07-05 16:38:07 +0000893 if let Some(memory_mib) = config.memory_mib {
894 command.arg("--mem").arg(memory_mib.to_string());
895 }
896
Jiyong Park032615f2022-01-10 13:55:34 +0900897 if let Some(cpus) = config.cpus {
898 command.arg("--cpus").arg(cpus.to_string());
899 }
900
David Brazdil7d1e5ec2023-02-06 17:56:29 +0000901 if config.host_cpu_topology {
David Daiaaecf652024-02-22 14:41:39 -0800902 if cfg!(virt_cpufreq) && check_if_all_cpus_allowed()? {
David Daie6f5bb02024-01-25 19:17:02 -0800903 command.arg("--host-cpu-topology");
David Daic97e82d2024-02-17 12:10:31 -0800904 cfg_if::cfg_if! {
905 if #[cfg(any(target_arch = "aarch64"))] {
906 command.arg("--virt-cpufreq");
907 }
908 }
David Daie6f5bb02024-01-25 19:17:02 -0800909 } else if let Some(cpus) = get_num_cpus() {
David Brazdil25e8c052023-02-17 12:53:01 +0000910 command.arg("--cpus").arg(cpus.to_string());
911 } else {
912 bail!("Could not determine the number of CPUs in the system");
913 }
David Brazdil7d1e5ec2023-02-06 17:56:29 +0000914 }
915
Nikita Ioffe5776f082023-02-10 21:38:26 +0000916 if let Some(gdb_port) = config.gdb_port {
917 command.arg("--gdb").arg(gdb_port.to_string());
918 }
919
Jiyong Parkfa91d702021-10-18 23:51:39 +0900920 // Keep track of what file descriptors should be mapped to the crosvm process.
921 let mut preserved_fds = config.indirect_files.iter().map(|file| file.as_raw_fd()).collect();
922
Jiyong Park747d6362021-10-19 17:12:52 +0900923 // Setup the serial devices.
924 // 1. uart device: used as the output device by bootloaders and as early console by linux
Andrew Walbranb27681f2022-02-23 15:11:52 +0000925 // 2. uart device: used to report the reason for the VM failing.
926 // 3. virtio-console device: used as the console device where kmsg is redirected to
Jiyong Park4afe2012022-07-08 05:38:49 +0900927 // 4. virtio-console device: used as the ramdump output
Andrew Walbranb27681f2022-02-23 15:11:52 +0000928 // 5. virtio-console device: used as the logcat output
Jiyong Park747d6362021-10-19 17:12:52 +0900929 //
Jiyong Parkb8182bb2021-10-26 22:53:08 +0900930 // When [console|log]_fd is not specified, the devices are attached to sink, which means what's
931 // written there is discarded.
Jiyong Parke6fb1672023-06-26 16:45:55 +0900932 let console_out_arg = format_serial_out_arg(&mut preserved_fds, &config.console_out_fd);
933 let console_in_arg = config
934 .console_in_fd
935 .as_ref()
936 .map(|fd| format!(",input={}", add_preserved_fd(&mut preserved_fds, fd)))
937 .unwrap_or_default();
938 let log_arg = format_serial_out_arg(&mut preserved_fds, &config.log_fd);
Andrew Walbranb27681f2022-02-23 15:11:52 +0000939 let failure_serial_path = add_preserved_fd(&mut preserved_fds, &failure_pipe_write);
Jiyong Parke6fb1672023-06-26 16:45:55 +0900940 let ramdump_arg = format_serial_out_arg(&mut preserved_fds, &config.ramdump);
Yi-Yo Chiang8dd32552024-05-22 19:38:16 +0800941 let console_input_device = config.console_input_device.as_deref().unwrap_or(CONSOLE_HVC0);
942 match console_input_device {
943 CONSOLE_HVC0 | CONSOLE_TTYS0 => {}
944 _ => bail!("Unsupported serial device {console_input_device}"),
945 };
Jiyong Parkfa91d702021-10-18 23:51:39 +0900946
Jiyong Park747d6362021-10-19 17:12:52 +0900947 // Warning: Adding more serial devices requires you to shift the PCI device ID of the boot
948 // disks in bootconfig.x86_64. This is because x86 crosvm puts serial devices and the block
949 // devices in the same PCI bus and serial devices comes before the block devices. Arm crosvm
950 // doesn't have the issue.
Jiyong Parkfa91d702021-10-18 23:51:39 +0900951 // /dev/ttyS0
Yi-Yo Chiang8dd32552024-05-22 19:38:16 +0800952 command.arg(format!(
953 "--serial={}{},hardware=serial,num=1",
954 &console_out_arg,
955 if console_input_device == CONSOLE_TTYS0 { &console_in_arg } else { "" }
956 ));
Andrew Walbranb27681f2022-02-23 15:11:52 +0000957 // /dev/ttyS1
958 command.arg(format!("--serial=type=file,path={},hardware=serial,num=2", &failure_serial_path));
Jiyong Parkfa91d702021-10-18 23:51:39 +0900959 // /dev/hvc0
Jiyong Parke6fb1672023-06-26 16:45:55 +0900960 command.arg(format!(
961 "--serial={}{},hardware=virtio-console,num=1",
Yi-Yo Chiang8dd32552024-05-22 19:38:16 +0800962 &console_out_arg,
963 if console_input_device == CONSOLE_HVC0 { &console_in_arg } else { "" }
Jiyong Parke6fb1672023-06-26 16:45:55 +0900964 ));
Jiyong Park4afe2012022-07-08 05:38:49 +0900965 // /dev/hvc1
966 command.arg(format!("--serial={},hardware=virtio-console,num=2", &ramdump_arg));
Jiyong Parkae5a4ed2021-11-01 18:36:28 +0900967 // /dev/hvc2
968 command.arg(format!("--serial={},hardware=virtio-console,num=3", &log_arg));
Andrew Walbran3a5a9212021-05-04 17:09:08 +0000969
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000970 if let Some(bootloader) = &config.bootloader {
Andrew Walbran02b8ec02021-06-22 13:07:02 +0000971 command.arg("--bios").arg(add_preserved_fd(&mut preserved_fds, bootloader));
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000972 }
Andrew Walbran3a5a9212021-05-04 17:09:08 +0000973
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000974 if let Some(initrd) = &config.initrd {
Andrew Walbran02b8ec02021-06-22 13:07:02 +0000975 command.arg("--initrd").arg(add_preserved_fd(&mut preserved_fds, initrd));
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000976 }
Andrew Walbran3a5a9212021-05-04 17:09:08 +0000977
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000978 if let Some(params) = &config.params {
979 command.arg("--params").arg(params);
980 }
Andrew Walbran3a5a9212021-05-04 17:09:08 +0000981
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000982 for disk in &config.disks {
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000983 command
984 .arg(if disk.writable { "--rwdisk" } else { "--disk" })
Andrew Walbran02b8ec02021-06-22 13:07:02 +0000985 .arg(add_preserved_fd(&mut preserved_fds, &disk.image));
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000986 }
Andrew Walbran3a5a9212021-05-04 17:09:08 +0000987
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000988 if let Some(kernel) = &config.kernel {
Andrew Walbran02b8ec02021-06-22 13:07:02 +0000989 command.arg(add_preserved_fd(&mut preserved_fds, kernel));
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000990 }
Andrew Walbran3a5a9212021-05-04 17:09:08 +0000991
Keir Frasercdd4b112022-11-24 14:02:25 +0000992 let control_server_socket = UnixSeqpacketListener::bind(crosvm_control_socket_path)
993 .context("failed to create control server")?;
Elie Kheirallah2d12ff32023-03-20 18:12:07 +0000994 command
995 .arg("--socket")
996 .arg(add_preserved_fd(&mut preserved_fds, &control_server_socket.as_raw_descriptor()));
Keir Fraser13a956a2022-07-14 14:20:46 +0000997
Shikha Panwar55e10ec2024-02-13 12:53:49 +0000998 if let Some(dt_overlay) = &config.device_tree_overlay {
999 command.arg("--device-tree-overlay").arg(add_preserved_fd(&mut preserved_fds, dt_overlay));
Seungjae Yoo4dd38182023-11-09 15:05:45 +09001000 }
Jeongik Cha798401c2024-04-11 21:54:49 +09001001
1002 if cfg!(paravirtualized_devices) {
1003 if let Some(display_config) = &config.display_config {
1004 command.arg("--gpu")
1005 // TODO(b/331708504): support backend config as well
1006 .arg("backend=virglrenderer,context-types=virgl2,egl=true,surfaceless=true,glx=false,gles=true")
1007 .arg(format!("--gpu-display=mode=windowed[{},{}],dpi=[{},{}],refresh-rate={}", display_config.width, display_config.height, display_config.horizontal_dpi, display_config.vertical_dpi, display_config.refresh_rate))
1008 .arg(format!("--android-display-service={}", config.name));
1009 }
Jeongik Cha1df1c032024-04-03 16:03:12 +09001010 }
Seungjae Yooec3bc522023-11-09 10:14:30 +09001011
Jeongik Chac181be72024-03-27 00:18:30 +09001012 if cfg!(paravirtualized_devices) {
Seungjae Yoo986d7a42024-05-28 14:06:58 +09001013 // TODO(b/340376951): Remove this after tap in CrosvmConfig is connected to tethering.
Jeongik Cha6be4f8b2024-04-16 01:13:13 +09001014 if rustutils::system_properties::read_bool("ro.crosvm.network.setup.done", false)
1015 .unwrap_or(false)
1016 {
1017 command.arg("--net").arg("tap-name=crosvm_tap");
1018 }
1019 }
1020
Seungjae Yoo986d7a42024-05-28 14:06:58 +09001021 if cfg!(network) {
1022 if let Some(tap) = &config.tap {
1023 let tap_fd = tap.as_raw_fd();
1024 preserved_fds.push(tap_fd);
1025 command.arg("--net").arg(format!("tap-fd={}", tap_fd));
1026 }
1027 }
1028
Jeongik Cha6be4f8b2024-04-16 01:13:13 +09001029 if cfg!(paravirtualized_devices) {
Jeongik Chac181be72024-03-27 00:18:30 +09001030 for input_device_option in config.input_device_options.iter() {
1031 command.arg("--input");
1032 command.arg(match input_device_option {
1033 InputDeviceOption::EvDev(file) => {
1034 format!("evdev[path={}]", add_preserved_fd(&mut preserved_fds, file))
1035 }
Jeongik Cha985b6402024-04-15 18:13:00 +09001036 InputDeviceOption::Keyboard(file) => {
1037 format!("keyboard[path={}]", add_preserved_fd(&mut preserved_fds, file))
1038 }
Jeongik Cha343894e2024-05-17 20:39:31 +09001039 InputDeviceOption::Mouse(file) => {
1040 format!("mouse[path={}]", add_preserved_fd(&mut preserved_fds, file))
1041 }
Jeongik Chac181be72024-03-27 00:18:30 +09001042 InputDeviceOption::SingleTouch { file, width, height, name } => format!(
1043 "single-touch[path={},width={},height={}{}]",
1044 add_preserved_fd(&mut preserved_fds, file),
1045 width,
1046 height,
1047 name.as_ref().map_or("".into(), |n| format!(",name={}", n))
1048 ),
1049 });
1050 }
1051 }
Vincent Donnefort538a2c62024-03-20 16:01:10 +00001052
1053 if config.hugepages {
1054 command.arg("--hugepages");
1055 }
1056
David Brazdil2dfefd12023-11-17 14:07:36 +00001057 append_platform_devices(&mut command, &mut preserved_fds, &config)?;
Inseob Kim6ef80972023-07-20 17:23:36 +09001058
Andrew Walbran02b8ec02021-06-22 13:07:02 +00001059 debug!("Preserving FDs {:?}", preserved_fds);
1060 command.preserved_fds(preserved_fds);
Andrew Walbran3a5a9212021-05-04 17:09:08 +00001061
Mu-Le Lee134180a2024-04-16 15:13:07 +08001062 if cfg!(paravirtualized_devices) {
1063 if let Some(virtio_snd_backend) = &config.virtio_snd_backend {
1064 command.arg("--virtio-snd").arg(format!("backend={}", virtio_snd_backend));
1065 }
1066 }
1067
Jiyong Park2d736562022-10-24 22:40:12 +09001068 print_crosvm_args(&command);
1069
Andrew Walbran3a5a9212021-05-04 17:09:08 +00001070 let result = SharedChild::spawn(&mut command)?;
Jooyung Hanbfe086f2021-10-28 10:15:45 +09001071 debug!("Spawned crosvm({}).", result.id());
Andrew Walbran3a5a9212021-05-04 17:09:08 +00001072 Ok(result)
1073}
1074
1075/// Ensure that the configuration has a valid combination of fields set, or return an error if not.
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +00001076fn validate_config(config: &CrosvmConfig) -> Result<(), Error> {
Andrew Walbran3a5a9212021-05-04 17:09:08 +00001077 if config.bootloader.is_none() && config.kernel.is_none() {
1078 bail!("VM must have either a bootloader or a kernel image.");
1079 }
1080 if config.bootloader.is_some() && (config.kernel.is_some() || config.initrd.is_some()) {
1081 bail!("Can't have both bootloader and kernel/initrd image.");
1082 }
Jiyong Parkdcf17412022-02-08 15:07:23 +09001083 let version = Version::parse(CROSVM_PLATFORM_VERSION).unwrap();
1084 if !config.platform_version.matches(&version) {
1085 bail!(
1086 "Incompatible platform version. The config is compatible with platform version(s) \
1087 {}, but the actual platform version is {}",
1088 config.platform_version,
1089 version
1090 );
1091 }
1092
Andrew Walbran3a5a9212021-05-04 17:09:08 +00001093 Ok(())
1094}
1095
Jiyong Park2d736562022-10-24 22:40:12 +09001096/// Print arguments of the crosvm command. In doing so, /proc/self/fd/XX is annotated with the
1097/// actual file path if the FD is backed by a regular file. If not, the /proc path is printed
1098/// unmodified.
1099fn print_crosvm_args(command: &Command) {
1100 let re = Regex::new(r"/proc/self/fd/[\d]+").unwrap();
1101 info!(
1102 "Running crosvm with args: {:?}",
1103 command
1104 .get_args()
1105 .map(|s| s.to_string_lossy())
1106 .map(|s| {
1107 re.replace_all(&s, |caps: &Captures| {
1108 let path = &caps[0];
1109 if let Ok(realpath) = std::fs::canonicalize(path) {
1110 format!("{} ({})", path, realpath.to_string_lossy())
1111 } else {
1112 path.to_owned()
1113 }
1114 })
1115 .into_owned()
1116 })
1117 .collect::<Vec<_>>()
1118 );
1119}
1120
Andrew Walbran02b8ec02021-06-22 13:07:02 +00001121/// Adds the file descriptor for `file` to `preserved_fds`, and returns a string of the form
1122/// "/proc/self/fd/N" where N is the file descriptor.
Keir Fraser13a956a2022-07-14 14:20:46 +00001123fn add_preserved_fd(preserved_fds: &mut Vec<RawFd>, file: &dyn AsRawFd) -> String {
Andrew Walbran3a5a9212021-05-04 17:09:08 +00001124 let fd = file.as_raw_fd();
Andrew Walbran02b8ec02021-06-22 13:07:02 +00001125 preserved_fds.push(fd);
Andrew Walbran3a5a9212021-05-04 17:09:08 +00001126 format!("/proc/self/fd/{}", fd)
Andrew Walbrand6dce6f2021-03-05 16:39:08 +00001127}
Andrew Walbranb27681f2022-02-23 15:11:52 +00001128
1129/// Adds the file descriptor for `file` (if any) to `preserved_fds`, and returns the appropriate
1130/// string for a crosvm `--serial` flag. If `file` is none, creates a dummy sink device.
Jiyong Parke6fb1672023-06-26 16:45:55 +09001131fn format_serial_out_arg(preserved_fds: &mut Vec<RawFd>, file: &Option<File>) -> String {
Andrew Walbranb27681f2022-02-23 15:11:52 +00001132 if let Some(file) = file {
1133 format!("type=file,path={}", add_preserved_fd(preserved_fds, file))
1134 } else {
1135 "type=sink".to_string()
1136 }
1137}
1138
1139/// Creates a new pipe with the `O_CLOEXEC` flag set, and returns the read side and write side.
1140fn create_pipe() -> Result<(File, File), Error> {
Frederick Maylefbbcfcd2024-04-08 16:31:54 -07001141 let (read_fd, write_fd) = pipe2(OFlag::O_CLOEXEC)?;
1142 Ok((read_fd.into(), write_fd.into()))
Andrew Walbranb27681f2022-02-23 15:11:52 +00001143}