commit fe132801509825ec00548cd4b56bb2633e16a33e
author Jeongik Cha <jeongik@google.com> Wed Jul 17 09:33:17 2024 +0000
committer Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> Wed Jul 17 09:33:17 2024 +0000
tree 4cee7e20f322c7d9f7cb342a569bb1a0177c8a11
parent cac3fefaaadec6efd692f1b2201a5e1837be645b
parent 6734b0da9fe31865b910eaa5c83e9645be33d04e

Drop system shared uid in ferrochrome app am: 6734b0da9f

Original change: https://android-review.googlesource.com/c/platform/packages/modules/Virtualization/+/3179239

Change-Id: I9d40a2821f952be463b4d164e0ee0be50c114d86
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

ferrochrome_app/Android.bp

diff --git a/ferrochrome_app/Android.bp b/ferrochrome_app/Android.bp
index b3998a7..29a16d0 100644
--- a/ferrochrome_app/Android.bp
+++ b/ferrochrome_app/Android.bp
@@ -12,10 +12,6 @@
     privileged: true,
     init_rc: ["custom_vm_setup.rc"],
     required: ["custom_vm_setup"],
-    certificate: "platform",
-    static_libs: [
-        "apache-commons-compress",
-    ],
 }
 
 sh_binary {

ferrochrome_app/AndroidManifest.xml

diff --git a/ferrochrome_app/AndroidManifest.xml b/ferrochrome_app/AndroidManifest.xml
index d0aa62c..62b065d 100644
--- a/ferrochrome_app/AndroidManifest.xml
+++ b/ferrochrome_app/AndroidManifest.xml
@@ -1,9 +1,16 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    package="com.android.virtualization.ferrochrome"
-    android:sharedUserId="android.uid.system" >
+    package="com.android.virtualization.ferrochrome" >
 
     <uses-permission android:name="android.permission.INTERNET" />
+    <uses-permission android:name="android.permission.KILL_BACKGROUND_PROCESSES" />
+    <uses-permission android:name="android.permission.KILL_ALL_BACKGROUND_PROCESSES" />
+    <uses-permission android:name="android.permission.MANAGE_EXTERNAL_STORAGE" />
+    <queries>
+        <intent>
+            <action android:name="android.virtualization.VM_LAUNCHER" />
+        </intent>
+    </queries>
     <application
         android:label="Ferrochrome">
         <activity android:name=".FerrochromeActivity"

ferrochrome_app/java/com/android/virtualization/ferrochrome/FerrochromeActivity.java

diff --git a/ferrochrome_app/java/com/android/virtualization/ferrochrome/FerrochromeActivity.java b/ferrochrome_app/java/com/android/virtualization/ferrochrome/FerrochromeActivity.java
index 40af3b6..5006413 100644
--- a/ferrochrome_app/java/com/android/virtualization/ferrochrome/FerrochromeActivity.java
+++ b/ferrochrome_app/java/com/android/virtualization/ferrochrome/FerrochromeActivity.java
@@ -120,6 +120,7 @@
         updateStatus("Done.");
 
         updateStatus("Extracting images...");
+        SystemProperties.set("debug.custom_vm_setup.done", "false");
         SystemProperties.set("debug.custom_vm_setup.start", "true");
         while (!SystemProperties.getBoolean("debug.custom_vm_setup.done", false)) {
             try {
@@ -130,14 +131,6 @@
                 return false;
             }
         }
-        // TODO(jiyong): remove this sleep.
-        try {
-            Thread.sleep(30 * 1000);
-        } catch (Exception e) {
-            Log.e(TAG, "Interrupted while waiting for the copy to finish");
-            updateStatus("Failed.");
-            return false;
-        }
 
         updateStatus("Done.");
         return true;